networking: disable tethering toggle while connecting (#21785)

* disable until connected

* disabling takes longest

* try enabling on refresh

* clean up
pull/21795/head^2
sshane 4 years ago committed by GitHub
parent c7fc312237
commit e28785199f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      selfdrive/ui/qt/offroad/networking.cc
  2. 1
      selfdrive/ui/qt/offroad/networking.h

@ -124,7 +124,7 @@ AdvancedNetworking::AdvancedNetworking(QWidget* parent, WifiManager* wifi): QWid
main_layout->addWidget(back, 0, Qt::AlignLeft); main_layout->addWidget(back, 0, Qt::AlignLeft);
// Enable tethering layout // Enable tethering layout
ToggleControl *tetheringToggle = new ToggleControl("Enable Tethering", "", "", wifi->isTetheringEnabled()); tetheringToggle = new ToggleControl("Enable Tethering", "", "", wifi->isTetheringEnabled());
main_layout->addWidget(tetheringToggle); main_layout->addWidget(tetheringToggle);
QObject::connect(tetheringToggle, &ToggleControl::toggleFlipped, this, &AdvancedNetworking::toggleTethering); QObject::connect(tetheringToggle, &ToggleControl::toggleFlipped, this, &AdvancedNetworking::toggleTethering);
main_layout->addWidget(horizontal_line(), 0); main_layout->addWidget(horizontal_line(), 0);
@ -155,11 +155,13 @@ AdvancedNetworking::AdvancedNetworking(QWidget* parent, WifiManager* wifi): QWid
void AdvancedNetworking::refresh() { void AdvancedNetworking::refresh() {
ipLabel->setText(wifi->ipv4_address); ipLabel->setText(wifi->ipv4_address);
tetheringToggle->setEnabled(true);
update(); update();
} }
void AdvancedNetworking::toggleTethering(bool enabled) { void AdvancedNetworking::toggleTethering(bool enabled) {
wifi->setTetheringEnabled(enabled); wifi->setTetheringEnabled(enabled);
tetheringToggle->setEnabled(false);
} }
// WifiUI functions // WifiUI functions

@ -38,6 +38,7 @@ public:
private: private:
LabelControl* ipLabel; LabelControl* ipLabel;
ToggleControl* tetheringToggle;
WifiManager* wifi = nullptr; WifiManager* wifi = nullptr;
signals: signals:

Loading…
Cancel
Save