Honda - Don't send cancel cmd when using comma pedal (#20922)

* cancel is never true if cruise isn't enabled and pedal

* This is probably better

* comment

* want to see if this fails

* see what Actions says about this

* nice! just as a sanity test real quick

* Revert "nice! just as a sanity test real quick"

This reverts commit 2d86d1c32e.

* Revert "see what Actions says about this"

This reverts commit c908488854.

* Revert "want to see if this fails"

This reverts commit 2d515f3721.

* specify the fix

* No bitwise

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 483678adb1
commatwo_master
ShaneSmiskol 4 years ago committed by GitHub
parent b822c0447a
commit e4ad4a8e13
  1. 4
      selfdrive/car/honda/carcontroller.py

@ -101,6 +101,10 @@ class CarController():
# send pcm acc cancel cmd if drive is disabled but pcm is still on, or if the system can't be activated
pcm_cancel_cmd = True
# Never send cancel command if we never enter cruise state (no cruise if pedal)
# Cancel cmd causes brakes to release at a standstill causing grinding
pcm_cancel_cmd = pcm_cancel_cmd and CS.CP.enableCruise
# *** rate limit after the enable check ***
self.brake_last = rate_limit(brake, self.brake_last, -2., DT_CTRL)

Loading…
Cancel
Save