Ford: align car groups with convention

no plural
pull/29015/head
Cameron Clough 2 years ago
parent c01ba907c0
commit e7c858d590
No known key found for this signature in database
GPG Key ID: BFB3B74B026ED43F
  1. 4
      selfdrive/car/ford/carcontroller.py
  2. 12
      selfdrive/car/ford/carstate.py
  3. 4
      selfdrive/car/ford/interface.py
  4. 2
      selfdrive/car/ford/values.py

@ -4,7 +4,7 @@ from opendbc.can.packer import CANPacker
from selfdrive.car import apply_std_steer_angle_limits from selfdrive.car import apply_std_steer_angle_limits
from selfdrive.car.ford.fordcan import CanBus, create_acc_msg, create_acc_ui_msg, create_button_msg, \ from selfdrive.car.ford.fordcan import CanBus, create_acc_msg, create_acc_ui_msg, create_button_msg, \
create_lat_ctl_msg, create_lat_ctl2_msg, create_lka_msg, create_lkas_ui_msg create_lat_ctl_msg, create_lat_ctl2_msg, create_lka_msg, create_lkas_ui_msg
from selfdrive.car.ford.values import CANFD_CARS, CarControllerParams from selfdrive.car.ford.values import CANFD_CAR, CarControllerParams
LongCtrlState = car.CarControl.Actuators.LongControlState LongCtrlState = car.CarControl.Actuators.LongControlState
VisualAlert = car.CarControl.HUDControl.VisualAlert VisualAlert = car.CarControl.HUDControl.VisualAlert
@ -69,7 +69,7 @@ class CarController:
self.apply_curvature_last = apply_curvature self.apply_curvature_last = apply_curvature
if self.CP.carFingerprint in CANFD_CARS: if self.CP.carFingerprint in CANFD_CAR:
# TODO: extended mode # TODO: extended mode
mode = 1 if CC.latActive else 0 mode = 1 if CC.latActive else 0
counter = (self.frame // CarControllerParams.STEER_STEP) % 0xF counter = (self.frame // CarControllerParams.STEER_STEP) % 0xF

@ -4,7 +4,7 @@ from opendbc.can.can_define import CANDefine
from opendbc.can.parser import CANParser from opendbc.can.parser import CANParser
from selfdrive.car.interfaces import CarStateBase from selfdrive.car.interfaces import CarStateBase
from selfdrive.car.ford.fordcan import CanBus from selfdrive.car.ford.fordcan import CanBus
from selfdrive.car.ford.values import CANFD_CARS, CarControllerParams, DBC from selfdrive.car.ford.values import CANFD_CAR, CarControllerParams, DBC
GearShifter = car.CarState.GearShifter GearShifter = car.CarState.GearShifter
TransmissionType = car.CarParams.TransmissionType TransmissionType = car.CarParams.TransmissionType
@ -55,7 +55,7 @@ class CarState(CarStateBase):
ret.steerFaultPermanent = cp.vl["EPAS_INFO"]["EPAS_Failure"] in (2, 3) ret.steerFaultPermanent = cp.vl["EPAS_INFO"]["EPAS_Failure"] in (2, 3)
# ret.espDisabled = False # TODO: find traction control signal # ret.espDisabled = False # TODO: find traction control signal
if self.CP.carFingerprint in CANFD_CARS: if self.CP.carFingerprint in CANFD_CAR:
# this signal is always 0 on non-CAN FD cars # this signal is always 0 on non-CAN FD cars
ret.steerFaultTemporary |= cp.vl["Lane_Assist_Data3_FD1"]["LatCtlSte_D_Stat"] not in (1, 2, 3) ret.steerFaultTemporary |= cp.vl["Lane_Assist_Data3_FD1"]["LatCtlSte_D_Stat"] not in (1, 2, 3)
@ -97,7 +97,7 @@ class CarState(CarStateBase):
# blindspot sensors # blindspot sensors
if self.CP.enableBsm: if self.CP.enableBsm:
cp_bsm = cp_cam if self.CP.carFingerprint in CANFD_CARS else cp cp_bsm = cp_cam if self.CP.carFingerprint in CANFD_CAR else cp
ret.leftBlindspot = cp_bsm.vl["Side_Detect_L_Stat"]["SodDetctLeft_D_Stat"] != 0 ret.leftBlindspot = cp_bsm.vl["Side_Detect_L_Stat"]["SodDetctLeft_D_Stat"] != 0
ret.rightBlindspot = cp_bsm.vl["Side_Detect_R_Stat"]["SodDetctRight_D_Stat"] != 0 ret.rightBlindspot = cp_bsm.vl["Side_Detect_R_Stat"]["SodDetctRight_D_Stat"] != 0
@ -191,7 +191,7 @@ class CarState(CarStateBase):
("RCMStatusMessage2_FD1", 10), ("RCMStatusMessage2_FD1", 10),
] ]
if CP.carFingerprint in CANFD_CARS: if CP.carFingerprint in CANFD_CAR:
signals += [ signals += [
("LatCtlSte_D_Stat", "Lane_Assist_Data3_FD1"), # PSCM lateral control status ("LatCtlSte_D_Stat", "Lane_Assist_Data3_FD1"), # PSCM lateral control status
] ]
@ -216,7 +216,7 @@ class CarState(CarStateBase):
("BCM_Lamp_Stat_FD1", 1), ("BCM_Lamp_Stat_FD1", 1),
] ]
if CP.enableBsm and CP.carFingerprint not in CANFD_CARS: if CP.enableBsm and CP.carFingerprint not in CANFD_CAR:
signals += [ signals += [
("SodDetctLeft_D_Stat", "Side_Detect_L_Stat"), # Blindspot sensor, left ("SodDetctLeft_D_Stat", "Side_Detect_L_Stat"), # Blindspot sensor, left
("SodDetctRight_D_Stat", "Side_Detect_R_Stat"), # Blindspot sensor, right ("SodDetctRight_D_Stat", "Side_Detect_R_Stat"), # Blindspot sensor, right
@ -286,7 +286,7 @@ class CarState(CarStateBase):
("IPMA_Data", 1), ("IPMA_Data", 1),
] ]
if CP.enableBsm and CP.carFingerprint in CANFD_CARS: if CP.enableBsm and CP.carFingerprint in CANFD_CAR:
signals += [ signals += [
("SodDetctLeft_D_Stat", "Side_Detect_L_Stat"), # Blindspot sensor, left ("SodDetctLeft_D_Stat", "Side_Detect_L_Stat"), # Blindspot sensor, left
("SodDetctRight_D_Stat", "Side_Detect_R_Stat"), # Blindspot sensor, right ("SodDetctRight_D_Stat", "Side_Detect_R_Stat"), # Blindspot sensor, right

@ -4,7 +4,7 @@ from panda import Panda
from common.conversions import Conversions as CV from common.conversions import Conversions as CV
from selfdrive.car import STD_CARGO_KG, get_safety_config from selfdrive.car import STD_CARGO_KG, get_safety_config
from selfdrive.car.ford.fordcan import CanBus from selfdrive.car.ford.fordcan import CanBus
from selfdrive.car.ford.values import CANFD_CARS, CAR, Ecu from selfdrive.car.ford.values import CANFD_CAR, CAR, Ecu
from selfdrive.car.interfaces import CarInterfaceBase from selfdrive.car.interfaces import CarInterfaceBase
TransmissionType = car.CarParams.TransmissionType TransmissionType = car.CarParams.TransmissionType
@ -33,7 +33,7 @@ class CarInterface(CarInterfaceBase):
ret.safetyConfigs[-1].safetyParam |= Panda.FLAG_FORD_LONG_CONTROL ret.safetyConfigs[-1].safetyParam |= Panda.FLAG_FORD_LONG_CONTROL
ret.openpilotLongitudinalControl = True ret.openpilotLongitudinalControl = True
if candidate in CANFD_CARS: if candidate in CANFD_CAR:
ret.safetyConfigs[-1].safetyParam |= Panda.FLAG_FORD_CANFD ret.safetyConfigs[-1].safetyParam |= Panda.FLAG_FORD_CANFD
if candidate == CAR.BRONCO_SPORT_MK1: if candidate == CAR.BRONCO_SPORT_MK1:

@ -49,7 +49,7 @@ class CAR:
MAVERICK_MK1 = "FORD MAVERICK 1ST GEN" MAVERICK_MK1 = "FORD MAVERICK 1ST GEN"
CANFD_CARS = {CAR.F_150_MK14} CANFD_CAR = {CAR.F_150_MK14}
class RADAR: class RADAR:

Loading…
Cancel
Save