From e86ef27659065595b3a728201e293dc157ebcf2d Mon Sep 17 00:00:00 2001 From: dekerr Date: Mon, 28 Oct 2019 18:16:37 -0400 Subject: [PATCH] remove unnecessary comprehensions (#863) old-commit-hash: 2a77b02bd8e0a3ea501fb372e435441b7e7ba211 --- selfdrive/can/can_define.py | 2 +- selfdrive/can/plant_can_parser.py | 2 +- selfdrive/can/process_dbc.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/selfdrive/can/can_define.py b/selfdrive/can/can_define.py index d6ffc5c669..eb708869f0 100644 --- a/selfdrive/can/can_define.py +++ b/selfdrive/can/can_define.py @@ -35,5 +35,5 @@ class CANDefine(): self.dv[msgname] = {} # two ways to lookup: address or msg name - self.dv[address][sgname] = {v: d for v, d in zip(values, defs)} #build dict + self.dv[address][sgname] = dict(zip(values, defs)) self.dv[msgname][sgname] = self.dv[address][sgname] diff --git a/selfdrive/can/plant_can_parser.py b/selfdrive/can/plant_can_parser.py index 65fcfc6415..37ea335374 100644 --- a/selfdrive/can/plant_can_parser.py +++ b/selfdrive/can/plant_can_parser.py @@ -21,7 +21,7 @@ class CANParser(): # - frequency is the frequency at which health should be monitored. checks = [] if checks is None else checks - self.msgs_ck = set([check[0] for check in checks]) + self.msgs_ck = {check[0] for check in checks} self.frqs = dict(checks) self.can_valid = False # start with False CAN assumption # list of received msg we want to monitor counter and checksum for diff --git a/selfdrive/can/process_dbc.py b/selfdrive/can/process_dbc.py index 4b8c55d448..6da527f785 100755 --- a/selfdrive/can/process_dbc.py +++ b/selfdrive/can/process_dbc.py @@ -42,7 +42,7 @@ def main(): for address, ((msg_name, msg_size), msg_sigs) in sorted(can_dbc.msgs.items()) if msg_sigs] def_vals = {a: set(b) for a,b in can_dbc.def_vals.items()} #remove duplicates - def_vals = [(address, sig) for address, sig in sorted(def_vals.items())] + def_vals = sorted(def_vals.items()) if can_dbc.name.startswith(("honda_", "acura_")): checksum_type = "honda"