From eb695a00c2acf887af9def79340e2efa4fe48395 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Fri, 11 Aug 2023 18:26:08 +0800 Subject: [PATCH] ui/map: check NavDestination only if navInstruction is invalid (#29331) * check NavDestination only if navInstruction is invalid * Update selfdrive/ui/qt/maps/map.cc Co-authored-by: Shane Smiskol --------- Co-authored-by: Shane Smiskol old-commit-hash: 80356b34f1c189bee4287c0b70c3e6a18e105cc3 --- selfdrive/ui/qt/maps/map.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/selfdrive/ui/qt/maps/map.cc b/selfdrive/ui/qt/maps/map.cc index ff0f1f4daf..6e0053b13f 100644 --- a/selfdrive/ui/qt/maps/map.cc +++ b/selfdrive/ui/qt/maps/map.cc @@ -213,8 +213,7 @@ void MapWindow::updateState(const UIState &s) { // - API exception/no internet // - route response is empty // - any time navd is waiting for recompute_countdown - auto dest = coordinate_from_param("NavDestination"); - routing_problem = !sm.valid("navInstruction") && dest.has_value(); + routing_problem = !sm.valid("navInstruction") && coordinate_from_param("NavDestination").has_value(); if (sm.valid("navInstruction")) { auto i = sm["navInstruction"].getNavInstruction();