just check isinstance

pull/28212/head
Shane Smiskol 2 years ago
parent 0af66436d1
commit ec14a75f32
  1. 1
      selfdrive/car/docs_definitions.py
  2. 4
      selfdrive/car/tests/test_docs.py

@ -70,7 +70,6 @@ class HarnessConnector(CarPart):
mazda_connector = "Mazda connector"
ford_q3_connector = "Ford Q3 connector"
ford_q4_connector = "Ford Q4 connector"
none_connector = "None connector"
class HarnessAccessory(CarPart):

@ -75,8 +75,8 @@ class TestCarDocs(unittest.TestCase):
raise unittest.SkipTest
self.assertTrue(len(car.car_parts.parts) > 0, f"Need to specify car parts: {car.name}")
self.assertTrue(len(list(filter(lambda p: p.__class__ is HarnessConnector and p is not HarnessConnector.none_connector, car.car_parts.parts))) > 0, f"Need to specify an harness connector: {car.name}")
self.assertTrue(len(list(filter(lambda p: p.__class__ is Mount, car.car_parts.parts))) > 0, f"Need to specify a mount: {car.name}")
self.assertTrue(any([isinstance(p, HarnessConnector) for p in car.car_parts.parts]), f"Need to specify a harness connector: {car.name}")
self.assertTrue(any([isinstance(p, Mount) for p in car.car_parts.parts]), f"Need to specify a mount: {car.name}")
if __name__ == "__main__":

Loading…
Cancel
Save