From ec14a75f32b1c168845428dcc2e56cb0c1418d83 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 18 May 2023 19:48:30 -0700 Subject: [PATCH] just check isinstance --- selfdrive/car/docs_definitions.py | 1 - selfdrive/car/tests/test_docs.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/selfdrive/car/docs_definitions.py b/selfdrive/car/docs_definitions.py index 0933b784ee..d7b9953b27 100644 --- a/selfdrive/car/docs_definitions.py +++ b/selfdrive/car/docs_definitions.py @@ -70,7 +70,6 @@ class HarnessConnector(CarPart): mazda_connector = "Mazda connector" ford_q3_connector = "Ford Q3 connector" ford_q4_connector = "Ford Q4 connector" - none_connector = "None connector" class HarnessAccessory(CarPart): diff --git a/selfdrive/car/tests/test_docs.py b/selfdrive/car/tests/test_docs.py index 548ee77fde..1912693bfb 100755 --- a/selfdrive/car/tests/test_docs.py +++ b/selfdrive/car/tests/test_docs.py @@ -75,8 +75,8 @@ class TestCarDocs(unittest.TestCase): raise unittest.SkipTest self.assertTrue(len(car.car_parts.parts) > 0, f"Need to specify car parts: {car.name}") - self.assertTrue(len(list(filter(lambda p: p.__class__ is HarnessConnector and p is not HarnessConnector.none_connector, car.car_parts.parts))) > 0, f"Need to specify an harness connector: {car.name}") - self.assertTrue(len(list(filter(lambda p: p.__class__ is Mount, car.car_parts.parts))) > 0, f"Need to specify a mount: {car.name}") + self.assertTrue(any([isinstance(p, HarnessConnector) for p in car.car_parts.parts]), f"Need to specify a harness connector: {car.name}") + self.assertTrue(any([isinstance(p, Mount) for p in car.car_parts.parts]), f"Need to specify a mount: {car.name}") if __name__ == "__main__":