From eca32bd16dda8d21e104b66cbfc3a57b411793c8 Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Mon, 13 Feb 2023 21:39:06 -0800
Subject: [PATCH] process replay: don't upload if diff doesn't exist (#27333)

* fail the replay, successfully print

* should still run

* debug

* outside?

* don't fail

* don't fail

* don't fail

* test

* test

* test

* try this now

* clean up, works!
old-commit-hash: b536b9c4c07742a035723c3a0e1aeb646db6555a
---
 .github/workflows/selfdrive_tests.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml
index 834b2141d0..efddde720d 100644
--- a/.github/workflows/selfdrive_tests.yaml
+++ b/.github/workflows/selfdrive_tests.yaml
@@ -250,6 +250,7 @@ jobs:
         ${{ env.RUN }} "CI=1 coverage run selfdrive/test/process_replay/test_processes.py -j$(nproc) && \
                         coverage xml"
     - name: Print diff
+      id: print-diff
       if: always()
       run: cat selfdrive/test/process_replay/diff.txt
     - uses: actions/upload-artifact@v2
@@ -259,7 +260,7 @@ jobs:
         name: process_replay_diff.txt
         path: selfdrive/test/process_replay/diff.txt
     - name: Upload reference logs
-      if: ${{ failure() && github.event_name == 'pull_request' && github.repository == 'commaai/openpilot' && env.AZURE_TOKEN != '' }}
+      if: ${{ failure() && steps.print-diff.outcome == 'success' && github.event_name == 'pull_request' && github.repository == 'commaai/openpilot' && env.AZURE_TOKEN != '' }}
       run: |
         ${{ env.RUN }} "CI=1 AZURE_TOKEN='$AZURE_TOKEN' python selfdrive/test/process_replay/test_processes.py -j$(nproc) --upload-only"
     - name: "Upload coverage to Codecov"