From ed31f8aaa5dcacbd9a906534a77afcc1fae00b0d Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Tue, 25 Aug 2020 00:25:16 +0800 Subject: [PATCH] Remove unnecessary string copy (#2067) old-commit-hash: 71eedbce44b9239d05c3309a6f85c3c8abbb3908 --- selfdrive/common/swaglog.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/selfdrive/common/swaglog.cc b/selfdrive/common/swaglog.cc index 41b6358d98..9d90347547 100644 --- a/selfdrive/common/swaglog.cc +++ b/selfdrive/common/swaglog.cc @@ -93,15 +93,13 @@ void cloudlog_e(int levelnum, const char* filename, int lineno, const char* func {"created", seconds_since_epoch()} }; - char* log_s = strdup(log_j.dump().c_str()); - assert(log_s); + std::string log_s = log_j.dump(); free(msg_buf); char levelnum_c = levelnum; zmq_send(s.sock, &levelnum_c, 1, ZMQ_NOBLOCK | ZMQ_SNDMORE); - zmq_send(s.sock, log_s, strlen(log_s), ZMQ_NOBLOCK); - free(log_s); + zmq_send(s.sock, log_s.c_str(), log_s.length(), ZMQ_NOBLOCK); pthread_mutex_unlock(&s.lock); }