params: update `AthenadPid` to use integer type (#35871)

* params: update `AthenadPid` to use integer type

* fix type

common/params_keys.h

@@ -12,7 +12,7 @@ inline static std::unordered_map<std::string, ParamKeyAttributes> keys = {
     {"ApiCache_Device", {PERSISTENT, STRING}},
     {"ApiCache_FirehoseStats", {PERSISTENT, JSON}},
     {"AssistNowToken", {PERSISTENT, STRING}},
-    {"AthenadPid", {PERSISTENT, STRING}},
+    {"AthenadPid", {PERSISTENT, INT}},
     {"AthenadUploadQueue", {PERSISTENT, JSON}},
     {"AthenadRecentlyViewedRoutes", {PERSISTENT, STRING}},
     {"BootCount", {PERSISTENT, INT}},

common/tests/test_params.py

@@ -37,9 +37,9 @@ class TestParams:
 
   def test_params_two_things(self):
     self.params.put("DongleId", "bob")
-    self.params.put("AthenadPid", "123")
+    self.params.put("AthenadPid", 123)
     assert self.params.get("DongleId") == "bob"
-    assert self.params.get("AthenadPid") == "123"
+    assert self.params.get("AthenadPid") == 123
 
   def test_params_get_block(self):
     def _delayed_writer():

system/manager/process.py

@@ -270,7 +270,7 @@ class DaemonProcess(ManagerProcess):
                                stderr=open('/dev/null', 'w'),
                                preexec_fn=os.setpgrp)
 
-    self.params.put(self.param_name, str(proc.pid))
+    self.params.put(self.param_name, proc.pid)
 
   def stop(self, retry=True, block=True, sig=None) -> None:
     pass