updated: fix surfacing exceptions and errors (#20754)

* updated: fix surfacing exceptions and errors

* can't rely on that

* unused

* ugh pylint

* try this

* this makes pylint happy

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 3c9e46d8a2

selfdrive/updated.py

@@ -281,12 +281,17 @@ def check_git_fetch_result(fetch_txt):
 
 def check_for_update() -> Tuple[bool, bool]:
   setup_git_options(OVERLAY_MERGED)
+  fetch_output = None
   try:
-    git_fetch_output = run(["git", "fetch", "--dry-run"], OVERLAY_MERGED, low_priority=True)
+    fetch_output = run(["git", "fetch", "--dry-run"], OVERLAY_MERGED, low_priority=True)
-    return True, check_git_fetch_result(git_fetch_output)
+    return True, check_git_fetch_result(fetch_output)
   except subprocess.CalledProcessError:
+    # check for internet
+    if fetch_output is not None and fetch_output.startswith("fatal: unable to access") and \
+       "Could not resolve host:" in str(fetch_output):
       return False, False
 
+    raise
 
 def fetch_update(wait_helper: WaitTimeHelper) -> bool:
   cloudlog.info("attempting git fetch inside staging overlay")