soundd: use with statement for wave.open to ensure proper resource cleanup (#34815)

use with statement for wave.open to ensure proper resource cleanup
2 months ago · fa79b29cba
parent 3e629acf79
commit fa79b29cba
1 changed files with 6 additions and 7 deletions
--- a/selfdrive/ui/soundd.py
+++ b/selfdrive/ui/soundd.py
@ -69,8 +69,7 @@ class Soundd:
    for sound in sound_list:
      filename, play_count, volume = sound_list[sound]

-      wavefile = wave.open(BASEDIR + "/selfdrive/assets/sounds/" + filename, 'r')
-
+      with wave.open(BASEDIR + "/selfdrive/assets/sounds/" + filename, 'r') as wavefile:
        assert wavefile.getnchannels() == 1
        assert wavefile.getsampwidth() == 2
        assert wavefile.getframerate() == SAMPLE_RATE