always cleanup curl and close file

4 years ago · fbd8c33160
parent 7c3c835ac7
commit fbd8c33160
1 changed files with 4 additions and 4 deletions
--- a/selfdrive/ui/qt/setup/setup.cc
+++ b/selfdrive/ui/qt/setup/setup.cc
@ -41,13 +41,13 @@ void Setup::download(QString url) {
  curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &res_status);
  if (ret != CURLE_OK || res_status != 200) {
    emit finished(false);
-    return;
+  } else {
+    rename(tmpfile, "/tmp/installer");
+    emit finished(true);
  }
+
  curl_easy_cleanup(curl);
  fclose(fp);
-
-  rename(tmpfile, "/tmp/installer");
-  emit finished(true);
 }

 QWidget * Setup::low_voltage() {