From fcc268b8be70e72654252e5424840ca37ad04196 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Tue, 13 Jun 2023 20:00:54 -0700 Subject: [PATCH] exact matching: use set for invalid (#28537) use set --- selfdrive/car/fw_versions.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/selfdrive/car/fw_versions.py b/selfdrive/car/fw_versions.py index bfb65f7a12..ce7aeb3a1e 100755 --- a/selfdrive/car/fw_versions.py +++ b/selfdrive/car/fw_versions.py @@ -106,7 +106,7 @@ def match_fw_to_car_exact(fw_versions_dict, log=True) -> Set[str]: FW versions for a list of "essential" ECUs. If an ECU is not considered essential the FW version can be missing to get a fingerprint, but if it's present it needs to match the database.""" - invalid = [] + invalid = set() candidates = FW_VERSIONS for candidate, fws in candidates.items(): @@ -130,10 +130,10 @@ def match_fw_to_car_exact(fw_versions_dict, log=True) -> Set[str]: continue if not any([found_version in expected_versions for found_version in found_versions]): - invalid.append(candidate) + invalid.add(candidate) break - return set(candidates.keys()) - set(invalid) + return set(candidates.keys()) - invalid def match_fw_to_car(fw_versions, allow_exact=True, allow_fuzzy=True, log=True):