ui/controls.cc: fix QLabel leak (#30382

An error occurred

)

fix QLabel leak old-commit-hash: 17cab9bb50
2 years ago · fe554ceee3
parent 8aac0bdfff
commit fe554ceee3
1 changed files with 3 additions and 2 deletions
--- a/selfdrive/ui/qt/widgets/controls.cc
+++ b/selfdrive/ui/qt/widgets/controls.cc
@ -12,13 +12,14 @@ AbstractControl::AbstractControl(const QString &title, const QString &desc, cons
  hlayout->setSpacing(20);

  // left icon
-  icon_label = new QLabel();
+  icon_label = new QLabel(this);
+  hlayout->addWidget(icon_label);
  if (!icon.isEmpty()) {
    icon_pixmap = QPixmap(icon).scaledToWidth(80, Qt::SmoothTransformation);
    icon_label->setPixmap(icon_pixmap);
    icon_label->setSizePolicy(QSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed));
-    hlayout->addWidget(icon_label);
  }
+  icon_label->setVisible(!icon.isEmpty());

  // title
  title_label = new QPushButton(title);