sadmen
/
openpilot_comma
mirror of https://github.com/commaai/openpilot.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix LGTM issues (#19868)

Browse Source 
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: efe8c54a2e
commatwo_master
grekiki 4 years ago committed by GitHub
parent 52e1efffd5
commit ff0c87d63c
1 changed files with 5 additions and 5 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 10
      selfdrive/ui/qt/widgets/QrCode.cc

10
selfdrive/ui/qt/widgets/QrCode.cc
Unescape View File

@ -349,7 +349,7 @@ QrCode::QrCode(int ver, Ecc ecl, const vector<uint8_t> &dataCodewords, int msk)
applyMask(i); // Undoes the mask due to XOR applyMask(i); // Undoes the mask due to XOR
} }
} }
if (msk < 0 || msk > 7) if (msk < 0 || msk > 7)//lgtm [cpp/constant-comparison]
throw std::logic_error("Assertion error"); throw std::logic_error("Assertion error");
this->mask = msk; this->mask = msk;
applyMask(msk); // Apply the final choice of mask applyMask(msk); // Apply the final choice of mask
@ -635,12 +635,12 @@ long QrCode::getPenaltyScore() const {
} else { } else {
finderPenaltyAddHistory(runX, runHistory); finderPenaltyAddHistory(runX, runHistory);
if (!runColor) if (!runColor)
result += finderPenaltyCountPatterns(runHistory) * PENALTY_N3; result += finderPenaltyCountPatterns(runHistory) * PENALTY_N3;//lgtm [cpp/integer-multiplication-cast-to-long]
runColor = module(x, y); runColor = module(x, y);
runX = 1; runX = 1;
} }
} }
result += finderPenaltyTerminateAndCount(runColor, runX, runHistory) * PENALTY_N3; result += finderPenaltyTerminateAndCount(runColor, runX, runHistory) * PENALTY_N3;//lgtm [cpp/integer-multiplication-cast-to-long]
} }
// Adjacent modules in column having same color, and finder-like patterns // Adjacent modules in column having same color, and finder-like patterns
for (int x = 0; x < size; x++) { for (int x = 0; x < size; x++) {
@ -657,12 +657,12 @@ long QrCode::getPenaltyScore() const {
} else { } else {
finderPenaltyAddHistory(runY, runHistory); finderPenaltyAddHistory(runY, runHistory);
if (!runColor) if (!runColor)
result += finderPenaltyCountPatterns(runHistory) * PENALTY_N3; result += finderPenaltyCountPatterns(runHistory) * PENALTY_N3;//lgtm [cpp/integer-multiplication-cast-to-long]
runColor = module(x, y); runColor = module(x, y);
runY = 1; runY = 1;
} }
} }
result += finderPenaltyTerminateAndCount(runColor, runY, runHistory) * PENALTY_N3; result += finderPenaltyTerminateAndCount(runColor, runY, runHistory) * PENALTY_N3;//lgtm [cpp/integer-multiplication-cast-to-long]
} }
// 2*2 blocks of modules having same color // 2*2 blocks of modules having same color

Write Preview
Loading…
Cancel
Save