From ff94bdb79d5d7a8939fe55dd110472fad4fabd03 Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Wed, 19 Jul 2023 19:28:44 +0800
Subject: [PATCH] ui/networking: call isTetheringEnabled out of the loop
 (#29028)

old-commit-hash: 4584e883dcf93079ad958da2042229750a3e260d
---
 selfdrive/ui/qt/offroad/networking.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/selfdrive/ui/qt/offroad/networking.cc b/selfdrive/ui/qt/offroad/networking.cc
index cf14e5cb91..c146345eb4 100644
--- a/selfdrive/ui/qt/offroad/networking.cc
+++ b/selfdrive/ui/qt/offroad/networking.cc
@@ -286,6 +286,7 @@ void WifiUI::refresh() {
   scanningLabel->setVisible(is_empty);
   if (is_empty) return;
 
+  const bool is_tethering_enabled = wifi->isTetheringEnabled();
   QList<Network> sortedNetworks = wifi->seenNetworks.values();
   std::sort(sortedNetworks.begin(), sortedNetworks.end(), compare_by_strength);
 
@@ -313,7 +314,7 @@ void WifiUI::refresh() {
     }
 
     // Forget button
-    if (wifi->isKnownConnection(network.ssid) && !wifi->isTetheringEnabled()) {
+    if (wifi->isKnownConnection(network.ssid) && !is_tethering_enabled) {
       QPushButton *forgetBtn = new QPushButton(tr("FORGET"));
       forgetBtn->setObjectName("forgetBtn");
       QObject::connect(forgetBtn, &QPushButton::clicked, [=]() {