Dean Lee
004a097c95
cpplint: add `readability/braces` filter ( #29554 )
...
old-commit-hash: 363740a497
2 years ago
Dean Lee
11b5cfa422
ui/settings: Don't apply styles to more elements than needed. ( #29463 )
...
old-commit-hash: 5765c1d978
2 years ago
Adeeb Shihadeh
701cd6f6fe
add cpplint ( #26855 )
...
* setup cpplint
* only start that
* check line length
* check these
* rm exceptions
old-commit-hash: 952d720b6e
2 years ago
Adeeb Shihadeh
16ec56398c
add openpilot prefix to imports ( #29498 )
...
* add openpilot prefix to imports
* more
* more
* fix docs
* fix linter
* bump submodules
* fix patched tests
* update dynamic imports
* debug
* Revert "debug"
This reverts commit db5e13b991
.
* fix pm test
old-commit-hash: a9626f95b6
2 years ago
Dean Lee
ff74c8c4cb
ui/map_instructions: center lanes ( #29465 )
...
* center lanes
* test
* similar spacing and no need for stretchj
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9ea2cd8d0b
2 years ago
pencilpusher
fc14939f02
ui/map: interactive counter fix ( #29470 )
...
* use interactive_counter instead of separate zoom and pan counters
* use interaction_counter instead of separate zoom and pan counters
* same styling
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f2d22075eb
2 years ago
Dean Lee
3078da290d
ui/map: better rounding for distances ( #29151 )
...
* round distance
* use same format in ETA
* remove vanish
* restore translate
* use nearbyint
* update translations
* mark finished
* consistent style
* we don't include this anywhere in ui, needed?
* fix missing std
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: efefcfdca5
2 years ago
Shane Smiskol
709850e304
map eta: use pair ( #29460 )
...
use pair
old-commit-hash: d827cd6a83
2 years ago
Shane Smiskol
593322dfa9
ui/map: slight turn lane types ( #29446 )
...
* add slight turns
* bump cereal
* revert
* hmm, i like this better
* whops
* fix
* bump
old-commit-hash: 6d2922b8e6
2 years ago
Dean Lee
023cd0492f
ui/networking: do not skip the connected network ( #29396 )
...
* do not skip connected network
* simplify
* revert
* revert
* no implicit
* ifwt
* fix missing ssid
* makes more sense to only update security_type once (first vs. last)
* better comment
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: b8b1e17a21
2 years ago
Dean Lee
4857b61f8f
ui/networking: pass network by value ( #29448 )
...
old-commit-hash: 1887d9197a
2 years ago
Dean Lee
a50a9ef9b4
ui/map: hide icon if no maneuver type ( #29084 )
...
hide icon if no maneuver type
old-commit-hash: 202b2f2113
2 years ago
Dean Lee
f667936f3a
ui/map: show map on destination set/change ( #29327 )
...
* show map on dest set/change
* check for rcv_frame
* clear current_nav_dest
* restore allow_open
* use requestShow
* cleanup
* one check
* revert behavior changes
* Update selfdrive/ui/qt/maps/map.cc
* more obvious
* Update selfdrive/ui/qt/maps/map.cc
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3a277f1b81
2 years ago
Shane Smiskol
312d80c877
map: set destination marker visibility once ( #29444 )
...
set visibility once
old-commit-hash: da38aed483
2 years ago
Dean Lee
5cc9fbe23f
ui: longer screen timeout for driver view ( #27457 )
...
* longer driverview timeout
* Update ui.cc
* reset timeout
* do cleanup
* Apply suggestions from code review
* Update selfdrive/ui/ui.cc
* reset to default timeout on hidden
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f1568b960a
2 years ago
Dean Lee
e0439a516f
ui/map: assign the return value to `last_position` ( #29341 )
...
assign the return value directly to last_position
old-commit-hash: 613bbb7e6d
2 years ago
Dean Lee
ec3b69928a
ui/networking: bolding the connected network ( #29385 )
...
old-commit-hash: 29f2389cce
2 years ago
Dean Lee
87c4c661c7
ui/map_instructions: set margin-top to UI_BORDER_SIZE ( #29387 )
...
old-commit-hash: 9071c8a4fc
2 years ago
Dean Lee
25df6335f7
UI: make wifi network sorting more stable ( #29376 )
...
* stable sort
* fix typo,rename to strengthLevel
old-commit-hash: 01089cf4bf
2 years ago
Dean Lee
431797307d
ui/sidebar: break long line for readability ( #29379 )
...
old-commit-hash: 878d3f4cfc
2 years ago
Dean Lee
ce5c95715c
ui/networking: remove dynamic property and style sheet ( #29377 )
...
old-commit-hash: 373171afd0
2 years ago
Dean Lee
42dd6af842
ui/networking: remove call to clearLayout ( #29037 )
...
* build list inplace
* move clearLayout to cabana
* cleanup include
* polish style
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fd8a9c8520
2 years ago
Shane Smiskol
d33545a0b6
ui/map_instructions: round <500 distances ( #29333 )
...
round
old-commit-hash: cc747e2166
2 years ago
Dean Lee
b065f5c9a2
ui/map: fix CSS error ( #29332 )
...
fix css error
old-commit-hash: 4a89928a9a
2 years ago
Shane Smiskol
f8d9860d20
ui/map_instructions: clean up lane icon selection ( #29330 )
...
* draft
* revert
* remove extra directions
* more clean up
* add todo
* revert rename
* I assume this is moot, but preserve behavior
* spacing
old-commit-hash: 52675b2739
2 years ago
Dean Lee
eb695a00c2
ui/map: check NavDestination only if navInstruction is invalid ( #29331 )
...
* check NavDestination only if navInstruction is invalid
* Update selfdrive/ui/qt/maps/map.cc
Co-authored-by: Shane Smiskol <shane@smiskol.com>
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 80356b34f1
2 years ago
Dean Lee
a494b38f6e
ui/map: set WA_NoMousePropagation to prevent mouse event from propagating up ( #29329 )
...
set WA_NoMousePropagation
old-commit-hash: 15bb9dd096
2 years ago
Jason Wen
55f7f723a0
ui onroad: utilize local variables for repeated capnp reader access ( #29325 )
...
old-commit-hash: 22cf5421d6
2 years ago
Dean Lee
c8c2c5f801
ui/onroad: move duplicated code to `drawIcon()` ( #29149 )
...
* move duplicate code to function drawIcon
* fix center point
old-commit-hash: cef693f309
2 years ago
eFini
e90ced8449
map ui: Fixed ETA text alignment issue in CJK ( #29311 )
...
fixed ETA text alignment issue in CJK
old-commit-hash: 8d7e909b53
2 years ago
Cameron Clough
6ed5aca05a
ui/map: update mapbox style ( #29186 )
...
old-commit-hash: 748238f87c
2 years ago
Shane Smiskol
7b1fa23144
map: fix exit lane direction when active ( #29159 )
...
* fix
* clean up
* comment
old-commit-hash: cffc14e4d8
2 years ago
Dean Lee
823b570082
ui/OnroadWindow: do not update state when offroad ( #29134 )
...
do not updateState when offroad
old-commit-hash: da91555056
2 years ago
Shane Smiskol
fdc00cf0b6
Experimental mode toggle description: missing spaces ( #29167 )
...
* Update settings.cc
* more missing spaces
* scons
* vanish
* fix that
old-commit-hash: 6fe480b232
2 years ago
Adeeb Shihadeh
178d9adec3
ui: less confusing wifi training ( #29137 )
...
* ui: less confusing wifi training
* update
* cleanup
---------
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 0922a1040f
2 years ago
Harald Schäfer
069e9ef4f8
Experimental mode description: update nav ( #29130 )
...
* Update description
* Update releases
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/ui/qt/offroad/settings.cc
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* small tweaks
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9c3c7f0dda
2 years ago
Shane Smiskol
ec900d0389
navd: don't use empty last step banner instructions ( #29034 )
...
* fix empty banner instructions when arriving at destination
* bug fixes
* hide distance on arrival
* stash
* simpler
* can also do this, but i don't like modifying the response
* clean up
* rm
* revert
* rm
* flip this order
* move up
* need to flip order
* Revert "need to flip order"
This reverts commit ba961b8e6a
.
* Revert "move up"
This reverts commit f1a4d8ae88
.
* Update selfdrive/navd/navd.py
old-commit-hash: 412ed6a017
2 years ago
Shane Smiskol
d4ec764235
ui: new nav settings button ( #29068 )
...
* add image
* remove extra spacing
* add images
* use nav-settings-square-smaller.png
* draft
* clean up
* kinda works!
* nop need to update state
* can just use clicked
* MORE
* remove old button
* slightly smaller (todo change image))
* this works but is ugly
* remove old settings button
* draft
* no it's not
* draft 2.0
* clean up
* clean up
* let's make map_settings_btn public
* since we don't have map, use enabled
* fix image size
* can do clean up in another PR
show
* add line
* rename
* useless spacing
* use old nav icon
* handle DM icon (and test)
* clean up
* no reason
* remove old image
* don't use setCurrentIndex
* Revert "don't use setCurrentIndex"
This reverts commit 6fde765a3c
.
* also can use a ternary
* seems cleanest
This reverts commit f928723070
.
old-commit-hash: 0dd1dcc7d0
2 years ago
Shane Smiskol
6d9a313f19
ui/map: hide settings with showing map ( #29127 )
...
consistent map showing behavior
old-commit-hash: 13dc0325b2
2 years ago
Dean Lee
916784cfbe
ui/settings: use existing params instance ( #29109 )
...
use exsting params
old-commit-hash: bcfb9d6940
2 years ago
Dean Lee
8d2a08723a
ui/map: remove unused variables ( #29098 )
...
old-commit-hash: 980ba1312f
2 years ago
Dean Lee
ee42f316d7
ui/MapSettings: remove function `shorten` ( #29078 )
...
old-commit-hash: cc551fe24b
2 years ago
Shane Smiskol
b8bf3fc0c2
nav: improve no route alert text ( #29076 )
...
* kind of
* Revert "kind of"
This reverts commit 25abbbf176
.
* more generic alert text, whenever we're waiting for navd.
* actual better comment
* update translations
old-commit-hash: d70c4916db
2 years ago
Dean Lee
9865a32252
ui/map: fix ETA widget text spacing ( #29065 )
...
* fix eta spacing
* fix unit color
---------
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 0b8d35b132
2 years ago
Shane Smiskol
a069514c36
ui: set global map transition duration ( #29061 )
...
* this works!
* revert properties
* more clean up
* more
* more
* add comment
* final
old-commit-hash: e4dc86f44d
2 years ago
Dean Lee
7d5d1b1e70
ui/map: move `MapInstructions` & `MapETA` to separate files ( #28976 )
...
old-commit-hash: 942a2f9760
2 years ago
Shane Smiskol
a7b32acd4b
nav: show warning for routing problems ( #29055 )
...
* all my debugging stuff
* this works
* add comment
* bb navd
* navInstruction is valid when we get a non-empty route response
* now don't need this
* stash
* big cleanup
* clean up
* clean up
* debug
* final clean up
* one line
* flip order
* update translations
* is this simpler?
old-commit-hash: 5b368a67ea
2 years ago
Shane Smiskol
3a41e53b08
nav: set icon anchor for destination pin ( #29054 )
...
* anchor!
* whoops
* fix anchor
old-commit-hash: d0ea8be95f
2 years ago
Mitchell Goff
949375984f
nav: draw destination pin on top of navigation path ( #29050 )
...
* Draw destination pin on top of navigation path
* fix draw ordering
fix draw ordering
* add todo
* rename to feature
* draft
* clean up
* testing
* testing 2
* Revert "testing 2"
This reverts commit fc236aafbc
.
* Revert "testing"
This reverts commit 982a508ad7
.
* clean up
* add todo
* show!
* Update selfdrive/ui/qt/maps/map.cc
* lgtm
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: ba03e94290
2 years ago
Dean Lee
ff94bdb79d
ui/networking: call isTetheringEnabled out of the loop ( #29028 )
...
old-commit-hash: 4584e883dc
2 years ago