* rename function first and foremost
* the function
* comment
* move usages over
* probably fine
* comments
* btn
* single line
* not comments
* fix keyword
* is it not clear?
* noEntry while holding cancel
* bumpo
* remove
* better?
* better?
* try this
* try this
* loop
* better
* more clear
* Revert "more clear"
This reverts commit 37e0277e4b.
* no optional
* fine
* add comment
* clean up honda
* one line
* can also do this
* but unclear
This reverts commit 1984a72cc8.
* bumppanda
* HKG: Car Port for Kia Sorento Hybrid 2023
* Update CARS.md
* Oops
* add test route
* specify segment
* all packages
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* radard: tie radard frequency to modelV2
Accumulate parsed messages until state is updated (toyota)
Same for honda
Rename rr to something more descriptive
* Change _update method name, since signature has changed
* Update ref commit
* Some renames
* Check for number of cans
* What if: no signals! 🙅🤌🎆
* do hyundai
* honda!
* do gm
* and vw! (sorry comments)
* do those
* -500
* little more
* fix subie
* change back
* bumpopendbc
* oof lol
* messages
* some clean up
* here too
* clean up honda radar_interface.py
fix
rm
* bump opendbc to master
* add todo
* rename checks in tesla/radar_interface
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* fix subaru fault
* try this!
* wip
* try this
* this more or less worked
* this is all under gen2
* that needs to be up there
* comment
* steer_angle
* test
* wip
* wip
* sync
* wip
* cleanup
* remove print
* use sets and fix unittests
* common fault avoidance
* common fault avoidance
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* revert subaru to get this part merged
* revert name change
* revert name change
* revert name change
* same as before
* add test case
* also verify zero tolerance
* keep the current behavior
* split into multiple tests for easier debugging
* added comments and remove tests
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Comma Device <device@comma.ai>
* cmt
* common parts
* add code and date
* Revert "add code and date"
This reverts commit 47f9ac84ca.
* Revert "common parts"
This reverts commit aa5683bbce.
* add back to santa cruz
* todo
* part number test
* pass test
* Update selfdrive/car/hyundai/tests/test_hyundai.py
* HKG: Car Port for Kia Carnival (China only) 2023 (HDA1)
* add FW
* seems to be radar SCC
* Update CARS.md
* Update CARS.md
* Add test route
* Fix docs
* New route
* Fix docs formatting
* update with US model
* 2 total
* Update RELEASES.md
* add FW for US carnival 2023
* fix docs
* update test routes
* no rlogs for chinese route
* update docs
* revert chinese to merge now
* Apply suggestions from code review
* fine to fully remove
* less precise
* remove from releases
* Apply suggestions from code review
* Update selfdrive/car/tests/routes.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* get gas/ev/hev from FW (not all correct, poc)
* add test for essential ecus for fuzzy fingerprinting
* kinda works
* stash
* clean up
* add code
* simpler
* use the function
* test it with our cars
* no re
no re
no re
* debugging
* handle empty dict
* simpl
* this is promising
start on making existing fingerprinting functions use the config, instead of entirely replacing them
* needs to allow 1 match
* lay out how this should look
* changes
* executable
* some work
* use config
* fuzzy ecus
* config test
* comment and some clean up
* test platform codes
* use regex, simpler and fixes bug
* in func
* rm bad func
* typing for new func and remove old from dc
* todo done
* tested!
* remove fake platform codes
* thought we needed this, but actually...
* not needed
* not applicable any more
* use config for essential ecus
* first draft of test to make adding/removing fuzzy FP platform intentional
* compile
* clean up test
* even cleaner
* fix default ecus type
* temp fix
* this is mostly in tests now
* test every fuzzy ecu fw returns one platform code
* experiment with dates
* Revert "experiment with dates"
This reverts commit 3251b9cc5c.
* clean that up
* comment
* test
* work on all cars
* fix fuzz_fw_fingerprint
* comment
* get first by search
* bit more clean up
* and more
* use compiled pattern for nicer syntax
* default
* flip dat around, much cleaner
* clean up hyundai test a bit
* flip order
same here
* rename test and flip subTest
* fix pylint
* revert fw changes
revert fw changes
* line
* add original functions to test
* needs to be a list
* cmt
* draft (need to count one ecu as a match)
* tiny clean up
* todo: date range
* only in notebook
* remove comment (still can be either list or set)
* same, only notebook
* more consistent signature
* copilot inspired
* copilot no good
* test for date parsing
* better name
* good, now we don't have to worry about the dates mismatching in another test/logic
* comment up+
* some stuff
* clean up
fix test
fix test
* test
* comment
* use utils
* clean up (utils are cleaner and less buggy)
* clean up (utils are cleaner and less buggy)
* fixup test
* use a dash (prettier) and remove some platforms that can fingerprint now!
* compile global pattern
* same as what we do in values
* remove comments
* fuzzy_get_platform_codes is one or none here
* more clean up
* sort imports
* woah woah woah
* add comment
* fix reassigning different types
* add types
* adapt fuzzy test recently added (nice it caught this!)
* update lock
* options
comments
* stash
* comments and fixes
* better comments
* better
* test: run on exact fuzzy matching logic, same results!
* use match_fw_to_car
* test all fw
* ex
* unused random
* this is a possibility
* this is more clear
* fix
* revert
* revert to needing both ECUs to match to reduce false positives, test
* fix excluded platform test :( but it's ok
* add comment
* we actually want to only test fuzzy ecus to make it explicit
* fix mypy
* comment for tomorrow
* just add matches with fuzzy FP
* add comment
* this was the cleanest I could think of, but still working on it. not very easy to understand
* think this is better, but also worse...
* comment: reframing how this works
* revert back to what we did before
* was swapped
* else set
* remove old comment
* fixes from merge
* remove fuzzy_min_match_count from this pr
* fix static analysis
* also unused
* different method first draft
* copy existing fuzzy func
* check all possible ecus exist, only platform codes, slightly refactor main loop
* fix
* Revert recent
Revert "fix"
This reverts commit 5cdb7bda83.
Revert "check all possible ecus exist, only platform codes, slightly refactor main loop"
This reverts commit d3e918fa20.
Revert "copy existing fuzzy func"
This reverts commit 34c8c05450.
Revert "different method first draft"
This reverts commit b91139055d.
* new func
* fixup test
* remove changes from v1 from fw_versions.py
* clean up a bit
* return part as part of code
* fix test
* add original fuzzy function
* add an ecu match if the date is within range (or date doesn't exist)
* add format for what we're going to do
* not working stash
* the exact matching function does more of what we want with less code and less custom logic
* we don't care about found versions, only codes and dates
* actually we do have an exception
* this works pretty nicely now
* up here
* this is better
* some minor clean up
* old function=now junk
* fix platform code test
* remove old platform code function
* now rename _new to
* use FW_QUERY_CONFIG
* clean up imports
* rename that too
* one line
* correct typing
correct typing
* draft tests
* so that works
* fixup excluded platform test now too
* this is tested by excluded platform test
* test parts and dates
* remove old comment
* old import
* take platform code stuff out of FwQueryConfig
* fix test
* revert debug script
* flip order
* make this a set by default
* revert this part
* correct typing
* clean up comments
* clean that test up too/pylint
* combine these three tests ina clean way
* not right
* more general
* be consistent with quotes
* comment
* comment
* comment in fw_versions
* flip order
* this is more readable
* could test all this, but it's tested in test_hyundai and doesn't do a lot here
* only assert brands which use this
* invalidate all CAN FD ICE and hybrid
* tuple
* can get away without filtering
* add comment reasons
* fix
* some review suggestions
* this works (first draft)
* this is better
* script to print platform codes and dates
* sanity check for dates are in correct ecus and platforms
* mypy
* better variable name and comment
* rename
* same
* slightly better name
* subset
* exclude platforms and live car without dates
* consistent
* self explan
* better name
* test to make sure the functions agree
* clean that up
* comment
* we get other responses from queries not in DB, only check any
* not used or typed
* bring platform codes out of config for now (can re-introduce later)
* clean that up
* flake8
* comment
* comments and better test names
* typo
* Update selfdrive/car/hyundai/tests/test_hyundai.py
* Update selfdrive/car/hyundai/tests/test_hyundai.py
* start on test
* better regex
* lookbehind
* comments to choose from
* i did not know that!
* common patterns in values.py
* messy messy
* need to remove these
* rmrmrm
* clean up test
* fixups
* not used yet
* none should be good enough
* Update selfdrive/car/hyundai/values.py
Shane Smiskol
Jason Wen
Felixowns
Caleb Stultz
Adeeb Shihadeh
Jason Young
Kacper Rączy
Justin Newberry
Cruise Brantley
Cameron Clough
joshslater
junhee Ahn