* move ui message handling out of condition
* relay openpilot fcw to car
* only send normal fcw if DSU is unplugged
* add comment
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* try to disable radar
* fix bug and bump panda
* prep
* always attempt longitudinal for testers
* fix rav4
* send ACC_HUD
* bump panda
* revert
* check for failure to disable
* fix arg
* bump to master
* revert to master
* comments only
* correct check
* carcontroller
* something like this
* or this
* use flag
* send PCS HUD
* clean up
* carstate checks
* fix from test models
* consistent
* try to disable radar
* fix bug and bump panda
* prep
* always attempt longitudinal for testers
* fix rav4
* send ACC_HUD
* bump panda
* revert
* check for failure to disable
* fix arg
* bump to master
* revert to master
* comments only
* fix subaru fault
* try this!
* wip
* try this
* this more or less worked
* this is all under gen2
* that needs to be up there
* comment
* steer_angle
* test
* wip
* wip
* sync
* wip
* cleanup
* remove print
* use sets and fix unittests
* common fault avoidance
* common fault avoidance
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* revert subaru to get this part merged
* revert name change
* revert name change
* revert name change
* same as before
* add test case
* also verify zero tolerance
* keep the current behavior
* split into multiple tests for easier debugging
* added comments and remove tests
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Comma Device <device@comma.ai>
* draft
* clean up
* there was a bug, need to subtract from last_angle essentially
* Revert "there was a bug, need to subtract from last_angle essentially"
This reverts commit a595e4af64.
* maybe
* Revert "maybe"
This reverts commit cc96523cc2.
* or can do this
* this seems simpler and actually would work
* update comment
* fix that case
* joystick testing
* revert testing changes
* comment should be more clear
* can have full thing
* bump panda to lta
* revert cc
* this seems to work well
* constants
* try setme_x64
* 99 just winds up torque?!
* try less torque
* add corolla
* clean up
* clean up
* clean up
* clean up
* better name
* -which
* fix
* fix typo
* use params
* use class params
* combine limiting, logic to create commands, and creating commands into one place
* remove super old debugging comment
* log angle
* Revert "log angle"
This reverts commit f5b763c59a.
* add headers
* test out lta message
* correctly send
* percentage is percentage driver isn't overriding
* closer to stock system
* should be able to send LTA at 100hz, counter is the same as LKA
* small amount of torque towards desired
* Offset commanded torque correctly
* Too little torque
* use car's SETME's
* Revert "use car's SETME's"
This reverts commit c888569699.
* try cutting steer every second
* Didn't seem to matter
This reverts commit 6923498b2a.
* steer to 0
* let packer set counter
* add for camry
* log steer faults
* comments
* bump opendbc
* add opParams
* add lta safety
* set safety param
* fix torque control bug
* bump panda
* fix missing signal
* [experiment] apply some rate limiting and anti-windup
* no faults, clip to 90 deg, decent torque blending
* clean up blending
* toyota angle rate limits
* use std angle limits
* assert we only add angle control to TSS2 cars
* clean up carcontroller a bit
* space space
* bump opendbc
* clean up toyotacan from opendbc change
* bump panda
* will tests run?
* steer at zero
* refactor angle to use LatControlPID with zero gains
* stop some faults and tuning
* possibly fix integral wind up at max torque
* Add 2023 rav4
* limit torque inside EPS when overriding (no huge windup in edge cases when overriding)
* fix wind up issue after turns (or prolonged saturation)
* this doesn't work that well
* try these limits
* try this
* log the angle!
* global variable
* Apply suggestions from code review
* clip angle to 3 m/s/s
* some tolerance for roll
* raise limits a bit
* bumppanda
* fix faults
* still not good
* offsetting causing hugging?
* Revert "offsetting causing hugging?"
This reverts commit a42ec0b772.
* reduce kp
* class var not needed
* limit up angle delta
* fix saturation check
* feedforward includes offset
* some threshold for roll
* bump panda
* surely we don't need this
* test stuff
* Toyota: Add FW for 2023 RAV4 Hybrid (#27494)
* Toyota: Add FW for 2023 RAV4 Hybrid
* Set RAVH_TSS2_2022 to use angle SteerControlType
* bump panda
* remove extras
* Revert "remove extras"
This reverts commit 87378e7349.
* no max angle limit for now
* add as separate platforms
* remove debug scripts
* revert to master
* remove these FW versions from 2022
* dashcam these cars :(
* fix test
* interface
* add to untested routes
* never send torque with LTA cars
* fix values
* clean up controlsd
* reset lat control files
* use the car param
* add to params
* bump panda to master
* Update selfdrive/car/toyota/carcontroller.py
* don't set torque params if angle control (fixes controlsd bug)
* reset controlsd
* keyword
* in another pr
* simplify test
* rm line
* Update selfdrive/car/toyota/tests/test_toyota.py
---------
Co-authored-by: crispbee <84819466+crispbee@users.noreply.github.com>
* draft
* bump opendbc
* still draft
* that's not right
* superset of the changes, 33hz
* cleanup
* this should work
* remove line
* pass it in again
* actually no need to check updated now
* now_nanos
* consistent name
* fix replay
* one line isn't that bad
switch
switch
* fix CarController tests
* Update ref_commit
* Toyota: pass through sway warning system signals
* signal doesn't seem to exist on the Prius V
bad log?
* remove duplicated checks
* syntax
* Revert "syntax"
This reverts commit 6c30c30d46.
* Revert "remove duplicated checks"
This reverts commit 6a364984eb.
* Revert "signal doesn't seem to exist on the Prius V"
This reverts commit 57fa571fde.
* Revert "Revert "signal doesn't seem to exist on the Prius V""
This reverts commit 9b1c3f6cac.
* Revert "Revert "remove duplicated checks""
This reverts commit 38bc7f3de6.
* Revert "Revert "syntax""
This reverts commit f81f93631f.
* hard code values for Prius V
* send ui once every 25 frames
remove send ui logic
* send UI immediately on pcm_cancel_cmd
* draft
* clean that up
* same order as toyotacan
* update refs
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* note for dsu cars
* don't hardcode dsu footnote (1/2)
* test
* revert the experimental long toggle
* another day:(
* DSU doesn't have to be toyota specific, it's a generic carParam!
* this is safe, just make sure it's unknown
* these cars do not have OP long for some reason
* UNSUPPORTED_DSU_CAR
* forgot this
* .
* .
* revert
* revert
* smaller diff
* try a method to kill those faults
* cut torque for 1 frame
* sign doesn't seem to matter
* clean up
* better name
* Toyota allows you to keep your apply_steer, better control
* the logic was wrong entire time?
* cut steer for two frames
* Revert "cut steer for two frames"
This reverts commit 13a68ecc56.
* better variable names and comments
better variable names and comments
* should be good
* add safety
* actual number of frames
* constant
* bump panda
* bump panda
* bump panda
* bump panda
* bump panda
* bump panda
* bump panda
* fix to use min valid frames
* rm line
* simplify check
* bump panda
* bump panda to master
* Toyota: fill steerFaultPermanent
* same behavior as before, 0 is also fault (0 is most likely initializing)
* think this was just wrong (2 or 10 would mean we think it's a fault)
* Initial commit
* Fix bugs
* Need more torque rate
* Cleanup cray cray control
* Write nicely
* Chiiil
* Not relevant for cray cray control
* Do some logging
* Seems like it has more torque than I thought
* Bit more feedforward
* Tune change
* Retune
* Retune
* Little more chill
* Add coroll
* Add corolla
* Give craycray a good name
* Update to proper logging
* D to the PI
* Should be in radians
* Add d
* Start oscillations
* Add D term
* Only change torque rate limits for new tune
* Add d logging
* Should be enough
* Wrong sign in D
* Downtune a little
* Needed to prevent faults
* Add lqr rav4 to tune
* Try derivative again
* Data based retune
* Data based retune
* add friction compensation
* Doesnt need too much P with friction comp
* remove lqr
* Remove kd
* Fix tests
* fix tests
* Too much error
* Get roll induced error under 1cm/deg
* Too much jitter
* Do roll comp
* Add ki
* Final update
* Update refs
* Cleanup latcontrol_torque a little more
* do tesla
* parentheses
* Do Chrysler
* Make sure Hyundai long never actuates when long inactive
.
* clean up Hyundai
* more clear
* formatting
* Stock sets these to zero
* fix params
* move jerk logic into CC
clean up
* proof of concept
* actuators packet describes which actuators are active
* bump cereal
* fixes
* not needed for this PR
* Do Toyota
* add back controlsState.active
* bump cereal
* rest of cars
* in actuators
* add active back
* which
* use controlsState.active for now
* will make an issue
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* move local lat_active checks into CC.latActive
* remove redundant checks
* move comment
move comment
* fix joystick mode
* get enabled from carcontrol
* do standstill check in controlsd
* make sure we consider the gas press case for GM
* use CC.actuators
* fix
* capitalization
* Bump cereal
Bump cereal
* make intermediate actuators
* similar convention to before
* clean that up
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* check in tuple instead of list
* Update selfdrive/car/toyota/carcontroller.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Update selfdrive/car/mazda/interface.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Add f/w firmware for Lexus RC under LEXUS_IS
`@ph33rl355#0529` 2020 Lexus RC F Track Edition DongleID/route 32696cea52831b02|2021-11-16--23-12-02
Doesn't seem to need a full port, per user feedback...
https://discord.com/channels/469524606043160576/524327905937850394/910400788319326229
* Update CARS.md
* Separated Lexus RC from IS... still using IS DBC
* match lexus IS for now
* Update wheelbase to match published specs
I'm hesitant to touch `mass`, even though I know it's different from the IS.
* Add TOYOTA.LEXUS_RC test route
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* ignore permanent low speed lockout
* should always check in case not seen
* use cp_cam
* not bus 0
* change signal name according to ref dbc
* bump
* we don't rely on this
* bump
* Revert "Toyota: debug logging for low speed lockout (#21526)"
This reverts commit 7f2ad50fed.
* add back
* always add
* pass acc_type through
* Update selfdrive/car/toyota/carstate.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/car/toyota/carstate.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* only update acc_type if not enableDsu
* only add when using
* only for openpilot long cars
* only seen TSS2
* add todo
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Jason Wen
Irene
Shane Smiskol
Adeeb Shihadeh
Justin Newberry
HaraldSchafer
Cameron Clough
Dean Lee
Willem Melching
Kevin Robert Keegan
Erich Moraga