6008b2e71a
longcontrol: enter stopping state immediately ( #26879 )
...
* enter stopping state immediately
* Update selfdrive/controls/lib/longcontrol.py
old-commit-hash: 4e9bddee5c
2 years ago
db8028fa63
longcontrol: ignore cruise standstill if interceptor ( #26597 )
...
* ignore standstill
* cmt
* standstill
* rm cmt
* flip
old-commit-hash: a19b5b91d2
2 years ago
e20020053d
Longcontrol: faster transition from starting to stopping ( #26361 )
...
* Never command accel when stopping
* Update ref_commit
old-commit-hash: a7ced7c54b
3 years ago
8e1e6132c8
GM: raise max brake ( #25810 )
...
* -4 didn't make any sense?
* comments
* comments
* update to 400
* bump panda
* remove unused iso limit vars
* update comments
* bump panda
* Update selfdrive/car/gm/values.py
* Update ref_commit
old-commit-hash: 84adb8d925
3 years ago
f6700cb7ba
remove blank whitespace ( #25921 )
...
old-commit-hash: 7df0e3efcf
3 years ago
30ba3096a3
Longcontrol: fix possible reference before assignment ( #25715 )
...
fix possible reference before assignment
old-commit-hash: 056b2ec2ed
3 years ago
1c2c840a8a
Let planner decide stopping state ( #25643 )
...
* Let planner decide stopping
* Refactor stop/start state machine
* Stay stoppe condition
* 1sec from target
* Add starting state
* Add starting state logic
* Undo some changes
* Update ref
old-commit-hash: 210a6163ac
3 years ago
bc679f735d
Misc torque control fixes ( #24801 )
...
* Fiction compensation should be based on error
* Update refs
* Add deadzone
* update ref
old-commit-hash: 843e59f6f0
3 years ago
12d0a18a05
Clean up controllers ( #24340 )
...
* clean up lat controllers
* pass CP once
* sort
old-commit-hash: c9be2f02c3
3 years ago
305a7a6bc9
Make PI into a PID ( #24151 )
...
* Make PI into a PID
* Cast like before
old-commit-hash: 634f7cebef
3 years ago
474ba19c81
Add Disengage on Accelerator Toggle ( #23977 )
...
* Squashed commit of the following:
commit 953bcf0ecf8d03f0fec9ce0d5442cc660ae2347d
Merge: b4198608d efd04715e
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 1 19:58:06 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit b4198608dac9595bfeb9443f95cd6c5d385cd62d
Merge: 24f90b2c8 0e983562d
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 1 14:32:54 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 24f90b2c8d6ae509c0776b6e33b743467aa08dee
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 31 14:07:52 2022 -0700
revert changes and get ready for override
commit aa514df6b5e8431f0faa07f6b25eb5cb6c9f2749
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 20:52:24 2022 -0700
temporary
commit c874e10c2555968c683f629c4582ab22e51d431f
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 00:30:13 2022 -0700
move gasPressed to controlsd
commit fe670439dff5bc6dfc5963d79ca2febe0c5920c7
Merge: 49d3b6d11 c78701e47
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 00:15:48 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 49d3b6d1162893fa94b2294152f0718eeb4698ed
Merge: 475b27e74 3e819bc5a
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon Mar 28 13:06:08 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 475b27e74fd6479f1d148e9ded1eca6ee476865c
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 20:24:59 2022 -0700
update SAFETY.md
commit 0798eadb82749e12ecbaa86f4e57b21bd3dbc7e8
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 17:52:06 2022 -0700
⛽ ➡️ 🔋
bump
commit d2b64b89cf8d7265bc90848b4e3a2276c9a4cb78
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:19:34 2022 -0700
these changes will be in border PR
these changes will be border PR
commit bed31e63de2244c161729773978fef8a9246ddb5
Merge: 491417640 603e07793
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:17:31 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 49141764098e3a701ff123ead52de4656b31db4d
Merge: 9291e9f00 46ed8bb8e
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 23 19:00:26 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 9291e9f0045780669b2ffa7f08fb10373c03b070
Merge: 2aed64157 2c947f193
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 18 19:03:13 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 2aed64157d6e9dc993d103a2c6abf7e643410562
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 18 19:03:03 2022 -0700
Revert "send pre-enable state when gas is pressed"
This reverts commit 8d82e697dc2efade307413e767d14b56b4d2d079.
commit a219defe5342efa731a957b2ff4fd86292c1f239
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 17 12:50:46 2022 -0700
bump cereal
commit 8d82e697dc2efade307413e767d14b56b4d2d079
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 16 22:40:13 2022 -0700
send pre-enable state when gas is pressed
formatting and it's out
forgot one
allow gas press
show toggle
revert changes
revert changes
commit 5eb4d1ab1b77ac65bdd901f692ebfb848d5187ca
Merge: bad1bdc74 d0ef25959
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 16 22:29:43 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit bad1bdc7428c5d8a4a765b259da504f0ade84424
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 23:03:56 2022 -0700
clean up a bit
commit 7516ed9b786536a07f00a92b9c1742ca252a01d1
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:55:09 2022 -0700
these are null checks right now
commit 408f5f1d633521b29b08d966c9b387fa79dff0d6
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:51:14 2022 -0700
should work
commit be1978e29c03d8843cf073cc9ddf84020fd2b378
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:36:16 2022 -0700
stash
commit f0bd4c47e9d27061c6cd3b88765a7c10995f42db
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:26:24 2022 -0700
this was flipped
commit d5b6e30389a727e8559331acd706422e1b246f60
Merge: 820b19894820b19894991763f9ff91763f9ff4🔥
commit 1885c9e2ba1f591736a1f591736a2465811f0b465811f0b40344363a53700efcb3f700efcb3f4220ce272fed273bb78ac1a85afd60ce3be32afc2f27203af3a04c0ad1a5499cf13caeb2230254ca787475e02cbf1f40c117a
3 years ago
83e26d674f
LongControl: fix control state oscillation ( #23333 )
...
* check if plan is to accelerate or not
* remove comment
* needed to see it
needed to see it
* test logic with Toyota TSS2
* hackily log conditions
* Revert "hackily log conditions"
This reverts commit 7a6b5691e2b982c7a1e3911d980fb7530647affd.
Revert "test logic with Toyota TSS2"
This reverts commit e583d6e3caaa5f5b896165cd7949dfc1caabfd9a.
order
* revert
* fix
old-commit-hash: 7254db3906
3 years ago
1f5570a96d
Longitudinal control: interpolate longitudinal plan ( #23787 )
...
* interpolate longitudinal actuator delay
rename
* formatting
* interpolate v_target most importantly!
* fix interpolation and rename
* nicer setup
* left in from testing
* update refs
old-commit-hash: 2c7845fce0
3 years ago
c12656f397
Longitudinal: add Kf to carParams ( #23752 )
...
* sane_kf
* long_kf + cereal
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9535dc606d
3 years ago
beeb0442ce
base LatControl class ( #21967 )
...
* base LatControl class, move sat check out of pid.py
clean up
clean up
* fix
* global variable for min control speed
* nicer name
* unify latcontrol class init arguments
* add to release files
* saturated if close to limit
* move angle mode saturation checks into class
* check_saturation function takes in current saturated status
undo
* apply latcontrol_angle's active checking to all controllers
* clean up
* move those back
* make abstract baseclass
* add test for saturation
* keep clip
* update ref
* fix static analysis
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9de8f8cd8c
3 years ago
97c4cdc0cc
LongControl: remove redundant check on active ( #23481 )
...
old-commit-hash: 4208fe018e
3 years ago
521e3d843b
longcontrol: check if speeds is empty ( #23410 )
...
* check if speeds is empty
* move into existing check
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a2e762e0b9
3 years ago
d05c173fe6
Longcontrol: remove starting state ( #23328 )
...
* remove starting state
* new ref
* ready for merge
* try this
* cereal now on master
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: cf9792dc53
3 years ago
a55046c949
longcontrol/update: optimize capnp ( #23382 )
...
old-commit-hash: 5dc631fa1b
3 years ago
91ff6918e5
Remove minSpeedCan ( #22991 )
...
* Remove minCanSpeed
Remove minCanSpeed
* it actually only goes out to 2.5 seconds, this is okay to remove
* test to see if this preserves behavior
add minSpeedCan
* Revert "test to see if this preserves behavior"
This reverts commit 31b11f017f7e9da7654fc8064b5983d4a6cc22e5.
* preserve behavior (don't enter stopping as early)
* vEgoStopping needs to be less than or equal to vEgoStarting to avoid state oscillation
old-commit-hash: 2799ef5292
3 years ago
fb1cf5b1bf
Longcontrol : pid error should be 0 when plan is followed ( #23066 )
...
* v_pid error should be 0 when plan is followed
* update ref
old-commit-hash: 048cc3ac9f
3 years ago
996594fa29
longitudinal: only apply overshoot prevention when braking ( #22986 )
...
* only if braking is desired
* use v_target to determine stopping
* more clear?
old-commit-hash: 113988ae31
3 years ago
9c994173ed
Longcontrol: do not clip vEgo to minSpeedCan ( #22832 )
...
* fix tss2 slow reacceleration in sng
(should) preserve stopping behavior
add comments since it's confusing
fix
* Revert "fix tss2 slow reacceleration in sng"
This reverts commit 42abde0eb945d8bc5ad9b502d1d89b3e3dc16f8a.
* don't max(vEgo)
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: bdaea086f8
4 years ago
d688b62c62
Add upper/lower bounds for longitudinal lag ( #22235 )
...
* Add upper/lower bounds for longitudinal lag
* add ref
* update ref
* bump cereal
* bump cereal
old-commit-hash: 417e229624
4 years ago
523219c678
Parameterize longitudinal control using carParams ( #22200 )
...
* use CP.startAccel
* missing values
* order
* update ref
* cereal
old-commit-hash: b7d1aac197
4 years ago
b079219b93
Use CP.vEgoStopping and clean up CP.startAccel ( #22199 )
...
* use CP.vEgoStopping and clean up
* update ref
old-commit-hash: 1e62b09e5d
4 years ago
cb1cd01bdf
cleanup old nidec accel override logic ( #22181 )
...
* cleanup old nidec accel override logic
* add ref without deprecated fields
* no more override
old-commit-hash: 74b6c87254
4 years ago
ab7d2f1d08
put LongControlState in CarControl.Actuators ( #22154 )
...
old-commit-hash: 21ae64868e
4 years ago
977cf8ca02
parameterize longitudinal actuator delay ( #22153 )
...
* paremetrize longitudinal actuator delay
* update ref
old-commit-hash: b39f6efa3f
4 years ago
6f5c9d5ad1
Clean up PID controller ACCEL_MIN/ACCEL_MAX ( #22148 )
...
* use ISO 15622:2018 limits in PID controller
* allow more for nidec
* limit PID inputs
* CP is not needed
* add GM
* not used
* update ref
* fix honda bosch
old-commit-hash: f941111dcd
4 years ago
1b98341932
Prevent PID windup on Honda NIDEC ( #22112 )
...
* add higher set speed
* freeze when close to cruise
* dont bias this
* higher set speed
* start high
* 2mph might be needed
* better condition
* limit accel windup like this
* wrong name
old-commit-hash: ebf2a2279d
4 years ago
4e7cca187c
unused
...
old-commit-hash: a4ae99a489
4 years ago
a06ffc48c1
Smarter longitudinal lag compensations ( #22094 )
...
* smarter lag compensations
* need to use speed from plan
* update ref
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: edae2218d7
4 years ago
a73a820338
Change car controller interface from gas/brake to acceleration ( #21911 )
...
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa
4 years ago
41b7cbdadf
longitudinal comments ( #21898 )
...
* cmt
* Update longcontrol.py
old-commit-hash: 737a79e556
4 years ago
96d4bfbff3
Refactor long ( #21433 )
...
* refactor
* needs casting
* tests pass
* fix that test
* refactor in controls
* lets not go crazy
* change of names
* use constants
* better naming
* renamed
* soft constraints
* compile slack variables
* rm git conflict
* add slack variables
* unused
* new edition
* fcw
* fix tests
* dividing causes problems
* was way too slow
* take a step back
* byeeee
* for another time
* bad idxs
* little more cpu for cruise mpc
* update refs
* these limits seem fine
* rename
* test model timings fails sometimes
* add default
* save some cpu
* Revert "little more cpu for cruise mpc"
This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.
* Revert "test model timings fails sometimes"
This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.
* update refs
* less cpu
* Revert "Revert "test model timings fails sometimes""
This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.
* Revert "less cpu"
This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.
* cleanup
* not too much until we clean up mpc
* more cost on jerk
* change ref
* add todo
* new ref
* indentation
old-commit-hash: be5ddd25cd
4 years ago
8bc42f4aff
Parametrize startingBrakeRate ( #19511 )
...
* Parametrize startingBrakeRate
* new ref_commit
old-commit-hash: 717bc747c3
4 years ago
faa4c57ee1
Parametrize stoppingBrakeRate ( #2745 )
...
* Parametrize stoppingBrakeRate
* ref_commit updated
old-commit-hash: d3c2a0e6c1
4 years ago
95bb79c51c
Parametrize MIN_CAN_SPEED in car interfaces ( #2684 )
...
* Parametrize MIN_CAN_SPEED in car interfaces
* fixed instance in planner.py
* fix typo
* var name change
* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files
* added default value to get_std_params, removed unneeded instances from car interface files
* Revert PEP8 autoformat corrections
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 093456cc40
4 years ago
b48d1823e9
remove unused globals, use self.reset() ( #2220 )
...
Co-authored-by: user <email@web.com>
old-commit-hash: 254814cc79
5 years ago
3454f1e033
Fix hard deceleration after user accelerates above set cruise speed ( #1880 )
...
* Fix hard deceleration after user accelerates above set cruise speed
* 2nd required change
old-commit-hash: ebadb39e42
5 years ago
37a67a2a14
enable flake8 E502: backslash is redundant between brackets
...
old-commit-hash: 6466ec982a
5 years ago
fe106e25a3
Controlsd refactor ( #1487 )
...
* it's a class
* more refactor
* remove that
* car interface should create that
* that too
* not a dict
* don't create permanent events every iteration
* break up long lines
* fix honda
* small optimization
* less long lines
* dict is faster
* latcontrol less args
* longcontrol less args
* update profiling script
* few optimizations
* create events together
* clean up
* more clean up
* remove comment
* clean up
* simplify state transition
* more clean up
* update comments
old-commit-hash: 08832ff29d
5 years ago
079eee7294
selfdrive/controls
...
old-commit-hash: b0260dadba
5 years ago
81dd5a50cf
root commit
...
old-commit-hash: 6c33a5c1f3
5 years ago
89d1d84c70
openpilot v0.6.5 release
...
old-commit-hash: cf80f7a28b
6 years ago
e47a2e6e30
openpilot v0.5.13 release
...
old-commit-hash: dd34ccfe28
6 years ago
0932b367bd
openpilot v0.5.12 release
...
old-commit-hash: 3f9059fea8
6 years ago
2cc4edde68
openpilot v0.5.9 release
...
old-commit-hash: 0207a97040
6 years ago
fdbf213be8
openpilot v0.5.6 release
...
old-commit-hash: 860a48765d
7 years ago
Shane Smiskol
Harald Schäfer
Lee Jong Mun
ClockeNessMnstr
Dean Lee
Willem Melching
Igor
qadmus
Adeeb Shihadeh
Adeeb
George Hotz
Vehicle Researcher