* update names + notes for MPC outputs
"current_curvature" is not the correct description of what the MPC is outputting in it's curvature_ego state.
The MPC is integrating it's free variable, curvature_rate, such that curvature[0] is actually the desired_curvature before any delay.
inversely: the curvature_rate_desired is the desired rate of change to the setpoint and not the actual curvature rate.
If we were to set the initial curvature = measured curvature in the MPC initiation these names would be correct.
This was possibly how it was initially set up but the nomenclature here is now confusing.
* more notes
* match
* Clarify #1
old-commit-hash: b215d611b1
* Set good torque using torque controller tuning
* should be equal to
* save lateral accel to car params
* use maxLateralAccel
* always
* same convention
* nan will always evaluate to false
* The great good torque purge
* adjust default friction
* Add data for more cars
* adjust name
* Welcome back, guys. Only adjust good torque if maxLatAccel is set
* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c
* simulator: support running wide camera only
* proper frame id
* use param name that makes more sense
* do some cleanup
* Update tools/sim/bridge.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: b5aed2bf67
* Revert "Revert torque control (#24565)"
This reverts commit 93f434d047a92366c4ccefeece86fe101ed98d02.
* Move tune out of car specific stuff
* Update ref commit
old-commit-hash: d928972150
* set while gas pressed to resume
* better order
* what was I thinking?
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* only if under set speed
* some clean up and ciel the v_cruise_kph
* clean up
* actually floor
* Should be cruise min
* On phone, will clean up
* Think no floor is fine
* clean up and catch setCruise
* update comment and just always do rounding and clipping
update comment
* flip order
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
old-commit-hash: d3d210c183
* move to super
* no class variable
* there's CP
* whitespace
* drop CI from latcontrol super
* Revert "drop CI from latcontrol super"
This reverts commit 9218273060.
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: a693b3a26b
* add mypy check for return-any
* remove unused import
* typing
* remove unnecessary variable typing
* cleanup
* cleanup
* bump submodules
* small fixes
* only a problem on mac
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d2eef1955c
* controlsd: better alert precedence for system malfunctions
* down to 20
* move that
* check can flags
* update refs
* update refs
old-commit-hash: be748c0d6a
* Initial commit
* Fix bugs
* Need more torque rate
* Cleanup cray cray control
* Write nicely
* Chiiil
* Not relevant for cray cray control
* Do some logging
* Seems like it has more torque than I thought
* Bit more feedforward
* Tune change
* Retune
* Retune
* Little more chill
* Add coroll
* Add corolla
* Give craycray a good name
* Update to proper logging
* D to the PI
* Should be in radians
* Add d
* Start oscillations
* Add D term
* Only change torque rate limits for new tune
* Add d logging
* Should be enough
* Wrong sign in D
* Downtune a little
* Needed to prevent faults
* Add lqr rav4 to tune
* Try derivative again
* Data based retune
* Data based retune
* add friction compensation
* Doesnt need too much P with friction comp
* remove lqr
* Remove kd
* Fix tests
* fix tests
* Too much error
* Get roll induced error under 1cm/deg
* Too much jitter
* Do roll comp
* Add ki
* Final update
* Update refs
* Cleanup latcontrol_torque a little more
old-commit-hash: fe0bcdaef6
* control with joystick
* slow it down
* always joystick for not car
* clean ups
* not stateful
* move submaster
* only if we aren't in test mode
* update refs
* double ki speed, update ref
* this ref
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7dd71cc63d