52a28d8938
update DH names + notes for MPC output curvatures ( #24701 )
...
* update names + notes for MPC outputs
"current_curvature" is not the correct description of what the MPC is outputting in it's curvature_ego state.
The MPC is integrating it's free variable, curvature_rate, such that curvature[0] is actually the desired_curvature before any delay.
inversely: the curvature_rate_desired is the desired rate of change to the setpoint and not the actual curvature rate.
If we were to set the initial curvature = measured curvature in the MPC initiation these names would be correct.
This was possibly how it was initially set up but the nomenclature here is now confusing.
* more notes
* match
* Clarify #1
old-commit-hash: b215d611b1
3 years ago
1a2bf8412c
Car documentation: set steering torque star using car interface ( #24709 )
...
* Set good torque using torque controller tuning
* should be equal to
* save lateral accel to car params
* use maxLateralAccel
* always
* same convention
* nan will always evaluate to false
* The great good torque purge
* adjust default friction
* Add data for more cars
* adjust name
* Welcome back, guys. Only adjust good torque if maxLatAccel is set
* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c
3 years ago
753045c73d
less TICI when not needed ( #24698 )
...
* less TICI when not needed
* fix process replay
* move reading voltages into hw abstraction layer
* Update selfdrive/hardware/tici/hardware.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/hw.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/base.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* rename init function
* Update selfdrive/athena/athenad.py
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
* Update selfdrive/boardd/boardd.cc
* Apply suggestions from code review
* Update selfdrive/thermald/thermald.py
* update ref
* fix alert width if all cameras are bad
* add ecam to test_loggerd
* bump cereal
* bump cereal
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
old-commit-hash: f49a9c9fd2
3 years ago
f5a6a6dc77
Tssp prius torque control ( #24669 )
...
* use llk
* use steering sensor at low speed stil
* Try more simple
* rm prius tune
* updated ref
old-commit-hash: d708a134bd
3 years ago
39886246c9
Rerevert torque control ( #24649 )
...
* Revert "Revert torque control (#24565 )"
This reverts commit 93f434d047a92366c4ccefeece86fe101ed98d02.
* Move tune out of car specific stuff
* Update ref commit
old-commit-hash: d928972150
3 years ago
55085a12db
New model: better laneless ( #24605 )
...
* Fix ping pong
* Fix hugging: e6fd3a62-aa86-46d1-a414-19137ed1babc/800
* Remove lateral toggle
* a6da6265-1952-48dd-986b-2b5996dd2642/950
* Model replay commit
* Revert "Remove lateral toggle"
This reverts commit 69e57eb7e17da48ebdba
3 years ago
29e2b3f757
controlsd: ensure all system malfunction events have the right types ( #24635 )
...
old-commit-hash: 71901c94db
3 years ago
51165e5df5
Latcontrol torque: integrator need not be reset ( #24606 )
...
slow integrators need not be reset
old-commit-hash: 2181bbca71
3 years ago
56a44d41f8
controls: pressing set while gas pressed resets to vEgo ( #24100 )
...
* set while gas pressed to resume
* better order
* what was I thinking?
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* only if under set speed
* some clean up and ciel the v_cruise_kph
* clean up
* actually floor
* Should be cruise min
* On phone, will clean up
* Think no floor is fine
* clean up and catch setCruise
* update comment and just always do rounding and clipping
update comment
* flip order
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
old-commit-hash: d3d210c183
3 years ago
efa559f9be
Revert torque control ( #24565 )
...
* torque reversal start
* Fix carmodel tests
* Update ref
* update ref
* Elif is better than if
old-commit-hash: 9f8b03753d
3 years ago
a6bcd14abd
show which cameras are malfunctioning ( #24558 )
...
old-commit-hash: 0b1f6e3620
3 years ago
cfc16a88c5
improved alert verbosity ( #24434 )
...
* improved alert verbosity
* better testing script
* better description
* speed diff
* touch ups
* fix that
old-commit-hash: b1858df00e
3 years ago
19aebce4f2
Round system overheated temperature ( #24544 )
...
* Update events.py
* Apply suggestions from code review
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 961a121fde
3 years ago
b9a07b8f05
Round model lagging frame drop percentage ( #24549 )
...
alerts: round model frame drop percentage
old-commit-hash: 076f0acd5f
3 years ago
a7dceb30ae
LatControlTorque: clean up class variable ( #24526 )
...
* move to super
* no class variable
* there's CP
* whitespace
* drop CI from latcontrol super
* Revert "drop CI from latcontrol super"
This reverts commit 9218273060a693b3a26b
3 years ago
2dfba97175
add mypy check for return-any ( #24379 )
...
* add mypy check for return-any
* remove unused import
* typing
* remove unnecessary variable typing
* cleanup
* cleanup
* bump submodules
* small fixes
* only a problem on mac
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: d2eef1955c
3 years ago
3427eb411b
Latcontrol torque: fix integrator induced ping pong ( #24458 )
...
* Latcontrol torque: fix integrator induced ping pong
* Reset on disengage since unwind resets anywayh
* Might be overkill
* rm whitespace
* update ref
old-commit-hash: 29afd53d88
3 years ago
af82274bac
LatControlTorque: log desired/actual lateral accel ( #24406 )
...
* log torque lateral accel
* bump cereal
* update refs
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9a44d4c4e0
3 years ago
fdf13d565b
controlsd: add lagging alert ( #24360 )
...
* controlsd: add lagging alert
* move those
* just this for now
* no camera malfunction
old-commit-hash: 3abbe827de
3 years ago
d82f65a1b7
Accept resumeCruise for resuming prior speed setpoint ( #24348 )
...
* accept two button types for resume
* retry CI
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 45f131e0e7
3 years ago
12d0a18a05
Clean up controllers ( #24340 )
...
* clean up lat controllers
* pass CP once
* sort
old-commit-hash: c9be2f02c3
3 years ago
3e9694d3f3
LatControlTorque: fix deadzone and missing steer saturated warning ( #24294 )
...
* fix steer saturated alert and deadzone
* fix and formatting
* update refs
* update refs
* not needed
* remove
old-commit-hash: e834b4d9be
3 years ago
8823b9e4a5
longitudinal_mpc: Compute forward distance from velocity ( #24328 )
...
* add vel integ as x in e2e long mpc
* add comment
old-commit-hash: 1a9f5d29d4
3 years ago
75174c93d7
more verbose debug alerts ( #24126 )
...
old-commit-hash: 70987fd9d9
3 years ago
2174005f05
Lateral torque-based control with roll on TSS2 corolla and TSSP rav4 ( #24260 )
...
* Initial commit
* Fix bugs
* Need more torque rate
* Cleanup cray cray control
* Write nicely
* Chiiil
* Not relevant for cray cray control
* Do some logging
* Seems like it has more torque than I thought
* Bit more feedforward
* Tune change
* Retune
* Retune
* Little more chill
* Add coroll
* Add corolla
* Give craycray a good name
* Update to proper logging
* D to the PI
* Should be in radians
* Add d
* Start oscillations
* Add D term
* Only change torque rate limits for new tune
* Add d logging
* Should be enough
* Wrong sign in D
* Downtune a little
* Needed to prevent faults
* Add lqr rav4 to tune
* Try derivative again
* Data based retune
* Data based retune
* add friction compensation
* Doesnt need too much P with friction comp
* remove lqr
* Remove kd
* Fix tests
* fix tests
* Too much error
* Get roll induced error under 1cm/deg
* Too much jitter
* Do roll comp
* Add ki
* Final update
* Update refs
* Cleanup latcontrol_torque a little more
old-commit-hash: fe0bcdaef6
3 years ago
5a9644261f
remove comma two support ( #24248 )
...
* remove comma two support
* cleanup release files
* little more
* more libs
* no more gralloc
* add snpe back
old-commit-hash: 5c48e7bc86
3 years ago
e8ad31f32b
controlsd: handle controls mismatch race ( #24245 )
...
* controlsd: handle controls mismatch race
* update refs
old-commit-hash: 233a167cc9
3 years ago
598ba913ae
Fix camera error description ( #24202 )
...
* Fix camera error message
* Shorter
old-commit-hash: e0845752e3
3 years ago
3789587df1
add alert for CAN bus timeout ( #24162 )
...
* add alert for CAN bus timeout
* add alert
* set in interface
* cleanup
* cleanup
* add event
* fix mock
* bump
* bump opendbc
* update refs
* return reader
old-commit-hash: 49c2164814
3 years ago
b0444b39d2
Body cleanup + 100Hz locationd ( #24168 )
...
* use PID
* 100hz on the branch
* Better defaults
* fix int clip
* More cleanup
* Fix pid comments
* only notcar gets 100hz
* cleanup
* fix tests
* ignore
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f54e724b5d
3 years ago
305a7a6bc9
Make PI into a PID ( #24151 )
...
* Make PI into a PID
* Cast like before
old-commit-hash: 634f7cebef
3 years ago
e04e6fea87
bump cereal
...
old-commit-hash: 162e47456c
3 years ago
3683360f86
controlsd: fix long press set speed increment ( #24161 )
...
old-commit-hash: 1ea66ee244
3 years ago
83c103e46a
update camera CRC alert text ( #24156 )
...
old-commit-hash: fb344021aa
3 years ago
a47666d1fd
add cameraFrameRate alert ( #24152 )
...
* add cameraFrameRate alert
* bump cereal
old-commit-hash: 1848050fd9
3 years ago
871ecc451b
commIssueAvgFreq: separate alert for avg freq check ( #24150 )
...
* commIssueAvgFreq: separate alert for avg freq check
* bump cereal
* bump cereal
* bump cereal
* freq_ok separate from alive
* bump cereal to master
* update_ref
* fix profiler
old-commit-hash: eaa5819211
3 years ago
df8476118b
Latency logging 2 ( #24058 )
...
* msg_order and gantt
* frameId in long/lat planner
* track frame id
* controls frame id
* graph tracked events
* graph json
* cloudlog timestamp
* c++ cloudlog
* add frame id
* bug fixes
* bug fixes
* frame id visionicp
* bug fixes and debug level
* timestamp log placement
* print timestamps in table
* translate events
* more logging
* bug fixes
* daemon boardd
* print logs with boardd
* more timestamp logs
* cleanup
* remove publish logs
* bug fix
* timestamp received
* timestamp received
* bug fixes
* use json lib
* ignore driver camera
* prep for new timestamp pipeline
* bug fix
* read new pipeline unfinnished
* read new pipeline
* bug fix
* add frame to controlsstate
* remove controlsstate
* print
* cleanup
* more cleanup + bug fix
* clock build issue
* remove unused imports
* format durations
* increase speed
* pr comments fixes
* conflicts
* set MANAGER_DAEMON for boardd
* clean script code
* bug fix + argparse
* remove rcv time
* bug fixes
* print without tabulate
* fix pre-commits
* plot gnatt
* color bug fix
* read without timestampextra
* bump panda
* mono time instead of frame id
* finnish script
* clean unused
* clean unused logging
* monotonic + json fixes
* del test
* remove whilelines
* bump laika
* cleanup
* remove deps
* logs nicer strings
* remove plotting from scirpt
* reset pipfile
* reset pipfile
* nicer strings
* bug fix
* bug fix
* pr comments cleaning
* remove plotting
* bug fix
* new demo route
* bump opendbc and panda
* cereal master
* cereal master
* script less komplex
* assertions
* matplotlib
* readme
* Update README.md
* graph html
* design fixes
* more code design
* Update common/logging_extra.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* whitespace
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update tools/latency_logger/latency_logger.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* pr comments
* bug fix
* readme + env once
* clean swaglog
* bug fix
* Update tools/latencylogger/README.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* revert
* revert
* clean swaglog with error
* remove typo file
* revert graph
* cereal
* submodules
* whitespaces
* update refs
Co-authored-by: Bruce Wayne <batman@workstation-openpilot2.internal>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 65fca83abe
3 years ago
474ba19c81
Add Disengage on Accelerator Toggle ( #23977 )
...
* Squashed commit of the following:
commit 953bcf0ecf8d03f0fec9ce0d5442cc660ae2347d
Merge: b4198608d efd04715e
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 1 19:58:06 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit b4198608dac9595bfeb9443f95cd6c5d385cd62d
Merge: 24f90b2c8 0e983562d
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 1 14:32:54 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 24f90b2c8d6ae509c0776b6e33b743467aa08dee
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 31 14:07:52 2022 -0700
revert changes and get ready for override
commit aa514df6b5e8431f0faa07f6b25eb5cb6c9f2749
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 20:52:24 2022 -0700
temporary
commit c874e10c2555968c683f629c4582ab22e51d431f
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 00:30:13 2022 -0700
move gasPressed to controlsd
commit fe670439dff5bc6dfc5963d79ca2febe0c5920c7
Merge: 49d3b6d11 c78701e47
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 00:15:48 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 49d3b6d1162893fa94b2294152f0718eeb4698ed
Merge: 475b27e74 3e819bc5a
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon Mar 28 13:06:08 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 475b27e74fd6479f1d148e9ded1eca6ee476865c
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 20:24:59 2022 -0700
update SAFETY.md
commit 0798eadb82749e12ecbaa86f4e57b21bd3dbc7e8
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 17:52:06 2022 -0700
⛽ ➡️ 🔋
bump
commit d2b64b89cf8d7265bc90848b4e3a2276c9a4cb78
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:19:34 2022 -0700
these changes will be in border PR
these changes will be border PR
commit bed31e63de2244c161729773978fef8a9246ddb5
Merge: 491417640 603e07793
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:17:31 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 49141764098e3a701ff123ead52de4656b31db4d
Merge: 9291e9f00 46ed8bb8e
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 23 19:00:26 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 9291e9f0045780669b2ffa7f08fb10373c03b070
Merge: 2aed64157 2c947f193
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 18 19:03:13 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 2aed64157d6e9dc993d103a2c6abf7e643410562
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 18 19:03:03 2022 -0700
Revert "send pre-enable state when gas is pressed"
This reverts commit 8d82e697dc2efade307413e767d14b56b4d2d079.
commit a219defe5342efa731a957b2ff4fd86292c1f239
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 17 12:50:46 2022 -0700
bump cereal
commit 8d82e697dc2efade307413e767d14b56b4d2d079
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 16 22:40:13 2022 -0700
send pre-enable state when gas is pressed
formatting and it's out
forgot one
allow gas press
show toggle
revert changes
revert changes
commit 5eb4d1ab1b77ac65bdd901f692ebfb848d5187ca
Merge: bad1bdc74 d0ef25959
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 16 22:29:43 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit bad1bdc7428c5d8a4a765b259da504f0ade84424
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 23:03:56 2022 -0700
clean up a bit
commit 7516ed9b786536a07f00a92b9c1742ca252a01d1
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:55:09 2022 -0700
these are null checks right now
commit 408f5f1d633521b29b08d966c9b387fa79dff0d6
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:51:14 2022 -0700
should work
commit be1978e29c03d8843cf073cc9ddf84020fd2b378
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:36:16 2022 -0700
stash
commit f0bd4c47e9d27061c6cd3b88765a7c10995f42db
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:26:24 2022 -0700
this was flipped
commit d5b6e30389a727e8559331acd706422e1b246f60
Merge: 820b19894820b19894991763f9ff91763f9ff4🔥
commit 1885c9e2ba1f591736a1f591736a2465811f0b465811f0b40344363a53700efcb3f700efcb3f4220ce272fed273bb78ac1a85afd60ce3be32afc2f27203af3a04c0ad1a5499cf13caeb2230254ca787475e02cbf1f40c117a
3 years ago
d359310631
alerts: Don't use Malfunction twice
...
old-commit-hash: 8031a68e55
3 years ago
01d005c322
update refs
...
old-commit-hash: a4353303d4
3 years ago
53fff66742
bump cereal
...
old-commit-hash: ca3171c0f9
3 years ago
059dbf57e7
longitudinal MPC: use reset() function instead of recreating the solver in ( #24091 )
...
* scons: add acados_template as dependency for lat and long mpc
* long MPC: use acados reset instead of recreating the solver
* long MPC: print timings and reset commented
* update acados x86_64
* update acados include folder
* update acados Python interface
* update acados reference commit to latest acados/master
* update x86 libs
* update comma two
* update acados again with commit 8ea8827fafb1b23b4c7da1c4cf650de1cbd73584
* update comma two
* update comma three
* update x86
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: a9bac5acf8
3 years ago
d6fb92825b
LongitudinaPlanner: add comment about lateral accel calculation ( #24096 )
...
* space
* if
old-commit-hash: 5a8b4bbcaa
3 years ago
bb9dd45677
Contact Support -> Hardware Malfunction ( #24076 )
...
* Contact Support -> Hardware Malfunction
* missed that one
old-commit-hash: f1719aab84
3 years ago
d42962014c
CarParams: remove max steer ( #24044 )
...
* Remove max steer
* Update ref
old-commit-hash: adf34c3414
3 years ago
b24d669861
Apply EU guideline lateral limits ( #23974 )
...
* Apply EU limits
* Lower bound v_ego
* Add curvature limit comment
* Remove comment
* Update ref
old-commit-hash: 4a8fffd0f4
3 years ago
d8b0684434
Add warning for unsupported NVME ( #23972 )
...
* Add warning for unsupported NVME
* fix it up
* fix typo
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: a6d4bb5d01
3 years ago
f0ece255b4
Improve style in drive_helpers ( #23962 )
...
old-commit-hash: 08c2d066cf
3 years ago
479ac5753c
longitudinal MPC: add MAX_T in T_IDXS_LST ( #23960 )
...
* longitudinal MPC: add MAX_T in T_IDXS_LST
* update refs
Co-authored-by: KexianShen <shenkexian@gmail.com>
old-commit-hash: f1aab78d08
3 years ago
ec47e0fef0
break up selfdrive.config ( #23959 )
...
* break up selfdrive.config
* add to release files
* fix import order
old-commit-hash: 5c3f3e44bc
3 years ago
ClockeNessMnstr
Shane Smiskol
Willem Melching
HaraldSchafer
Adeeb Shihadeh
ntegan1
Dylan Herman
Jason Young
Vivek Aithal
Gijs Koning
Lukas Petersson
George Hotz
Jonathan Frey
Gregor Kikelj