* Parametrize MIN_CAN_SPEED in car interfaces
* fixed instance in planner.py
* fix typo
* var name change
* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files
* added default value to get_std_params, removed unneeded instances from car interface files
* Revert PEP8 autoformat corrections
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Add test routes for CX9 and Mazda3
CX9: "10b5a4b380434151|2020-08-26--17-11-45"
Mazda3: "74f1038827005090|2020-08-26--20-05-50"
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring
Python3 interpreter:
>>> print(" %d %d" % (1.6,1.4))
1 1
>>> print(" %d %d" % (round(1.6),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),int(round(1.4))))
2 1
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Slower rate for ACC cancel msg to avoid cruise disable
Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Round up 27.96 to 28mph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Mazda Port
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update checksum to account for steer angle signal used in some cars
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Add test drive/segment ID to pass CI tests
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Process gear and brake signals, add new fingerprints
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Refactor some car interface code
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop unused variables, cleanup handsoff tracking
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update to steerError and steeringRate
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Refactor parse gear, update lkas signals from the new dbc
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Better tracking of engage and warning events
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* remove commented lines, update speed_kph to match panda
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Steer Error
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Set lkas enable speed to 52 kph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop block signal use, fix LGTM alerts
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* When gas is pressed OP will disengage, sync local state with it
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Use car's speed signal instead of wheel speed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Tidy up disengage events
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Rebase/Refactor with upstream
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Sync stock ACC state with OP
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* mazda dbc file renamed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Improve acc stock and go by removing the 3 seconds limit
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Dashcam
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* PR Feedback
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Send ACC cancel only if we are sure cruise is enabled
Otherwise we run the risk of disabling main cruise
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* updated route
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* no process replay for now
* add to release files
* Revert "updated route"
This reverts commit 233db4f1bc.
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* don't need individual prev state vars since whole CS is copied
* don't need a whole function since toyota alerts were simplified
* better here
* abstract pcmEnable/pcmDisable events
* the flippening came to NEOS
* delete
* unused
* Revert "the flippening came to NEOS"
This reverts commit 91cfb73b29.
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event
* move lines a bit
* more GM cleanup
* typo
* move espDisabled to carState packet
* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed
* ops, wrong change
* bug
* update cereal
* update ref
* too many if
* unused
* whitespace
* key
* sefldrive/car/*
* no more gctx
* lower
* start abstracting common events
* all cars
* start small
* all cars
* reverse gear
* wrongCarMode
* wrongGear
* espDisabled
* steerUnvailable
* make linter happy
* c isn't used
* fix esp_disabled in VW
* update ref
* more red
* more cleanup
* fix subaru
* update ref
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* abstract common instance vars in carstate init and a generic gear parser static method
* abstract gear parser for chrysler
* abstract gm gear parser too
* remove unnecessary random vars
* Chrysler: carstate returns capnp struct directly
* revert ref commit
* test ref
* WIP
* more WIP
* ops, missed this conflict
* ford as well
* not sure why this got deleted
* no need to copy
* remove copy
* remove copy import
* remove unnecessary intermediate variable
* remove obsolete comments
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Igor
Adeeb Shihadeh
Jafar Al-Gharaibeh
Adeeb
Willem Melching
Adeeb
rbiasini
George Hotz