* Emit correct alerts for LDW Left & Right on Subarus
This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash
* Remove whitespace, and add comment about not overwriting stock alerts
Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
* cancel is never true if cruise isn't enabled and pedal
* This is probably better
* comment
* want to see if this fails
* see what Actions says about this
* nice! just as a sanity test real quick
* Revert "nice! just as a sanity test real quick"
This reverts commit 2d86d1c32e.
* Revert "see what Actions says about this"
This reverts commit c908488854.
* Revert "want to see if this fails"
This reverts commit 2d515f3721.
* specify the fix
* No bitwise
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* pre-reqs for honda bosch longitudinal control
* openpilot_longitudinal_control -> radar_disabled
* fix chrysler test
* review feedback
* little cleaner
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* abstract common instance vars in carstate init and a generic gear parser static method
* abstract gear parser for chrysler
* abstract gm gear parser too
* remove unnecessary random vars
* Chrysler: carstate returns capnp struct directly
* revert ref commit
* test ref
* WIP
* more WIP
* ops, missed this conflict
* ford as well
* not sure why this got deleted
* no need to copy
* remove copy
* remove copy import
* remove unnecessary intermediate variable
* remove obsolete comments
* GM: have carstate returning capnp struct directly
* Honda carstate also outputing capnp struct
* hyundai too now returns capnp from carstate
* ops, not meant this
* Subaru carstate also returning capnp
* Toyota: capnp struct as output of carstate
* fix bool
* minor simplififcation in Honda
* no need to negate
* VW carstate returning capnp struct (#1118)
* VW carstate also returning capnp struct
* fixed typo
* Remove unused blinker button (#1119)
* remove unused blinker button
* ops, this wasn't meant
* remove blinker button for VW as well
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
CrispinFlowerday
ShaneSmiskol
Willem Melching
Adeeb Shihadeh
Greg Hogan
Chris Souers
Adeeb
rbiasini
George Hotz