Shane Smiskol
5ed587ebef
controls: block resume if cruise not previously engaged ( #25402 )
...
* see if this works at all
* can revert this
* think adding a no entry conditionally is nicer
* then we can revert this
* 0 makes more sense
* Revert "0 makes more sense"
This reverts commit efc89e8a23
.
* gm CC uses > 70
* bump cereal
* comment
* test on Honda
* whoops
* works
* add exception with todo
* moved button enable events to controlsd
* get rid of that
get rid of that
* different values for now
* car interfaces add enable event, controlsd can block it
* Regen and update refs
* delete if not set
* One place
one place
* regen routes are uninitialized first few frames
* Trim start of segment so it's like original segment
* stash
* regen
* not working
* clean up
* more cleanup
* revert
* bump ceral
* actually check resume button
* whoops
* pcmCruise cars don't use setSpeed, so we're good
* engage correctly in sim
* Update ref_commit
* Update refs
3 years ago
Vivek Aithal
f1fecc3da7
Sensor Invalid Alert ( #25303 )
...
* modify text, add soft disable
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
Adeeb Shihadeh
278d6893fe
less beeps for steering override faults ( #25196 )
...
* less beeps for steering override faults
* less repeat
3 years ago
Willem Melching
d4cc13c88a
controlsd: avoid lag on first iteration due to get_short_branch ( #25031 )
...
* controlsd: avoid lag on first iteration due to get_short_branch
* always cache
3 years ago
Adeeb Shihadeh
0fce5d9045
Move a bunch of stuff to system/ part 3 ( #24829 )
...
* move swaglog.py
* timezoned
* logmessaged
* version.py
* fix linter
3 years ago
Willem Melching
f49a9c9fd2
less TICI when not needed ( #24698 )
...
* less TICI when not needed
* fix process replay
* move reading voltages into hw abstraction layer
* Update selfdrive/hardware/tici/hardware.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/hw.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/base.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* rename init function
* Update selfdrive/athena/athenad.py
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
* Update selfdrive/boardd/boardd.cc
* Apply suggestions from code review
* Update selfdrive/thermald/thermald.py
* update ref
* fix alert width if all cameras are bad
* add ecam to test_loggerd
* bump cereal
* bump cereal
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
3 years ago
Adeeb Shihadeh
71901c94db
controlsd: ensure all system malfunction events have the right types ( #24635 )
3 years ago
Adeeb Shihadeh
0b1f6e3620
show which cameras are malfunctioning ( #24558 )
3 years ago
Adeeb Shihadeh
b1858df00e
improved alert verbosity ( #24434 )
...
* improved alert verbosity
* better testing script
* better description
* speed diff
* touch ups
* fix that
3 years ago
Shane Smiskol
961a121fde
Round system overheated temperature ( #24544 )
...
* Update events.py
* Apply suggestions from code review
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
ntegan1
076f0acd5f
Round model lagging frame drop percentage ( #24549 )
...
alerts: round model frame drop percentage
3 years ago
Dylan Herman
d2eef1955c
add mypy check for return-any ( #24379 )
...
* add mypy check for return-any
* remove unused import
* typing
* remove unnecessary variable typing
* cleanup
* cleanup
* bump submodules
* small fixes
* only a problem on mac
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
Adeeb Shihadeh
3abbe827de
controlsd: add lagging alert ( #24360 )
...
* controlsd: add lagging alert
* move those
* just this for now
* no camera malfunction
3 years ago
Adeeb Shihadeh
70987fd9d9
more verbose debug alerts ( #24126 )
3 years ago
Adeeb Shihadeh
233a167cc9
controlsd: handle controls mismatch race ( #24245 )
...
* controlsd: handle controls mismatch race
* update refs
3 years ago
Gijs Koning
e0845752e3
Fix camera error description ( #24202 )
...
* Fix camera error message
* Shorter
3 years ago
Adeeb Shihadeh
49c2164814
add alert for CAN bus timeout ( #24162 )
...
* add alert for CAN bus timeout
* add alert
* set in interface
* cleanup
* cleanup
* add event
* fix mock
* bump
* bump opendbc
* update refs
* return reader
3 years ago
Adeeb Shihadeh
162e47456c
bump cereal
3 years ago
Willem Melching
fb344021aa
update camera CRC alert text ( #24156 )
3 years ago
Willem Melching
1848050fd9
add cameraFrameRate alert ( #24152 )
...
* add cameraFrameRate alert
* bump cereal
3 years ago
Willem Melching
eaa5819211
commIssueAvgFreq: separate alert for avg freq check ( #24150 )
...
* commIssueAvgFreq: separate alert for avg freq check
* bump cereal
* bump cereal
* bump cereal
* freq_ok separate from alive
* bump cereal to master
* update_ref
* fix profiler
3 years ago
George Hotz
8031a68e55
alerts: Don't use Malfunction twice
3 years ago
Shane Smiskol
a4353303d4
update refs
3 years ago
Shane Smiskol
ca3171c0f9
bump cereal
3 years ago
Adeeb Shihadeh
f1719aab84
Contact Support -> Hardware Malfunction ( #24076 )
...
* Contact Support -> Hardware Malfunction
* missed that one
3 years ago
Adeeb Shihadeh
5c3f3e44bc
break up selfdrive.config ( #23959 )
...
* break up selfdrive.config
* add to release files
* fix import order
3 years ago
Willem Melching
14260c01c6
process replay: fix branch name alert ( #23783 )
...
* env is modified after start
* update ref
3 years ago
Adeeb Shihadeh
f59adbeaaa
keep the new alert consistent for process replay
3 years ago
Adeeb Shihadeh
ff965c772b
add branch name to startup master alert ( #23782 )
...
* add branch name to startup master alert
* still orange
* update refs
3 years ago
Willem Melching
8effa2d878
hide localizerMalfunction alert ( #23730 )
...
* hide localizerMalfunction alert
* update ref
3 years ago
Jafar Al-Gharaibeh
1c31c9b7a3
Mazda: alert when LKAS is disabled ( #23288 )
...
* Mazda: alert when LKAS is disabled
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* update refs
* revert that
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
Adeeb Shihadeh
3e9cb7fa12
remove community features toggle ( #23214 )
...
* remove community features toggle
* bump cereal
* little more
* update refs
3 years ago
Dean Lee
a186bcc9f1
cleanup iterate keys in dictionaries ( #23497 )
3 years ago
Dean Lee
a653461dec
check in tuple instead of list ( #23477 )
...
* check in tuple instead of list
* Update selfdrive/car/toyota/carcontroller.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Update selfdrive/car/mazda/interface.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
Dean Lee
8eec818ae6
events: cleanup function any ( #23479 )
3 years ago
George Hotz
dc96d4bee7
Add More Types for mypy ( #23268 )
...
* mypy passes
* a few more
* a few in manager
* more types, will lint
* more
* simple types
* events type
* Update selfdrive/thermald/thermald.py
* Apply suggestions from code review
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
Adeeb Shihadeh
256c51e16a
bump cereal
3 years ago
Adeeb Shihadeh
c92199ab1a
Revert "Mazda: alert when LKAS is disabled ( #23273 )"
...
This reverts commit f25121b736
.
3 years ago
Jafar Al-Gharaibeh
f25121b736
Mazda: alert when LKAS is disabled ( #23273 )
...
* Mazda: alert when LKAS is disabled
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update selfdrive/controls/lib/events.py
* Update selfdrive/car/mazda/interface.py
* bump cereal
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
Adeeb Shihadeh
8068df0b2a
alerts: escalate soft disable alert near disengagement ( #23198 )
...
* alerts: escalate soft disable alert if resulted in disengagement
* show 0.5s before disengagement
3 years ago
Adeeb Shihadeh
07b971d473
alerts: handle min duration properly ( #23191 )
...
* alerts: handle min duration properly
* add active
* tests
* cleanup test
* update refs
3 years ago
Adeeb Shihadeh
4627d201b6
alert text simplification ( #23186 )
...
* alert text simplification
* little more
* user triggered
* little more
* less annoying ldw
* Update selfdrive/controls/lib/events.py
* update refs
* revert
3 years ago
Adeeb Shihadeh
3b367e6872
Newer sounds ( #23091 )
...
* new prompt sound
* padding
* prompt distracted
* debug
* fix spelling
* lower min volume
* better volume at low speeds
* revert debug
* revert that
* fix tests
* update refs
Co-authored-by: Comma Device <device@comma.ai>
3 years ago
Adeeb Shihadeh
e679d05d9e
New sounds ( #22652 )
...
* new engage/disengage + amp config
* first family
* cleanup audible alerts
* tici isn't special
* fix up debug cycle alerts
* these were better
* extend range
* use distracted sound
* log scaling
* getting closer
* slightly louder
* prompt
* update tests
* update refs
* fix c2 test
* resolve todo
* adjust tolerance
* revert for now
* should work
Co-authored-by: Comma Device <device@comma.ai>
3 years ago
Adeeb Shihadeh
5296ca8d73
improve crc camera error ( #22943 )
3 years ago
Adeeb Shihadeh
833399e941
alerts: make soft disables an orange alert ( #22925 )
3 years ago
Adeeb Shihadeh
3302239013
put cruiseMismatch event in logging only mode
3 years ago
Adeeb Shihadeh
5265c36de7
alert cleanup ( #22919 )
3 years ago
Adeeb Shihadeh
308219c5b1
alerts: use repeating warning2 sound for steerSaturated ( #22874 )
4 years ago
Adeeb Shihadeh
327464fb84
increase engagement alerts duration
4 years ago