Today, Firehose uploads and user-requested uploads from Connect are treated the same. This is not ideal behavior if the user wants to upload routes immediately for a bug report and the queue is full of uploads for Firehose. The workaround is to clear the queue and retry the upload from Connect.
This PR adds an optional `priority` to requested file uploads in `athenad`. By default, all requests are marked `Low`. However, if the caller wishes to mark their uploads as "more important," then the upload queue will prioritize those requests when uploading.
The only caveat to this PR is that we won't reorder files currently being uploaded. Most connections are quick enough to finish uploading max 4 files before polling the new high-priority items in the queue.
Closes https://github.com/commaai/openpilot/issues/34836
**Verification**
Added test case to insert upload tasks with differing priorities. Polling the queue produces items in the correct order (smallest # to largest).
PR to mark Connect uploads as high priority: https://github.com/commaai/connect/pull/557
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
* Add previews for new ui elements as well
* Actualizar ui_preview.yaml
Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
---------
Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
* temp unavailable
* fix
* replay multiple
* clean up
* bump
* rename
* reason is in liveTracks
* more rename
* bump
* fix
* bump
* fix
* need to totally ignore it, or it will throw commIssues for radarErrors or not alive
* this is just simpler -- good thing kept struct
* rm
* bool fields
* liveTracks.valid is already set using errors
* fix
* clean up
* same but diff
* fix
* fix
* fix test
* clean up
* rm radarErrors
* whoops
* no struct
* Revert "no struct"
This reverts commit ed8ec02493.
* bump
* update
* always check radarState freq since it polls on modelV2 and sends at a fixed rate
* fine
* can just check this since valid is all_checks on liveTracks, and liveTracks.valid is len(errors) as well
full circle
* Use uncalibrated values
* Use calib_valid
* Move valids together
* Add calibration valid field
* Add migration block for new field
* No paramsdTemporaryError while calibrating
* comment
* Fix static issues
* Update ref commit
* Comment
* Remove redundant field
* check for calstatus in selfdrived
* Remove comment
* Update ref commit
Shane Smiskol
Dean Lee
Lee Jong Mun
Trey Moen
commaci-public
github-actions[bot]
programanichiro
Maxime Desroches
DevTekVE
Adeeb Shihadeh
eFini
Kacper Rączy
royjr
Alexandre Nobuharu Sato