* add function signature and behavior comment
* add test
* move chassis codes to platform config!
* add a shared chassis code test
* function
* test matching
* this commit isn't complete yet
* Revert "this commit isn't complete yet"
This reverts commit ae77d5cd54.
* need to check WMI
* TODO: test WMI
* test wmi
* radar FW sanity check
* fix test
* fixes from merge
fixes from merge
* whoops
* fix static analysis!
* do match_fw_to_car
match_fw_to_car takes vin
* makes sense to keep it one function, and we can return exact or fuzzy!
* clean up
* kinda pointless
* fix more tests
* back to function being only fuzzy
* revert test_fw_fingerprint
* revert test_fw_fingerprint
* simplify
* clean up/fixes
* rename test
* less duplicatey WMI descriptions
* fix
* convert to enum
* I am confident about these WMIs
* these are also good
* we support 5N AUS/NZ and NAR (North American) AX Tiguans
fixes
* Tiguan also Mexico
* only one user for caddy
* got from the test route
* check that the gateway type matches the platform (each platform has 1 or 2 types)
* ~gateway~ -> exact FW match
* remove re
* ensure WMIs are set
* actually no reason to delete
* move comment up to the platform config
* proper wmis typing
* spacing
* flip
old-commit-hash: 6acf763db4
* start typing
* fixes
* we only plan on using this for lists
* sort
* this is the correct way to type it
* it knows this!
* it's getting smarter
old-commit-hash: 74ec33f7c7
* bump
* from https://github.com/commaai/openpilot/pull/27929
* get VIN on bolt!
* might as well try on other gms
* remove vin
* ugh gm is going to be slow
* fix
* should really fix this
* revert
* happy?1
* fix unit test
* bump
* functional addressing must be an OBD gateway feature, this does nothing
* fix vin response
* fix addr!
* finally fix fw_versions bugs since boardd IsOnroad refactor
* for
* only bus 0
* clean up
* Update selfdrive/car/gm/values.py
* ChatGPT re-write
* filter out did
* todo
* oof
* preview: what multiple DIDs per ECU would look like in the future
* Revert "preview: what multiple DIDs per ECU would look like in the future"
This reverts commit 88f0d8611e.
* function to get all ecus
* we can remove this!
* can also do this!
* and this one too :o
* consistency
* yay
* add tests
* revert GM stuff
* another PR
* reads better
* revert rest of gm
* use that
* interesting
* these are exactly the same (with ordering differences)
* Revert "these are exactly the same (with ordering differences)"
This reverts commit a9e918dc35.
* flip
old-commit-hash: 2c0f7b8727
* bump
* gm vin
* that's not right
* only check relevant buses
* instead try queries for each bus first
* clean up
* use default retry in function
* all
old-commit-hash: c3fcf75737
Revert "FW query: query one sub-address in parallel (#28675)"
This reverts commit 3d4c32284699dfd4f78bb2f5bb645344c98f1b46.
old-commit-hash: 365bdd3422
* put one subaddr in parallel_addrs
* p
* remove print
* update test refs
* test
* revert test changes
* do same in present ECU query, lower threshold to catch (~0.82 to ~0.72 right within bounds)
* type
* clean up
* update test ref
old-commit-hash: 861ceb2fee
* pass in brand
* needs to be flipped for exact matching since it's subtractive
* new helper
* makes more sense flipped
* clean up
old-commit-hash: f5a361a111
* debugging
* this test works, but find a better place
* make test more generic to start testing more than timings
no need to run again in another test function. eventually we
can simulate ECUs and have IsoTpParallelQuery work properly
* Revert "make test more generic to start testing more than timings"
This reverts commit 58e8536b1d.
* 2nd try
* clean up
* not even MappingProxyType works
* works
* test that too
* clean up
* refactor to avoid modification online
* revert tests
* more revert
* no longer needed
* clean up
old-commit-hash: 56614124f0
* get gas/ev/hev from FW (not all correct, poc)
* add test for essential ecus for fuzzy fingerprinting
* kinda works
* stash
* clean up
* add code
* simpler
* use the function
* test it with our cars
* no re
no re
no re
* debugging
* handle empty dict
* simpl
* this is promising
start on making existing fingerprinting functions use the config, instead of entirely replacing them
* needs to allow 1 match
* lay out how this should look
* changes
* executable
* some work
* use config
* fuzzy ecus
* config test
* comment and some clean up
* test platform codes
* use regex, simpler and fixes bug
* in func
* rm bad func
* typing for new func and remove old from dc
* todo done
* tested!
* remove fake platform codes
* thought we needed this, but actually...
* not needed
* not applicable any more
* use config for essential ecus
* first draft of test to make adding/removing fuzzy FP platform intentional
* compile
* clean up test
* even cleaner
* fix default ecus type
* temp fix
* this is mostly in tests now
* test every fuzzy ecu fw returns one platform code
* experiment with dates
* Revert "experiment with dates"
This reverts commit 3251b9cc5c.
* clean that up
* comment
* test
* work on all cars
* fix fuzz_fw_fingerprint
* comment
* get first by search
* bit more clean up
* and more
* use compiled pattern for nicer syntax
* default
* flip dat around, much cleaner
* clean up hyundai test a bit
* flip order
same here
* rename test and flip subTest
* fix pylint
* revert fw changes
revert fw changes
* line
* add original functions to test
* needs to be a list
* cmt
* draft (need to count one ecu as a match)
* tiny clean up
* todo: date range
* only in notebook
* remove comment (still can be either list or set)
* same, only notebook
* more consistent signature
* copilot inspired
* copilot no good
* test for date parsing
* better name
* good, now we don't have to worry about the dates mismatching in another test/logic
* comment up+
* some stuff
* clean up
fix test
fix test
* test
* comment
* use utils
* clean up (utils are cleaner and less buggy)
* clean up (utils are cleaner and less buggy)
* fixup test
* use a dash (prettier) and remove some platforms that can fingerprint now!
* compile global pattern
* same as what we do in values
* remove comments
* fuzzy_get_platform_codes is one or none here
* more clean up
* sort imports
* woah woah woah
* add comment
* fix reassigning different types
* add types
* adapt fuzzy test recently added (nice it caught this!)
* update lock
* options
comments
* stash
* comments and fixes
* better comments
* better
* test: run on exact fuzzy matching logic, same results!
* use match_fw_to_car
* test all fw
* ex
* unused random
* this is a possibility
* this is more clear
* fix
* revert
* revert to needing both ECUs to match to reduce false positives, test
* fix excluded platform test :( but it's ok
* add comment
* we actually want to only test fuzzy ecus to make it explicit
* fix mypy
* comment for tomorrow
* just add matches with fuzzy FP
* add comment
* this was the cleanest I could think of, but still working on it. not very easy to understand
* think this is better, but also worse...
* comment: reframing how this works
* revert back to what we did before
* was swapped
* else set
* remove old comment
* fixes from merge
* remove fuzzy_min_match_count from this pr
* fix static analysis
* also unused
* different method first draft
* copy existing fuzzy func
* check all possible ecus exist, only platform codes, slightly refactor main loop
* fix
* Revert recent
Revert "fix"
This reverts commit 5cdb7bda83.
Revert "check all possible ecus exist, only platform codes, slightly refactor main loop"
This reverts commit d3e918fa20.
Revert "copy existing fuzzy func"
This reverts commit 34c8c05450.
Revert "different method first draft"
This reverts commit b91139055d.
* new func
* fixup test
* remove changes from v1 from fw_versions.py
* clean up a bit
* return part as part of code
* fix test
* add original fuzzy function
* add an ecu match if the date is within range (or date doesn't exist)
* add format for what we're going to do
* not working stash
* the exact matching function does more of what we want with less code and less custom logic
* we don't care about found versions, only codes and dates
* actually we do have an exception
* this works pretty nicely now
* up here
* this is better
* some minor clean up
* old function=now junk
* fix platform code test
* remove old platform code function
* now rename _new to
* use FW_QUERY_CONFIG
* clean up imports
* rename that too
* one line
* correct typing
correct typing
* draft tests
* so that works
* fixup excluded platform test now too
* this is tested by excluded platform test
* test parts and dates
* remove old comment
* old import
* take platform code stuff out of FwQueryConfig
* fix test
* revert debug script
* flip order
* make this a set by default
* revert this part
* correct typing
* clean up comments
* clean that test up too/pylint
* combine these three tests ina clean way
* not right
* more general
* be consistent with quotes
* comment
* comment
* comment in fw_versions
* flip order
* this is more readable
* could test all this, but it's tested in test_hyundai and doesn't do a lot here
* only assert brands which use this
* invalidate all CAN FD ICE and hybrid
* tuple
* can get away without filtering
* add comment reasons
* fix
* some review suggestions
* this works (first draft)
* this is better
* script to print platform codes and dates
* sanity check for dates are in correct ecus and platforms
* mypy
* better variable name and comment
* rename
* same
* slightly better name
* subset
* exclude platforms and live car without dates
* consistent
* self explan
* better name
* test to make sure the functions agree
* clean that up
* comment
* we get other responses from queries not in DB, only check any
* not used or typed
old-commit-hash: f788edb6a5
* first attempt trying to do it implicitly bad
* back to lists and explicitly do this
* continue checking if candidate switches on these, that's fine to check
* debugging
* clean up
* more clean up
* spot free
* only need to create/update on change
* fix test
* draft
* Revert "draft"
This reverts commit dbe32f58b1.
* Revert "fix test"
This reverts commit 1d34269fe2.
* fix test for real
* first draft of test
* this should be good
* can replace existing fuzzy test
* rm
* matching
* test non-empty fws
* TEST DOWN HERE
* no test
* unique + fix skip message + comment + clean up
* less confusing
* ing
* better
old-commit-hash: 9e8936be98
* pass in brand
* needs to be flipped for exact matching since it's subtractive
* new helper
* makes more sense flipped
* clean up
* not that stuff here
* not here
old-commit-hash: 2b07ec4bde
* speed up fingerprinting for CAN fp cars
* add comment to describe this behavior
* more explicit, no defaultdict
* do this later
* fix
* a little more clear I think
old-commit-hash: 9b1095a27e
* query extra ecus (still need to match)
* match against extra ecus
* clean p
* clean p
* switch that around
* can clean that up
* values
old-commit-hash: 6f35d23c06
* query extra ecus (still need to match)
* match against extra ecus
* clean p
* clean p
* switch that around
* can clean that up
* values
* rm
* not used
old-commit-hash: 084e83cda1
* indecisive
* rename to generic FW query
* remove code and update comment
* we need this to start off, unless we set multiplexing immediately
* draft
* draft 2
* try that
* can't do this either, boardd might read Enabled after removing, but before setting new Request param
* this should work
* use one less param
* fix params
* match behavior (set all pandas to safety param of 1, disabling multiplexing for fingerprinting
* clean up (some tests may temp break)
* fix param name and sort
* time it
* yes it does matter
* add to hyundai's bus 5 query
* remove hyundai for now
* this should work
* clean up
* clean up
* flip argument around, clean up
* fix test_startup
* some clean up
* rm line
* comment makes more sense
* required typing
* clean up common type
* comments
* Update selfdrive/car/car_helpers.py
* line
* whoops, need to set before vin!
* fix debug
* annoying
* more debugging
* bug fix (needs both keys always)
* debuGG
debuGG
* Revert "debuGG"
This reverts commit 55b2f42932.
* Revert "more debugging"
This reverts commit 02934c3403.
* Revert "annoying"
This reverts commit 8b4e5e0998.
* clean that up
* bumpback
* bumpback
* every second write param
* flip
* stuff
* move up?
* fix timing out in CI
* rm
old-commit-hash: 42449b482d
* add flag
* actually use in fw_versions.py
* simpler
* not here
* Comment
* better name
* add param and block
* keys
keys
* block
* with a value
with a value
* add query for bosch PT bus
* different name
* fix
* .
* fix test
fix test
* add cloulogs
* mark as logging
old-commit-hash: c4b84783a0
* log responses from logging/debugging queries
* don't add logging FW to FW dict for fingerprinting
* flip?
* fine before
* log if extra in debug ecus
* clean up
* test extra ecus too
* Revert "test extra ecus too"
This reverts commit 8f7867844d.
* bump to master
old-commit-hash: f29e19cf42
Adeeb Shihadeh
Shane Smiskol
Cameron Clough
Justin Newberry