* Revert "GM: Fix noisy brake pressed (#23712)"
This reverts commit dd76cfcf28.
* keep this
* same check, but don't clip CS.brake
* bump panda
* bump panda to master
* Add harness information
* test harness enum
* add harness info for tucson
* update Tucson harness
* get rid of development
* make global enum
* fix
* add harness info
* add harness info to CARS.md (since we need multiple lines per HKG platform)
* revert this
* Actively Maintained means something! (aka, to bronze with select VW)
* fix caravelle
* add harness tooltip on maintained column
fix
* lol tubaru
* always assume harness
* update honda harnesses
* add Ioniq hybrid 2017-19 harness, todo: not sure
* unused import
* hmm, did they really switch to the C for 1 year??
* add comment
* add comments
* adding tooltips should be fine
* fix santa fe harness
* welcome back, vw
* no need for two harness strings
* seems fine
* fix 19-20 Niro EV harness
* these were taking from old database, so assume correct
* could be d
* pass all car info into template
* no more tool tips
* these use j533 harnesses
* accidentally got removed in merge
* also merge issue
* don't need these
* make harness non-optional
* do tesla
* parentheses
* Do Chrysler
* Make sure Hyundai long never actuates when long inactive
.
* clean up Hyundai
* more clear
* formatting
* Stock sets these to zero
* fix params
* move jerk logic into CC
clean up
* add vehicles.vue template
* add original vue file
* stash
* stash
* clean up a bit
* add template for now
* implement footnotes and tier copy
* no more generator
* convert to 2 spaces
* should work, now onto vue
* does GH handle this html well?
* fix
* auto-generate descriptions and make tiers' maps non-str
* remove old files
* move template specific variable into templates, should be a bit simpler
* js template is simplier too now
js template is simplier too now
js template is simplier too now
* add video links from the nice car_info
* make rows attributes
* clean up
* fix
* remove template
* experiment with video links in GH
add image
how does this look?
fix
* Revert "experiment with video links in GH"
This reverts commit 8375e717b5.
* sort tier_car_info in place
* unused Tuple
* no type check
* fix script
* make CAR class enum, and values.py formatting
* Revert "make CAR class enum, and values.py formatting"
This reverts commit 04d9817e9d.
* stash
* add supported packages and model years
* don't change model years in fps
* move Lexus to info dict and make int enum
* remove sometimes wrong model years from name string
* use enum names
* convert Honda's values
* nice names
* use name
* GM
* Mazda, Ford
* Hyundai: WIP
* finish Hyundai
* fix
* Nissan
* Subaru
* Tesla
* formatting is for another PR
* Chrysler: todo: unify the Pacificas?
* do volkswagen
* this isn't a zoo
* skip enums for now
* Update selfdrive/car/volkswagen/values.py
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
* set All
* temp cars
* auto-generate CARS.md
* update type hinting
* add generated file
* add longitudinal star to cars that support disabling radar
* add TODO
* add notes
* add min_steer_speed exception for hatchback
* add minimum steering speeds
* Add exceptions and run generator
* Missing Telluride
* fix Prius v
* missing Prius Prime
generate
* start to convert years to strings
* Fixup Hyundai
* convert year sets to strings
* handle this
* missing S3
* Fix and add all missing cars (verified with script
* Supported Package fixes
* add get_tiered_cars
* Check radarOffCan for removing most Honda from op long
* Update for Avalon stop and go update on master
* Fix missing car params
* add my temporary script i'm using to verify new generated DBC
add my temporary script i'm using to verify new generated DBC
* generate with jinja template
* add header and footer
* clean up
* rename
rename
* add exceptions. jinja is nice, but why are its loop indexes starting at 1?
* add list of known car videos
* See how these look
* Add nice table formatting for column description
Add nice table formatting for column description
* generate
* consisten br tag
* small clean up
* temp
* Move car videos into CarInfo
* add new copy and rename to footnotes
* Revert "temp"
This reverts commit 93c3fce1d3.
clean up
* generate
* replace with svg
* simplify a bit
* add footnotes to CarInfo
* move some variables to docs.py
* Add video link for Acadia
* Make Footnote an enum so we don't use random ints
* static analysis fixes
* move to CARS.md
* fix last missing footnote
* add to release files
* rm test file
* use svg
generate
* fix sorting
* not needed
* not sure how this got here
* remove Sedan/Couple and add Diesel footnote
* finish todos
* move make specific footnotes to selfdrive/car/*/values.py
rename
* change to zeros
* align bottom to center
* Apply some suggestions
* Update selfdrive/car/mock/values.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update copy
* Try headers + bullet points
* somehow better
somehow better
* finish updating copy
* move template and add links to sups
* stars shouldn't be clickable
that didn't work
try this
try this
this is better
* add type hints to CarInfo
add more type hinting
* optional needs a type and any covers all (?)
* move good steering torque to */values.py
* dataclasses are much nicer than attr
* use tuple
* Update docs/cars.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* suggestions
* suggestions
* suggestions
remove
* clean up a bit
* add more type hints
* center stars and remove hardcoding from template
* update copy
* Add test
* Fix types
Fix types
* add supported cars documentation test
* clean up
* replace with docs_definitions
* Add back Footnote enums
* Ah so these are like fstrings!
* Update selfdrive/car/CARS_template.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/car/docs.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update year from master merge
* Fix longitudinal star from merge
* sort properly stars by Column enum
* clean up
* HKG: Sorry guys
* Prius V gets FSR star, like others
* Update selfdrive/car/docs.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* update comment
* No Prius docs change for now
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* proof of concept
* actuators packet describes which actuators are active
* bump cereal
* fixes
* not needed for this PR
* Do Toyota
* add back controlsState.active
* bump cereal
* rest of cars
* in actuators
* add active back
* which
* use controlsState.active for now
* will make an issue
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* move local lat_active checks into CC.latActive
* remove redundant checks
* move comment
move comment
* fix joystick mode
* get enabled from carcontrol
* do standstill check in controlsd
* make sure we consider the gas press case for GM
* use CC.actuators
* fix
* capitalization
* Bump cereal
Bump cereal
* make intermediate actuators
* similar convention to before
* clean that up
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* GM: Use ECMEngineStatus.Brake_Pressed
* consistent style
* add TODO
* bump panda
bump panda
* it should
* bump panda
Co-authored-by: Jason Shuler <jshuler@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* check in tuple instead of list
* Update selfdrive/car/toyota/carcontroller.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Update selfdrive/car/mazda/interface.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default
Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
* GM Acadia lateral tuning
* old tune was not returning to center, nor strong enough. Trying to make P and F equal.
* reduce integral, and eyeball actuator delay
* return PI to openpilot default
* remove default values from acadia
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
* Added 2016 Escalade ESV fingerprint and data.
* Updated CARS.md for GM vehicles
* Uploaded Escalade fingerprint
* Removed part about auto high beams for GM. Seems to work for some.
* Revert other modifications in CARS.md
* Revert other modifications in CARS.md
* Added test route for Escalade
* Added tunning for Escalade to reduce jerky steering
* Apply suggestions from code review
* Update selfdrive/car/gm/interface.py
* cleanup test route
Co-authored-by: Gibby <git@twoitguys>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* GM Volt lateral tuning and feedforward function
* improve comments, lower P 5% to 0.17, which matches all my notes over time, 0.18 was a last test change.
* don't justify actuator delay for now
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* use ISO 15622:2018 limits in PID controller
* allow more for nidec
* limit PID inputs
* CP is not needed
* add GM
* not used
* update ref
* fix honda bosch
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Emit correct alerts for LDW Left & Right on Subarus
This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash
* Remove whitespace, and add comment about not overwriting stock alerts
Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
* steer temp unavailable should be a soft disable
* no mute
* these should be no entries
* sound
* better name
* deprecated
* make vehicleModelInvalid a soft disable
* update refs
* bump cereal
* bump cereal
* update refs
Shane Smiskol
Adeeb Shihadeh
Dean Lee
kevinharbin
Ewout ter Hoeven
Willem Melching
Dave
Jason Young
Gibby
qadmus
Robbe Derks
HaraldSchafer
Greg Hogan
CrispinFlowerday