* fix runaway set speed for GM
* fix runaway set speed for GM
* Handle resuming to exit standstill generically
* clean that up
* ugh i want to fix all the formatting
* class that manages v_cruise
* better name
* move around
* add depressed_state
* fine to update on pressed change, better name
* cmt
* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge
* no defaultdict
* log signed speed
* bump to master
* need this
* fix
* fix...
* see if this works
* just fault fix (no logging or standstill. tho revisit standstill)
* move
* Revert "move"
This reverts commit c564e74666.
* put gm camera voacc behind disable radar toggle
* bump panda
* bump panda
* bump panda
* experimental long
* fixes
* car control notes and fixes for Bolt EUV
* might enable stop and go
* consistent name
* min enable speed seems to be around 5 kph
* camera acc can engage under 5 kph if stopped
* comment
* comment
* remove this for now
* only real brake
* comments
* update max brake
* bump
* clean up/fix
* same if
* simplify
* fix
* old comment
* no brake_pressed
* temporary fault fix
* tune longitudinal
* update docs
* bump panda
* GM camera ACC cars have no regen in ACC
* cleaner
* cleaner
* fix
* set max gas
* fixes
* fix LKAS unavailable warning from camera
* only camera
* bump panda
* bump panda
* bump panda
* bump panda
* clean up gmcan
* clean up CC
* flip
* rm
* rm comment
* clean up
* custom starting/stopping probably not needed
* Update selfdrive/car/gm/carcontroller.py
* fix crash
* long tuning
* we need long control state to resume
* CAMERA_ACC_CAR not needed
* no interp on accel
* tuning
* formatting
* formatting
* formatting
* formatting
* formatting
* no need to init ccp
* makes more sense now
* fix the fault more generically
* fix
* need this
* some clean up
* comment and use standstill
* comment
* add comment
* better fix
* rm
* better (for now)
* update docs
* prevent bolt fault
* comment
* only for camera ACC
* fixup alert
* bump cereal to master
* use new name
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* Update selfdrive/car/gm/interface.py
* only care about prevent engagement when we look at PCM
* Chevy Bolt EV w ACC Port
* dashcam
* The website allows you to select the package without ACC
* fix Bolt E(U)V centerToFront
* Update selfdrive/car/gm/values.py
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Chevy Equinox Port
* LKAS is not standard on 2019, but it's the same package as ACC. (LKAS standard 2020+)
* 2019 here too
* clean up
* add to untested
* not in docs
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* single longitudinal toggle for e2e and disable radar
* write disable radar param
* rename
* better param name
* clean that up
* update refs
* update translations
* not live for experimental
* write it out
* vanish
* Move auto resume in sng to car interface
* Update docs
* shorter name, star
* order
* resumes?
* add hidden detail sentence
* good to know this works, but revert
* VW auto resume
* bump cereal to master
* Update ref_commit
* match cereal
* try this
* ?
?
* like this
* Silverado support
Co-authored-by: Jason Shuler <jshuler@gmail.com>
* Update docs
* Try 2 m/s/s
* Should be good torque values
* Add Silverado test route
* Add to releases
* Send counter
* can't send multiple or it faults
* Send at 33hz, no counter
* try 25hz, don't line up exactly with car's buttons
* never tried 10hz with same counter
* Update selfdrive/car/gm/gmcan.py
* Make same as pcmCruise branch
* update year and package (different packages needed per-trim)
* Update year in releases
* Revert to 21
* We can use this package name again
* wrong one!
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Switch to ECMPRDNL2 for GM gear
* Removing manumatic gear #
* values.py almost complete
* Silverado and Bolt EUV val and CP
* GM controller updated
* Cam hrns supp done (in theory)
* cleanup for new cars
* Remove extra constant
* WS, etc cleanup
* removing the unused
* Fix kpBP typo
* Updated docs
* Skip's PIF tune
* Dropped LKA CAN error patch
* Add silverado sigmoid ff
* CAN Err & LKA latch patch
* Remove EPS fault fix (another PR)
* Remove Silverado (another PR)
* clean up some common params
* Remove Escalade FP
Remove Escalade FP
* comment
* Premier is just a trim
Premier is just a trim
Premier is just a trim
* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera
* clean up
clean up
* bump panda
* bump panda
* bump panda
* bump panda
* bump panda
* remove comments
* try spamming buttons on bus 2
* bump panda
* bumping opendbc w btn rc
* not needed for this port
This reverts commit 6af1f0ba79.
* add button safety
* Send next rc when spamming btns
* forward other signals in message
* missing DriveModeButton
* fill cruiseState.speed
* see if resume works without counter
* try the whole message
* send immediately and at 10Hz
* no resume, back to just button signal
* even holding random buttons it cancels
* Use torque controller with base tune
* stock long GM don't auto-resume yet
* Testing GM zero min steer speed
* Revert latcontrol
* revert opendbc
* latActive is basically lkas_enabled
* Update Bolt torque params
* comment
* clean up
* Add to releases
* Add test route
* Don't specify segment
* bump panda
* bump panda
* no harness for Bolt just yet
* Apply suggestions from code review
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* We support all and 2023
* move safetyParam up to first cam check
* Bump panda and update docs
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* GM: separate EV/ICE gas/brake lookup tables
* removed blank line
* V are the same
* comment
better ordering
comment
comment
* Add some delay for the laggy brakes
Add some delay for the laggy brakes
* move actuator to only acadia
* start braking at 0 m/s/s
* Revert "start braking at 0 m/s/s"
This reverts commit 55c1dee733.
* add delay for escalade
* revert EV changes
* Update selfdrive/car/gm/carcontroller.py
* comment
* only ACADIA
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Interface radarOffCan set, comments
* pass pcmCruise value to common events
* add transType and networkLoc to iface
* carstate use transtype to detect EV
* ctrl: limit sends by config
* Add clarifying comments for new vals
* clean up
* comment on new line
* these have the same frequency
* remove 25hz
* add to upper comment
* update refs
* update refs
* move into same block
move into same block
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* json
* better naem
* Read from table
* formatting and default to nan
* Generate docs
* Read from table
* this should be the same
* Prius v is full
* test we always set the tunes correctly
add to release files
* Set for all cars
Set for all cars
* Revert tuning changes
Revert tuning changes
* remove that
* fixes
* update ref commit for new maxLateralAccels
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Set good torque using torque controller tuning
* should be equal to
* save lateral accel to car params
* use maxLateralAccel
* always
* same convention
* nan will always evaluate to false
* The great good torque purge
* adjust default friction
* Add data for more cars
* adjust name
* Welcome back, guys. Only adjust good torque if maxLatAccel is set
* Update refs (1.7 is 1.7000001...)
* function for creating button events
* fix
* one line
* alphabetical
alphabetical
* only needed once
* common function for enable events
* add to list
* extend
* fixes
* add type hints
* flip around
* do tesla
* parentheses
* Do Chrysler
* Make sure Hyundai long never actuates when long inactive
.
* clean up Hyundai
* more clear
* formatting
* Stock sets these to zero
* fix params
* move jerk logic into CC
clean up
* proof of concept
* actuators packet describes which actuators are active
* bump cereal
* fixes
* not needed for this PR
* Do Toyota
* add back controlsState.active
* bump cereal
* rest of cars
* in actuators
* add active back
* which
* use controlsState.active for now
* will make an issue
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* move local lat_active checks into CC.latActive
* remove redundant checks
* move comment
move comment
* fix joystick mode
* get enabled from carcontrol
* do standstill check in controlsd
* make sure we consider the gas press case for GM
* use CC.actuators
* fix
* capitalization
* Bump cereal
Bump cereal
* make intermediate actuators
* similar convention to before
* clean that up
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* check in tuple instead of list
* Update selfdrive/car/toyota/carcontroller.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Update selfdrive/car/mazda/interface.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* GM Acadia lateral tuning
* old tune was not returning to center, nor strong enough. Trying to make P and F equal.
* reduce integral, and eyeball actuator delay
* return PI to openpilot default
* remove default values from acadia
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
* Added 2016 Escalade ESV fingerprint and data.
* Updated CARS.md for GM vehicles
* Uploaded Escalade fingerprint
* Removed part about auto high beams for GM. Seems to work for some.
* Revert other modifications in CARS.md
* Revert other modifications in CARS.md
* Added test route for Escalade
* Added tunning for Escalade to reduce jerky steering
* Apply suggestions from code review
* Update selfdrive/car/gm/interface.py
* cleanup test route
Co-authored-by: Gibby <git@twoitguys>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* GM Volt lateral tuning and feedforward function
* improve comments, lower P 5% to 0.17, which matches all my notes over time, 0.18 was a last test change.
* don't justify actuator delay for now
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* use ISO 15622:2018 limits in PID controller
* allow more for nidec
* limit PID inputs
* CP is not needed
* add GM
* not used
* update ref
* fix honda bosch
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Shane Smiskol
Jason Shuler
Adeeb Shihadeh
Tim Wilson
HaraldSchafer
Dean Lee
kevinharbin
Willem Melching
Dave
Jason Young
Gibby
qadmus
Robbe Derks