I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring
Python3 interpreter:
>>> print(" %d %d" % (1.6,1.4))
1 1
>>> print(" %d %d" % (round(1.6),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),int(round(1.4))))
2 1
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Slower rate for ACC cancel msg to avoid cruise disable
Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Round up 27.96 to 28mph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Mazda Port
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update checksum to account for steer angle signal used in some cars
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Add test drive/segment ID to pass CI tests
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Process gear and brake signals, add new fingerprints
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Refactor some car interface code
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop unused variables, cleanup handsoff tracking
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update to steerError and steeringRate
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Refactor parse gear, update lkas signals from the new dbc
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Better tracking of engage and warning events
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* remove commented lines, update speed_kph to match panda
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Steer Error
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Set lkas enable speed to 52 kph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop block signal use, fix LGTM alerts
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* When gas is pressed OP will disengage, sync local state with it
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Use car's speed signal instead of wheel speed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Tidy up disengage events
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Rebase/Refactor with upstream
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Sync stock ACC state with OP
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* mazda dbc file renamed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Improve acc stock and go by removing the 3 seconds limit
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Dashcam
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* PR Feedback
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Send ACC cancel only if we are sure cruise is enabled
Otherwise we run the risk of disabling main cruise
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* updated route
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* no process replay for now
* add to release files
* Revert "updated route"
This reverts commit 233db4f1bc.
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Adeeb
Jafar Al-Gharaibeh
Willem Melching
Adeeb Shihadeh