* bump
* from https://github.com/commaai/openpilot/pull/27929
* get VIN on bolt!
* might as well try on other gms
* remove vin
* ugh gm is going to be slow
* fix
* should really fix this
* revert
* happy?1
* fix unit test
* bump
* functional addressing must be an OBD gateway feature, this does nothing
* fix vin response
* fix addr!
* finally fix fw_versions bugs since boardd IsOnroad refactor
* for
* only bus 0
* clean up
* Update selfdrive/car/gm/values.py
* ChatGPT re-write
* filter out did
* todo
* oof
* preview: what multiple DIDs per ECU would look like in the future
* Revert "preview: what multiple DIDs per ECU would look like in the future"
This reverts commit 88f0d8611e.
* function to get all ecus
* we can remove this!
* can also do this!
* and this one too :o
* consistency
* yay
* clean up
* add CADILLAC ESCALADE ESV PLATINUM 2019
* add test route
* Update selfdrive/car/gm/interface.py
* combine params
* that's just a trim
* wow, there's a huge torque offset (left is 1.2 m/s^2, right is 1.9 m/s^2 max lat accel)
* don't hard code
* Update selfdrive/car/torque_data/override.yaml
* consistent formatting
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* timing test
* test
* fix
* print
* loop
* clean up
* wider range
* Update selfdrive/car/tests/test_models.py
* Apply suggestions from code review
* run many times
* Update selfdrive/car/tests/test_models.py
* run for many its
* run with unittest and print as list
* Update .github/workflows/selfdrive_tests.yaml
* Update .github/workflows/selfdrive_tests.yaml
* total time is super inconsistent (body)
* Update selfdrive/car/tests/test_models.py
* clean up
* clean up
* clean up
* this works!
* draft
* test suite not as modular
* try something like this
* can do kb, but not too representative
* clean up
* remove kb? it depends on signals
* clean up
* more clean up
* rename
* just measure all CANParsers
* can do all this manually
* but this is way simpler
* comment
* stash
* draft
* draft
* remove old script
* clean up
* revert
* use it
* remove test
* opt
* no partial
* remove
* revert test_models
* test can fingerprinting
* so much simpler!
* fix dict resizing
* simplify
* need to do this
* fix
* move to new file
* rename
* comment
* ignore function-uses-loop-variable
* add missing addresses FP for silverado
* add for all camera acc gm
* add test
* check both rx and tx
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* more stuff
* even more
* all parts func
* start to use it
* include self in parts
* use car_parts_new
* not used
* more usages
* remove get_parts
* remove more commented stuff
* remove iter
* clean up some more stuff
* more
more
* ford
* optional
optional
* nissan
* use new classes
* fix tests
* fix
* order
* no more required
* connector
* CARS.md
---------
Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
* generic car parts
* better carparts
* add part type
* more tests
* multiple enums
* unit tests
* just check isinstance
* better name
* remove _connector suffix
* remove those hyundai lines
* remove default arg
* Revert "remove default arg"
This reverts commit 139650a3b6.
* cleaner code structure
* use fingerprint
* review
* abstrac data class + common
* no more dataclass
* conflict
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* add harness kit content to the doc
* parts as enum
* nissan
* merge column
* rename column
* scaling
* scaling again
* 500px
* align text
* more px
* add style
* more width
* more
* more
* smaller text
* make all text smaller
* prev width
* default list
* remove hidden a ref
* try to remove again
* revert
* replace harness with harness_kit
* try fix
* cleaner
* center everything
* make pylint happy
* allow more than 1 of each parts
* use copy module
* review
* testing spacing
* revert
* bigger text
* formating
* split harness col lines
* remove print
* resolve
* rename to view
* keep formating in template
* simplify
* add unit test
* more generic way
* better
* harness connector only
* comment
* review
* put back harness parts
* missing dash
* too much space
* don't reload when clicking
* shorter comment
* only last line
* generate
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Add trailblazer support
* Update routes.py
* Update routes.py
* Update CARS.md
* Fix incorrect torque name
* Update values.py and CARS.md
* Change to update another route
* update docs
* only 2021 https://en.wikipedia.org/wiki/Chevrolet_Trailblazer_(crossover)
only 2021
* new FP with missing addrs
* Update selfdrive/car/gm/interface.py
* tune the torque params
* update docs
* remove as a new platform
* Revert "remove as a new platform"
This reverts commit c9c65f29db.
* add comment and comment out FP
* need it to be in all_known_cars to test_model
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* add erf based ff
* silly bug; diff of nonlinear != nonlinear of diff
* add sigmoid based ff, ensure slope at 0 > 1
* reduce steer down limit and increase driver allowance
* rebase panda
* atry without friction, and with tanh nonlinear
* finalize the nonlinear function
* do not disable friction compensation in the ff
* bump panda
* bump panda
* update refs
* update refs
* resolve comments
* Add type hints
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Add flashed Volt fingerprint
* Add another fingerprint
* Detect radar header message
* dashcamOnly if ASCM vehicle with radar unavailable
May be able to change this in the future to OP long off with experimental long available
* no submodule update
* Revert minEnableSpeed
* combine into one fingerprint
* Don't use GM radar DBC
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* unused
* add new FP
* update docs
* use_off_car_defaults
use_off_car_defaults
* update docs
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* stash
* more test
* less test
* clean test
* no angle
* add tolerance
* fix gm
fix gm
* test both
* lower some rates on hkg
* stash
* simpler
* bump panda
* Revert "bump panda"
This reverts commit f2137c2211.
* only torque
* make kona pass
* duplicate __init__
* move
* half clean up
* half clean up
* more clean up
* more clean up
* fix static analysis
* calculate over 0.5 seconds
* limit to max steer
* type annotation
* calc once
* add a hook function for makes to implement custom docs logic
* don't need this
* use the pre-defined list for honda's harnesses
* one line 😎
* Update selfdrive/car/docs_definitions.py
* i didn't know you didn't need a pass!
* don't change docs order
* put gm camera voacc behind disable radar toggle
* bump panda
* bump panda
* bump panda
* experimental long
* fixes
* car control notes and fixes for Bolt EUV
* might enable stop and go
* consistent name
* min enable speed seems to be around 5 kph
* camera acc can engage under 5 kph if stopped
* comment
* comment
* remove this for now
* only real brake
* comments
* update max brake
* bump
* clean up/fix
* same if
* simplify
* fix
* old comment
* no brake_pressed
* temporary fault fix
* tune longitudinal
* update docs
* bump panda
* GM camera ACC cars have no regen in ACC
* cleaner
* cleaner
* fix
* set max gas
* fixes
* fix LKAS unavailable warning from camera
* only camera
* bump panda
* bump panda
* bump panda
* bump panda
* clean up gmcan
* clean up CC
* flip
* rm
* rm comment
* clean up
* custom starting/stopping probably not needed
* Update selfdrive/car/gm/carcontroller.py
* fix crash
* long tuning
* we need long control state to resume
* CAMERA_ACC_CAR not needed
* no interp on accel
* tuning
* formatting
* formatting
* formatting
* formatting
* formatting
* no need to init ccp
* makes more sense now
* send at 10hz when inactive
* try to make it fine to switch rates
* fix rate
* todododo
* fine if we skip, we usually send too early
* clean up
* this may be required, 50Hz is not really needed to sync/initialize
* preserves previous behavior (not sure if this makes sense)
* Revert "preserves previous behavior (not sure if this makes sense)"
This reverts commit 3b297bca72.
* Revert "this may be required, 50Hz is not really needed to sync/initialize"
This reverts commit a6b4693814.
* rm com
* Update ref_commit
* gate behind GM Cam
* common logic
* bet
* update refs
* -4 didn't make any sense?
* comments
* comments
* update to 400
* bump panda
* remove unused iso limit vars
* update comments
* bump panda
* Update selfdrive/car/gm/values.py
* Update ref_commit
* Chevy Bolt EV w ACC Port
* dashcam
* The website allows you to select the package without ACC
* fix Bolt E(U)V centerToFront
* Update selfdrive/car/gm/values.py
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Chevy Equinox Port
* LKAS is not standard on 2019, but it's the same package as ACC. (LKAS standard 2020+)
* 2019 here too
* clean up
* add to untested
* not in docs
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Silverado support
Co-authored-by: Jason Shuler <jshuler@gmail.com>
* Update docs
* Try 2 m/s/s
* Should be good torque values
* Add Silverado test route
* Add to releases
* Send counter
* can't send multiple or it faults
* Send at 33hz, no counter
* try 25hz, don't line up exactly with car's buttons
* never tried 10hz with same counter
* Update selfdrive/car/gm/gmcan.py
* Make same as pcmCruise branch
* update year and package (different packages needed per-trim)
* Update year in releases
* Revert to 21
* We can use this package name again
* wrong one!
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Switch to ECMPRDNL2 for GM gear
* Removing manumatic gear #
* values.py almost complete
* Silverado and Bolt EUV val and CP
* GM controller updated
* Cam hrns supp done (in theory)
* cleanup for new cars
* Remove extra constant
* WS, etc cleanup
* removing the unused
* Fix kpBP typo
* Updated docs
* Skip's PIF tune
* Dropped LKA CAN error patch
* Add silverado sigmoid ff
* CAN Err & LKA latch patch
* Remove EPS fault fix (another PR)
* Remove Silverado (another PR)
* clean up some common params
* Remove Escalade FP
Remove Escalade FP
* comment
* Premier is just a trim
Premier is just a trim
Premier is just a trim
* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera
* clean up
clean up
* bump panda
* bump panda
* bump panda
* bump panda
* bump panda
* remove comments
* try spamming buttons on bus 2
* bump panda
* bumping opendbc w btn rc
* not needed for this port
This reverts commit 6af1f0ba79.
* add button safety
* Send next rc when spamming btns
* forward other signals in message
* missing DriveModeButton
* fill cruiseState.speed
* see if resume works without counter
* try the whole message
* send immediately and at 10Hz
* no resume, back to just button signal
* even holding random buttons it cancels
* Use torque controller with base tune
* stock long GM don't auto-resume yet
* Testing GM zero min steer speed
* Revert latcontrol
* revert opendbc
* latActive is basically lkas_enabled
* Update Bolt torque params
* comment
* clean up
* Add to releases
* Add test route
* Don't specify segment
* bump panda
* bump panda
* no harness for Bolt just yet
* Apply suggestions from code review
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* We support all and 2023
* move safetyParam up to first cam check
* Bump panda and update docs
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* GM: separate EV/ICE gas/brake lookup tables
* removed blank line
* V are the same
* comment
better ordering
comment
comment
* Add some delay for the laggy brakes
Add some delay for the laggy brakes
* move actuator to only acadia
* start braking at 0 m/s/s
* Revert "start braking at 0 m/s/s"
This reverts commit 55c1dee733.
* add delay for escalade
* revert EV changes
* Update selfdrive/car/gm/carcontroller.py
* comment
* only ACADIA
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* add well maintained footnote
* stash
* some updates for the website
* one extensible sort function, pass sort function into template, continue to use "openpilot ACC"
* use items
same
* return a final dict
* Fix descriptions
* Required
* Add detail sentence
* Make string packages into namedtuple
* add temp year parsing
* revert this
* one unified class like harness
* fix static analysis
* Fix body
Fix body
* Make specifics strong
* remove years
* Make Camry footnote more clear
* Revert this too
* Add notCar text, fix steer speed > enable speed (remove comma, no speed mention)
* fix missing years
* group_by_make
* Use full package text
* Only use full package text
* Check car name if notCar, fix imports
* add_years no longer needed, remove 'with Stop and Go'
* fix that
fix that
fix that
* Exception for Nissan and Subaru
* Adjust DSU footnote text
* Fix speed overrides in sentence, CR-V package imp
* init() was being called multiple times, only need to run once to set row
* Add harness information
* test harness enum
* add harness info for tucson
* update Tucson harness
* get rid of development
* make global enum
* fix
* add harness info
* add harness info to CARS.md (since we need multiple lines per HKG platform)
* revert this
* Actively Maintained means something! (aka, to bronze with select VW)
* fix caravelle
* add harness tooltip on maintained column
fix
* lol tubaru
* always assume harness
* update honda harnesses
* add Ioniq hybrid 2017-19 harness, todo: not sure
* unused import
* hmm, did they really switch to the C for 1 year??
* add comment
* add comments
* adding tooltips should be fine
* fix santa fe harness
* welcome back, vw
* no need for two harness strings
* seems fine
* fix 19-20 Niro EV harness
* these were taking from old database, so assume correct
* could be d
* pass all car info into template
* no more tool tips
* these use j533 harnesses
* accidentally got removed in merge
* also merge issue
* don't need these
* make harness non-optional
* add vehicles.vue template
* add original vue file
* stash
* stash
* clean up a bit
* add template for now
* implement footnotes and tier copy
* no more generator
* convert to 2 spaces
* should work, now onto vue
* does GH handle this html well?
* fix
* auto-generate descriptions and make tiers' maps non-str
* remove old files
* move template specific variable into templates, should be a bit simpler
* js template is simplier too now
js template is simplier too now
js template is simplier too now
* add video links from the nice car_info
* make rows attributes
* clean up
* fix
* remove template
* experiment with video links in GH
add image
how does this look?
fix
* Revert "experiment with video links in GH"
This reverts commit 8375e717b5.
* sort tier_car_info in place
* unused Tuple
* no type check
* fix script
* make CAR class enum, and values.py formatting
* Revert "make CAR class enum, and values.py formatting"
This reverts commit 04d9817e9d.
* stash
* add supported packages and model years
* don't change model years in fps
* move Lexus to info dict and make int enum
* remove sometimes wrong model years from name string
* use enum names
* convert Honda's values
* nice names
* use name
* GM
* Mazda, Ford
* Hyundai: WIP
* finish Hyundai
* fix
* Nissan
* Subaru
* Tesla
* formatting is for another PR
* Chrysler: todo: unify the Pacificas?
* do volkswagen
* this isn't a zoo
* skip enums for now
* Update selfdrive/car/volkswagen/values.py
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
* set All
* temp cars
* auto-generate CARS.md
* update type hinting
* add generated file
* add longitudinal star to cars that support disabling radar
* add TODO
* add notes
* add min_steer_speed exception for hatchback
* add minimum steering speeds
* Add exceptions and run generator
* Missing Telluride
* fix Prius v
* missing Prius Prime
generate
* start to convert years to strings
* Fixup Hyundai
* convert year sets to strings
* handle this
* missing S3
* Fix and add all missing cars (verified with script
* Supported Package fixes
* add get_tiered_cars
* Check radarOffCan for removing most Honda from op long
* Update for Avalon stop and go update on master
* Fix missing car params
* add my temporary script i'm using to verify new generated DBC
add my temporary script i'm using to verify new generated DBC
* generate with jinja template
* add header and footer
* clean up
* rename
rename
* add exceptions. jinja is nice, but why are its loop indexes starting at 1?
* add list of known car videos
* See how these look
* Add nice table formatting for column description
Add nice table formatting for column description
* generate
* consisten br tag
* small clean up
* temp
* Move car videos into CarInfo
* add new copy and rename to footnotes
* Revert "temp"
This reverts commit 93c3fce1d3.
clean up
* generate
* replace with svg
* simplify a bit
* add footnotes to CarInfo
* move some variables to docs.py
* Add video link for Acadia
* Make Footnote an enum so we don't use random ints
* static analysis fixes
* move to CARS.md
* fix last missing footnote
* add to release files
* rm test file
* use svg
generate
* fix sorting
* not needed
* not sure how this got here
* remove Sedan/Couple and add Diesel footnote
* finish todos
* move make specific footnotes to selfdrive/car/*/values.py
rename
* change to zeros
* align bottom to center
* Apply some suggestions
* Update selfdrive/car/mock/values.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update copy
* Try headers + bullet points
* somehow better
somehow better
* finish updating copy
* move template and add links to sups
* stars shouldn't be clickable
that didn't work
try this
try this
this is better
* add type hints to CarInfo
add more type hinting
* optional needs a type and any covers all (?)
* move good steering torque to */values.py
* dataclasses are much nicer than attr
* use tuple
* Update docs/cars.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* suggestions
* suggestions
* suggestions
remove
* clean up a bit
* add more type hints
* center stars and remove hardcoding from template
* update copy
* Add test
* Fix types
Fix types
* add supported cars documentation test
* clean up
* replace with docs_definitions
* Add back Footnote enums
* Ah so these are like fstrings!
* Update selfdrive/car/CARS_template.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/car/docs.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update year from master merge
* Fix longitudinal star from merge
* sort properly stars by Column enum
* clean up
* HKG: Sorry guys
* Prius V gets FSR star, like others
* Update selfdrive/car/docs.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* update comment
* No Prius docs change for now
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Shane Smiskol
Adeeb Shihadeh
Justin Newberry
Tim Wilson
morrislee
Maxime Desroches
Yong-seok, Jang
Vivek Aithal
koch-cf
Eric Brown
Ricky Gilleland
Cameron Clough
Jason Shuler
MadBrad