openpilot_comma

Commit Graph

Author	SHA1	Message	Date
Shane Smiskol	8f958e8ee6	fw_versions: clean up some typing (#29350 ) * another common type * here too * unused old-commit-hash: `09ce869ee7`	2 years ago
Shane Smiskol	5f3569faf2	HKG: use platform codes to fuzzy fingerprint (#28531 ) * get gas/ev/hev from FW (not all correct, poc) * add test for essential ecus for fuzzy fingerprinting * kinda works * stash * clean up * add code * simpler * use the function * test it with our cars * no re no re no re * debugging * handle empty dict * simpl * this is promising start on making existing fingerprinting functions use the config, instead of entirely replacing them * needs to allow 1 match * lay out how this should look * changes * executable * some work * use config * fuzzy ecus * config test * comment and some clean up * test platform codes * use regex, simpler and fixes bug * in func * rm bad func * typing for new func and remove old from dc * todo done * tested! * remove fake platform codes * thought we needed this, but actually... * not needed * not applicable any more * use config for essential ecus * first draft of test to make adding/removing fuzzy FP platform intentional * compile * clean up test * even cleaner * fix default ecus type * temp fix * this is mostly in tests now * test every fuzzy ecu fw returns one platform code * experiment with dates * Revert "experiment with dates" This reverts commit `3251b9cc5c`. * clean that up * comment * test * work on all cars * fix fuzz_fw_fingerprint * comment * get first by search * bit more clean up * and more * use compiled pattern for nicer syntax * default * flip dat around, much cleaner * clean up hyundai test a bit * flip order same here * rename test and flip subTest * fix pylint * revert fw changes revert fw changes * line * add original functions to test * needs to be a list * cmt * draft (need to count one ecu as a match) * tiny clean up * todo: date range * only in notebook * remove comment (still can be either list or set) * same, only notebook * more consistent signature * copilot inspired * copilot no good * test for date parsing * better name * good, now we don't have to worry about the dates mismatching in another test/logic * comment up+ * some stuff * clean up fix test fix test * test * comment * use utils * clean up (utils are cleaner and less buggy) * clean up (utils are cleaner and less buggy) * fixup test * use a dash (prettier) and remove some platforms that can fingerprint now! * compile global pattern * same as what we do in values * remove comments * fuzzy_get_platform_codes is one or none here * more clean up * sort imports * woah woah woah * add comment * fix reassigning different types * add types * adapt fuzzy test recently added (nice it caught this!) * update lock * options comments * stash * comments and fixes * better comments * better * test: run on exact fuzzy matching logic, same results! * use match_fw_to_car * test all fw * ex * unused random * this is a possibility * this is more clear * fix * revert * revert to needing both ECUs to match to reduce false positives, test * fix excluded platform test :( but it's ok * add comment * we actually want to only test fuzzy ecus to make it explicit * fix mypy * comment for tomorrow * just add matches with fuzzy FP * add comment * this was the cleanest I could think of, but still working on it. not very easy to understand * think this is better, but also worse... * comment: reframing how this works * revert back to what we did before * was swapped * else set * remove old comment * fixes from merge * remove fuzzy_min_match_count from this pr * fix static analysis * also unused * different method first draft * copy existing fuzzy func * check all possible ecus exist, only platform codes, slightly refactor main loop * fix * Revert recent Revert "fix" This reverts commit `5cdb7bda83`. Revert "check all possible ecus exist, only platform codes, slightly refactor main loop" This reverts commit `d3e918fa20`. Revert "copy existing fuzzy func" This reverts commit `34c8c05450`. Revert "different method first draft" This reverts commit `b91139055d`. * new func * fixup test * remove changes from v1 from fw_versions.py * clean up a bit * return part as part of code * fix test * add original fuzzy function * add an ecu match if the date is within range (or date doesn't exist) * add format for what we're going to do * not working stash * the exact matching function does more of what we want with less code and less custom logic * we don't care about found versions, only codes and dates * actually we do have an exception * this works pretty nicely now * up here * this is better * some minor clean up * old function=now junk * fix platform code test * remove old platform code function * now rename _new to * use FW_QUERY_CONFIG * clean up imports * rename that too * one line * correct typing correct typing * draft tests * so that works * fixup excluded platform test now too * this is tested by excluded platform test * test parts and dates * remove old comment * old import * take platform code stuff out of FwQueryConfig * fix test * revert debug script * flip order * make this a set by default * revert this part * correct typing * clean up comments * clean that test up too/pylint * combine these three tests ina clean way * not right * more general * be consistent with quotes * comment * comment * comment in fw_versions * flip order * this is more readable * could test all this, but it's tested in test_hyundai and doesn't do a lot here * only assert brands which use this * invalidate all CAN FD ICE and hybrid * tuple * can get away without filtering * add comment reasons * fix * some review suggestions * this works (first draft) * this is better * script to print platform codes and dates * sanity check for dates are in correct ecus and platforms * mypy * better variable name and comment * rename * same * slightly better name * subset * exclude platforms and live car without dates * consistent * self explan * better name * test to make sure the functions agree * clean that up * comment * we get other responses from queries not in DB, only check any * not used or typed old-commit-hash: `f788edb6a5`	2 years ago
Shane Smiskol	4120ee014d	FwQueryConfig: remove platform codes (#28538 ) * bring platform codes out of config for now (can re-introduce later) * clean that up * flake8 * comment * comments and better test names * typo * Update selfdrive/car/hyundai/tests/test_hyundai.py * Update selfdrive/car/hyundai/tests/test_hyundai.py old-commit-hash: `572a221a86`	2 years ago
Shane Smiskol	de4b702ec3	FwQueryConfig: add platform code support and tests (#28475 ) * add config options * you know what, platform codes don't need to be related to fuzzy fingerprinting at all * better comment? * add comment * add test from other PR * add platform code function to hyundai * comment and add eps! * clean up config test * fix test * add error message to test * until we have multiple ways a brand can set up fuzzy FP, let's leave func name fuzzy-specific * rename in comment too * hyundai tests * simpler test! * check all ecus with platform codes * add types-python-dateutil = "^2.8.19.13" * these aren't used any more * Update selfdrive/car/hyundai/tests/test_hyundai.py * not to imply this is active yet old-commit-hash: `f5e032b67f`	2 years ago
Shane Smiskol	528f7e5302	FwQueryConfig: auxiliary field to add requests for first aux panda (#27666 ) * mid-solution stash * pretty cleannnnnnn * everything seems to be working * rename * space * reduce obd multiplexing transitions from 3 to 1 (0.3s to 0.1s) old-commit-hash: `ecbd7150eb`	2 years ago
Shane Smiskol	cdcf06e9e2	boardd: ability to switch between ELM safety params (#27656 ) * indecisive * rename to generic FW query * remove code and update comment * we need this to start off, unless we set multiplexing immediately * draft * draft 2 * try that * can't do this either, boardd might read Enabled after removing, but before setting new Request param * this should work * use one less param * fix params * match behavior (set all pandas to safety param of 1, disabling multiplexing for fingerprinting * clean up (some tests may temp break) * fix param name and sort * time it * yes it does matter * add to hyundai's bus 5 query * remove hyundai for now * this should work * clean up * clean up * flip argument around, clean up * fix test_startup * some clean up * rm line * comment makes more sense * required typing * clean up common type * comments * Update selfdrive/car/car_helpers.py * line * whoops, need to set before vin! * fix debug * annoying * more debugging * bug fix (needs both keys always) * debuGG debuGG * Revert "debuGG" This reverts commit `55b2f42932`. * Revert "more debugging" This reverts commit `02934c3403`. * Revert "annoying" This reverts commit `8b4e5e0998`. * clean that up * bumpback * bumpback * every second write param * flip * stuff * move up? * fix timing out in CI * rm old-commit-hash: `42449b482d`	2 years ago
Shane Smiskol	cc456ad691	Honda Bosch: gather available ECUs from camera (#27180 ) * add flag * actually use in fw_versions.py * simpler * not here * Comment * better name * add param and block * keys keys * block * with a value with a value * add query for bosch PT bus * different name * fix * . * fix test fix test * add cloulogs * mark as logging old-commit-hash: `c4b84783a0`	2 years ago
Shane Smiskol	cdfd691644	FPv2: log responses from data collection queries (#27345 ) * log responses from logging/debugging queries * don't add logging FW to FW dict for fingerprinting * flip? * fine before * log if extra in debug ecus * clean up * test extra ecus too * Revert "test extra ecus too" This reverts commit `8f7867844d`. * bump to master old-commit-hash: `f29e19cf42`	2 years ago
Erich Moraga	48ecc257e6	Add several missing LEXUS_RC firmwares (#26905 ) * Add several missing LEXUS_RC firmwares `@Vranesh#9912` 2020 RC350 DongleID/route d6303cdeea512a4e\|2023-01-09--17-11-55 * lexus now has two engines * todo Co-authored-by: Shane Smiskol <shane@smiskol.com> old-commit-hash: `d12146fbd6`	2 years ago
Shane Smiskol	b85bf30a7e	FPv2: support collecting versions for specific ecus (#25699 ) * Add VMCU address for EV6 * Rename vmcu * add to tests add to tests * rename to more generic name * more explicit * remove print * Like this much better, removes subtle fingerprinting problems * clean up * add test and clean up * remove hyundai stuffs * global * Fpv2Config class * fix missing fw versions from import order * unused * revert for now * test for fpv2 configs with subtests * subtests don't work that way * remove this * . * intersection * print ecus * shorter * fix typing * use config old-commit-hash: `7e9961b9ac`	3 years ago
Shane Smiskol	ae77b7edc7	FPv2: move car-specific configuration into interfaces (#25711 ) * Add VMCU address for EV6 * Rename vmcu * add to tests add to tests * rename to more generic name * more explicit * remove print * Like this much better, removes subtle fingerprinting problems * clean up * add test and clean up * remove hyundai stuffs * global * Fpv2Config class * fix missing fw versions from import order * unused * revert for now * test for fpv2 configs with subtests * subtests don't work that way * do toyota as an example * revert revert * do chrysler * do rest * stash * much smaller of a diff than the alternative * remove unused test * fix tests * remove brand from Request * Make StandardQueries class * add missing_ecus clean up * rename file * unused * test implemented * add comment and rename add comment and rename add comment and rename * should be impossible now * this is a fixme * rename to fw_query * rename this too * and this * move vin queries to class * order * can use p16! * formatting * whoops, this wasn't gated on not len(found_versions) * make this clear * Standardize manufacturer software version query old-commit-hash: `0ef6bb48df`	3 years ago

11 Commits (9b83190ffba48120d19b10aab325b901bfa671a2)