Shane Smiskol
037d1db5fb
replace CarControl
...
i hope there's no circular imports in hyundai's CC
9 months ago
Shane Smiskol
2c7baf348f
mypy can detect return type of CS.update() now
9 months ago
Shane Smiskol
c8b7d1cf41
missing imports
9 months ago
Shane Smiskol
eb52d701de
replace a bunch more cereal.car
9 months ago
Shane Smiskol
4359fa5c50
need to namespace to structs, since CarState is both class and struct
9 months ago
Shane Smiskol
b926893b34
remove some car.CarParams from the interfaces
9 months ago
Shane Smiskol
e8afc6ab56
type ret: CarParams, add more missing structs, revert lateralTuning changes (smaller diff!)
9 months ago
Shane Smiskol
d40da13e71
more lateralTuning
9 months ago
Shane Smiskol
a55b8d2bd0
bunch more typing
9 months ago
Shane Smiskol
8d961a12e5
selfdrive/car: ban common ( #33210 )
...
* ban all of common & copy numpy_fast
* add numpy_fast
* these are okay
* and ban controls
* better name
* Conversions
* do utils, kalman
* clean up
* sorting
* don't forget
9 months ago
Shane Smiskol
0739d79a51
cars: remove some external imports ( #33133 )
...
* ford and gm
* clean that up
* also this
* honda
* temp fix
* move into selfdrive.car
* clean up
* more
9 months ago
Shane Smiskol
b7695c00e8
GM torque control: robust sig function ( #32847 )
...
tricky
10 months ago
Harald Schäfer
bc303df6a0
long control: new API ( #32706 )
...
* Simplify long control
* Seperate
* Rename
* Try new api for toyota
* rm v_pid everywhere
* No speed in reset
* 0 is better default
* unassigned variable
* Update other cars
* Update gm
* SIMPLIFY
* simplify more
* fix API boundry
* Fix stopping bug
* Small fixes
* Update ref
11 months ago
Harald Schäfer
965415135a
Long control: Double delay is super complicated ( #32694 )
...
* Double delay is super complicated
* No more upper bound
* DEAD
* Update ref
11 months ago
Justin Newberry
b0eb3ba4f4
cars: platform enums -> prepend brand name ( #31927 )
...
* with brand name
* migrate
* Fix
* fixes
* more
* passes
* fix
* fix the doc
* collects
* these too
* more stuff
* body exception :/
* more
* hardcode i guess
* update ref
* toyota
* more toyota
* and here
* final!
* fix notebooks and ccs
* move this here
1 year ago
Adeeb Shihadeh
3a7582d9a6
Abstract out common CarInterface.apply ( #31924 )
1 year ago
Jason Wen
5ca733c415
GM: Parse distance button from steering wheel ( #31762 )
1 year ago
Shane Smiskol
638aaa9e53
Platform configs: move tire stiffness into config ( #31678 )
...
* first one to open PR
* mazda
* oh it is
* fix gm car specs and create MazdaCarSpecs
* fix
* do honda
* ruff
1 year ago
Eric Brown
5012e15aa6
GM: move to platform config ( #31553 )
...
* subaru platform config
* forester wrong dbc
* spacing
* subaru car specs
* someday!
* more red diff
* Move GM to platform config
* Implement CarSpecs
* Simplify centerToFront
* Accidentally had subaru DBC
* Fix typo in DBC name
* done above
* two spaces
* that is moved up
* fix hardcoded fingerprints
* whitespace
* values
* better?
* fix
* bump
* fix
* fix
---------
Co-authored-by: Justin Newberry <justin@comma.ai>
1 year ago
Eric Brown
416e8253ec
GM: Remove Equinox from dashcam mode ( #31257 )
...
* Remove Equinox from dashcam mode
* Add fingerprint
* Set moving backward only if not moving forward
* Bump opendbc
* Update moving backward definition
* Update docs
* Bump opendbc
* REVERTME: Add assert statement at Shane's request
* REVERTME: check unsupported and fault status
* Revert "REVERTME: check unsupported and fault status"
This reverts commit 5a0ebad66c
.
* Revert "REVERTME: Add assert statement at Shane's request"
This reverts commit b4b885eb11
.
* Use or
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Add comment
* Add test route
* Use newer fingerprint
* Emtpy commit to rerun CI
* Empty commit to rerun CI
* Update selfdrive/car/gm/fingerprints.py
* little more
* remove from non-tested
* update
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Justin Newberry <justin@comma.ai>
1 year ago
Vivek Aithal
619625625c
CHEVROLET BOLT EUV 2022: Add a simple neural feed forward ( #31266 )
...
* add simple neural feed forward
* update refs
* do not sample during inference in op
* update refs
1 year ago
Vivek Aithal
056b330e8b
LatControlTorque: Add more inputs ( #31252 )
...
* add history and state to the ff inputs
* add history
* resolve comments
* remove history, simplify
* don't compute lateral accel, roll comp always
1 year ago
garrettpall
58ef40eb22
GM: Add BSM from Powertrain Bus ( #30861 )
...
* Add GM BSM
* Move BSM check to fwdCam only
* Detect if BSM message if present
* Remove hardcoding
* Apply Commit Suggestion
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Cleanup Suggestions
* bump opendbc
* test out bsm
* BCMBlindSpotMonitors -> BCMBlindSpotMonitor
* Revert "test out bsm"
This reverts commit 0e166530e6
.
* up here
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
1 year ago
Tim Wilson
b95d69ae1b
Car port: CADILLAC ESCALADE ESV 2019 ( #29913 )
...
* add CADILLAC ESCALADE ESV PLATINUM 2019
* add test route
* Update selfdrive/car/gm/interface.py
* combine params
* that's just a trim
* wow, there's a huge torque offset (left is 1.2 m/s^2, right is 1.9 m/s^2 max lat accel)
* don't hard code
* Update selfdrive/car/torque_data/override.yaml
* consistent formatting
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago
Shane Smiskol
24f5a6170d
car interfaces: handle buttons changing state without going unpressed ( #26463 )
...
* rename function first and foremost
* the function
* comment
* move usages over
* probably fine
* comments
* btn
* single line
* not comments
* fix keyword
* is it not clear?
* noEntry while holding cancel
* bumpo
* remove
* better?
* better?
* try this
* try this
* loop
* better
* more clear
* Revert "more clear"
This reverts commit 37e0277e4b
.
* no optional
* fine
* add comment
* clean up honda
* one line
* can also do this
* but unclear
This reverts commit 1984a72cc8
.
* bumppanda
2 years ago
Vivek Aithal
2fe3231b49
CHEVROLET SILVERADO 1500 2020: Make Silverado lateral tune non-linear ( #29540 )
...
add nonlinear values to silverado
2 years ago
Adeeb Shihadeh
a9626f95b6
add openpilot prefix to imports ( #29498 )
...
* add openpilot prefix to imports
* more
* more
* fix docs
* fix linter
* bump submodules
* fix patched tests
* update dynamic imports
* debug
* Revert "debug"
This reverts commit db5e13b991
.
* fix pm test
2 years ago
Jason Young
f76ffbdbbc
interfaces: add common STD_CARGO_KG to mass ( #29416 )
...
* cleanup std_cargo_kg
* fix Sonata mass
* remove snowflake construct
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago
Jason Young
90c4bbe8e4
car interfaces: cleanup tire stiffness calculation ( #28263 )
...
* cleanup tire stiffness calculation
* bump cereal
* think these todos still apply
* gm: same default
* revert comments
* bump
* update refs
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago
morrislee
060aa33b99
Closer Silverado 1500 Weight ( #29355 )
2 years ago
Vivek Aithal
3612c12b14
[GMC ACADIA DENALI 2018] Move to torque control, non-linear feed-forward ( #28923 )
...
* move GMC ACADIA to torque control, with a Bolt-like feedforward
* update offline values
* update offline values
* reduce friction
* update values
* update values
* cleanup
2 years ago
Shane Smiskol
82f2f9448b
GM: allow enabling down to a stop for Silverado/Sierra ( #28708 )
...
* Silverado: allow enable down to 0 without user brake
* update docs
* firmly
* better comments, fix docs
* revert docs
2 years ago
Shane Smiskol
5aebdb0ad0
Car docs: pass docs flag to car interfaces ( #27311 )
...
* docs
* docs
* docs
* docs
* use docs in gm
2 years ago
Yong-seok, Jang
e1ad8df519
GM: Trailblazer 2021-22 support ( #27830 )
...
* Add trailblazer support
* Update routes.py
* Update routes.py
* Update CARS.md
* Fix incorrect torque name
* Update values.py and CARS.md
* Change to update another route
* update docs
* only 2021 https://en.wikipedia.org/wiki/Chevrolet_Trailblazer_(crossover)
only 2021
* new FP with missing addrs
* Update selfdrive/car/gm/interface.py
* tune the torque params
* update docs
* remove as a new platform
* Revert "remove as a new platform"
This reverts commit c9c65f29db
.
* add comment and comment out FP
* need it to be in all_known_cars to test_model
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago
royjr
2ab05f96c3
Cleanup: GM remove unnecessary variable ( #27779 )
2 years ago
Vivek Aithal
15b880c0ea
Bolt EUV: Non-linear torque function ( #27696 )
...
* add erf based ff
* silly bug; diff of nonlinear != nonlinear of diff
* add sigmoid based ff, ensure slope at 0 > 1
* reduce steer down limit and increase driver allowance
* rebase panda
* atry without friction, and with tanh nonlinear
* finalize the nonlinear function
* do not disable friction compensation in the ff
* bump panda
* bump panda
* update refs
* update refs
* resolve comments
* Add type hints
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2 years ago
Shane Smiskol
aefe636cc1
GM: common longitudinal actuator delay ( #27357 )
...
* common longitudinal actuator delay
* comment
* remove dup
* move
* clean up
* Update ref_commit
2 years ago
koch-cf
ae423a6868
GM: Buick LaCrosse 2017-19 support ( #27332 )
...
* Added Buick LaCrosse 2017
* Added Buick LaCrosse as candidate
* Added Buick LaCrosse CAR_INFO and Fingerprint
* Added Buick LaCrosse to non_tested_cars
* Added Buick LaCrosse
* Updated number of supported cars to 237
* Added ACC and LKAS description to Buick LaCrosse
* Updated CAR_INFO for Buick LaCrosse
* Added the Escalade which was recently updated
* Update selfdrive/car/gm/values.py
Suggested fingerprint by @sshane
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Premium is a trim with ACC. Use package name instead
* lacrosse custom FF;
fit info:
describe(steer_offsets) = DescribeResult(nobs=1649402, minmax=(-0.7127894163131714, 5.3997602462768555), mean=3.3090523060153645, variance=0.3130325564084465, skewness=-1.5986155151533736, kurtosis=8.18810418298873)
Samples: 1357787
Regularizing...
Regularized samples: 1140
speed: DescribeResult(nobs=1140, minmax=(8.478170424241286, 35.837870224662446), mean=27.888804767013475, variance=34.16742353763829, skewness=-1.068587303119431, kurtosis=0.6193071765927134)
angle: DescribeResult(nobs=1140, minmax=(-21.057768565637094, 28.516874490999708), mean=-0.4328602593886506, variance=43.19046813273241, skewness=0.001966426701503317, kurtosis=0.20547357649038434)
steer: DescribeResult(nobs=1140, minmax=(-0.8432471203007578, 0.9634959333674695), mean=-0.021981142946747863, variance=0.20152217060233915, skewness=0.03202313890158864, kurtosis=-1.2318826088567174)
Performing fit...
Fit: [5.85397825e-01 3.27650818e-01 4.60531117e-03 1.32307599e+01
1.37194709e-01 1.33099557e-01 6.14782304e-02]
ANGLE_COEF = 0.58539783
ANGLE_COEF2 = 0.32765082
ANGLE_OFFSET = 0.00460531
SPEED_OFFSET = 13.23075991
SIGMOID_COEF_RIGHT = 0.13719471
SIGMOID_COEF_LEFT = 0.13309956
SPEED_COEF = 0.06147823
MAE old 0.2098, new 0.0309
STD old 0.1021, new 0.0273
deg 00-03:457, deg 03-06:258, deg 06-09:218, deg 09-12:132, deg 12-15:62
deg 15-18:6, deg 18-21:4, deg 21-24:1, deg 24-27:0, deg 27-30:2
deg 30-33:0, deg 33-36:0, deg 36-39:0, deg 39-42:0, deg 42-45:0
mph 10-15:0, mph 15-20:1, mph 20-25:18, mph 25-30:12, mph 30-35:30
mph 35-40:26, mph 40-45:52, mph 45-50:54, mph 50-55:73, mph 55-60:86
mph 60-65:204, mph 65-70:228, mph 70-75:179, mph 75-80:176, mph 80-85:1
mph 85-90:0,
* Update routes.py
* remove from non tested routes
* use torque controller
* update docs
* update releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Tim Wilson <twilsonco@gmail.com>
2 years ago
Adeeb Shihadeh
2008332bd4
GM: revert custom Bolt torque tune ( #27403 )
...
* Revert "GM: cleanup torque feedforward function (#27347 )"
This reverts commit 8c099dd4e5
.
* Revert "Chevrolet Bolt: Non-linear torque tune (#27344 )"
This reverts commit e49748d571
.
* update refs
2 years ago
Shane Smiskol
79749a306c
GM: add longitudinal delay to Escalade ( #27406 )
...
* add delay to escalade too
* order
2 years ago
Eric Brown
c3ba2a025b
GM: detect unplugged or missing radar ( #27245 )
...
* Add flashed Volt fingerprint
* Add another fingerprint
* Detect radar header message
* dashcamOnly if ASCM vehicle with radar unavailable
May be able to change this in the future to OP long off with experimental long available
* no submodule update
* Revert minEnableSpeed
* combine into one fingerprint
* Don't use GM radar DBC
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* unused
* add new FP
* update docs
* use_off_car_defaults
use_off_car_defaults
* update docs
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago
Ricky Gilleland
b76795d7f0
GM: Escalade 2017 support ( #27276 )
...
* Initial 2017 Escalade values
* update docs/CARS.md
* revert back to v1 fingerprint & add test route
* revert bad merge
* update fingerprint
* update
* update
* Update selfdrive/car/gm/values.py
* Update selfdrive/car/gm/values.py
* no engine
* Try global tune
* pcm
* Driver Assist Package has ACC, and includes LKAS from previous package
* update docs
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago
Shane Smiskol
89934b35d0
Car interfaces: assert reasonable centerToFront range ( #27356 )
...
* assert reasonable centerToFront values
* comment
* fix Bolt centerToFront
* Update ref_commit
2 years ago
Shane Smiskol
8c099dd4e5
GM: cleanup torque feedforward function ( #27347 )
...
no numpy
2 years ago
Vivek Aithal
e49748d571
Chevrolet Bolt: Non-linear torque tune ( #27344 )
...
* add non linear tune
* update refs
* rerun tests
2 years ago
Shane Smiskol
29ca52bc48
GM: split steering speeds ( #27277 )
...
* split steering speeds
* update docs
* Update ref_commit
2 years ago
Shane Smiskol
8f5057ff2d
GM: enforce steering command message timing ( #27250 )
...
* draft
* bump opendbc
* still draft
* that's not right
* superset of the changes, 33hz
* cleanup
* this should work
* remove line
* pass it in again
* actually no need to check updated now
* now_nanos
* consistent name
* fix replay
* one line isn't that bad
switch
switch
* fix CarController tests
* Update ref_commit
2 years ago
Shane Smiskol
9aac0806e3
GM: increase min steer speed to avoid temporary faults ( #27274 )
...
* increase min steer speed to avoid temp volt faults
* actually 10.15 is safe
* Update ref_commit
2 years ago
Adeeb Shihadeh
6fa9b555a4
rename carState.radarOffCan to radarUnavailable ( #27187 )
...
* rename carState.radarOffCan to radarUnavailable
* bump cereal
2 years ago
Tim Wilson
a40efbdfcc
GM camera ACC: always set long tune ( #26892 )
...
* GM: set long tune for camera car w/o exp. mode
* same tuning
* update refs
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2 years ago