This commit lowers the kp and ki values for lateral tuning. This fixes the wheel shake, greatly increases straight line performance, and produces more human like driving on long curves.
old-commit-hash: 4c2efb4e7e
* Parametrize MIN_CAN_SPEED in car interfaces
* fixed instance in planner.py
* fix typo
* var name change
* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files
* added default value to get_std_params, removed unneeded instances from car interface files
* Revert PEP8 autoformat corrections
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 093456cc40
These are the correct values when i was testing visionradar. Things got messed when Civics were coded together and got split up again.
old-commit-hash: 1613abb0b1
* PR - Honda HRV
values.py - incl. Class, FP, FW_VERSIONS, SPEED_FACTOR 1.025
carstate.py - incl. carFingerprint, doorOpen OVERRIDE (signal unknown)
Safety test concludes that removal of drivers seatbelt IMMEDIATELY disengages OP
interface.py - incl. HR-V vehicle parameters, tuning (tested for 100+ miles)
Longitudinal tuning parameters unchanged from CAR.FIT
test_car_models.py - added per request of review process
*5. honda_hrv_touring_2019_can_generated.dbc will be submitted to commaai/opendbc in next PR
Once *5 is approved, will need to update values.py to matching dbc
Thanks, Cowan Moore 330-701-3922
* Honda HRV Door Signal
BO_ 422 SCM_BUTTONS: 8 SCM
SG_ DRIVERS_DOOR_OPEN : 63|1@0+ (1,0) [0|1] "" EON
* Update values.py
* Update test_car_models.py
old-commit-hash: 1d6042c5f3
* don't need individual prev state vars since whole CS is copied
* don't need a whole function since toyota alerts were simplified
* better here
* abstract pcmEnable/pcmDisable events
* the flippening came to NEOS
* delete
* unused
* Revert "the flippening came to NEOS"
This reverts commit 91cfb73b29.
old-commit-hash: 8d791d78dd
* add 2019 Honda Insight + fw fp
* add actual fp and add to ignored, but still required for ECU detection
* add Insight dirty route for now
* update README.md, was wrong mph for each
* update test_car_models
* remove dbc extension
old-commit-hash: c8c4708f21
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event
* move lines a bit
* more GM cleanup
* typo
* move espDisabled to carState packet
* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed
* ops, wrong change
* bug
* update cereal
* update ref
old-commit-hash: 9685a5a743
* too many if
* unused
* whitespace
* key
* sefldrive/car/*
* no more gctx
* lower
* start abstracting common events
* all cars
* start small
* all cars
* reverse gear
* wrongCarMode
* wrongGear
* espDisabled
* steerUnvailable
* make linter happy
* c isn't used
* fix esp_disabled in VW
* update ref
* more red
* more cleanup
* fix subaru
* update ref
old-commit-hash: e8cb6ea06a
* Before abstraction, adding speed init from VW as well
* strting to abstract carstate class
* fix bug and update lock?
* revert pipfile change
* another bug
* fix linter
* bug fix
* remove a bunch of diplicated kf code
* better to not have class vars. will abstract __init__ anyway later
* abstract common instance vars in carstate init and a generic gear parser static method
* abstract gear parser for chrysler
* abstract gm gear parser too
* remove unnecessary random vars
* Chrysler: carstate returns capnp struct directly
* revert ref commit
* test ref
* WIP
* more WIP
* ops, missed this conflict
* ford as well
* not sure why this got deleted
* no need to copy
* remove copy
* remove copy import
* remove unnecessary intermediate variable
* remove obsolete comments
* GM: have carstate returning capnp struct directly
* Honda carstate also outputing capnp struct
* hyundai too now returns capnp from carstate
* ops, not meant this
* Subaru carstate also returning capnp
* Toyota: capnp struct as output of carstate
* fix bool
* minor simplififcation in Honda
* no need to negate
* VW carstate returning capnp struct (#1118)
* VW carstate also returning capnp struct
* fixed typo
* Remove unused blinker button (#1119)
* remove unused blinker button
* ops, this wasn't meant
* remove blinker button for VW as well
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 0c67143c92
Willem Melching
Adeeb Shihadeh
Samuel Coles
Chris McCammon
Igor
Ted Slesinski
Chris Souers
Greg Hogan
cfranhonda
Adeeb
Shane Smiskol
cowanhmoore
Adeeb
rbiasini
theantihero
George Hotz
Vehicle Researcher
dekerr