f1f40c117a
Add Disengage on Accelerator Toggle ( #23977 )
...
* Squashed commit of the following:
commit 953bcf0ecf8d03f0fec9ce0d5442cc660ae2347d
Merge: b4198608d 333257bad0b9790dd281862fce7d60c44e03⛽ ➡️ 🔋
bump
commit d2b64b89cf8d7265bc90848b4e3a2276c9a4cb78
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:19:34 2022 -0700
these changes will be in border PR
these changes will be border PR
commit bed31e63de2244c161729773978fef8a9246ddb5
Merge: 491417640 e91613bc6c88ced1f199c02bdd2db7b49c71820b198945fe00fb77820b19894991763f9ffd7c758d4b91763f9ff4🔥
commit 1885c9e2ba1f591736a9c70e8bca1f591736a2465811f0b7410160d0465811f0b40344363a53700efcb3f3e915cf62700efcb3f4220ce272fed273bb78ac1a85afd60ce3be32afc2f27203af3a04c0ad1a5499cf13caeb2230254ca787475e02cb
3 years ago
ca3171c0f9
bump cereal
3 years ago
adf34c3414
CarParams: remove max steer ( #24044 )
...
* Remove max steer
* Update ref
3 years ago
bae78dd46b
don't read params in car interfaces ( #23978 )
3 years ago
5fe00fb773
Move gas/brake pedal event logic to controlsd ( #23850 )
...
* move some state machine logic to controlsd
move some state machine logic to controlsd
* same order
same order
* move unsafeMode up
* disable at standstill
* save last CS
save last CS
* do we need to copy at all?
* don't copy
* rename
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Revert "Update selfdrive/controls/controlsd.py"
This reverts commit 10bb51a0f0
3 years ago
ae19308e83
add parkingBrake to carState ( #23968 )
...
* add parkingBrake to carState
* fix gm
3 years ago
5c3f3e44bc
break up selfdrive.config ( #23959 )
...
* break up selfdrive.config
* add to release files
* fix import order
3 years ago
7254db3906
LongControl: fix control state oscillation ( #23333 )
...
* check if plan is to accelerate or not
* remove comment
* needed to see it
needed to see it
* test logic with Toyota TSS2
* hackily log conditions
* Revert "hackily log conditions"
This reverts commit 7a6b5691e2b982c7a1e3911d980fb7530647affd.
Revert "test logic with Toyota TSS2"
This reverts commit e583d6e3caaa5f5b896165cd7949dfc1caabfd9a.
order
* revert
* fix
3 years ago
87849f93b1
better steer fault names ( #23890 )
...
* better steer fault names
* bump cereal
3 years ago
2c7845fce0
Longitudinal control: interpolate longitudinal plan ( #23787 )
...
* interpolate longitudinal actuator delay
rename
* formatting
* interpolate v_target most importantly!
* fix interpolation and rename
* nicer setup
* left in from testing
* update refs
3 years ago
9535dc606d
Longitudinal: add Kf to carParams ( #23752 )
...
* sane_kf
* long_kf + cereal
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
7410160d09
unsafe mode: update safety declaration comment ( #23753 )
...
* update safety declaration comment
* whoops
3 years ago
ee71fd2fcc
clip steer saturation counter to steerLimitTimer ( #23638 )
...
* clip steer saturation counter to steerLimitTimer
* update ref
3 years ago
31d147dca2
controlsd: verify unsafe mode consistency ( #23563 )
...
* add unsafe mode check to controlsd
bump submodules
forgot to add to health_t struct
bump
ahh forgot to set it!
bump
bump
clean up
clean up
bump
* fix ordering
* move to end
* unsigned
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
57156c4482
Chrysler: remove standstill exception for gas disengage ( #23515 )
...
* Chrysler: remove standstill exception for gas disengage
* remove test exception
* bump panda
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
cf9792dc53
Longcontrol: remove starting state ( #23328 )
...
* remove starting state
* new ref
* ready for merge
* try this
* cereal now on master
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
3 years ago
0148b233cd
Add comment about vEgoStarting to interfaces ( #23327 )
3 years ago
14bf834fef
Abstract classes inherit from ABC ( #23246 )
3 years ago
4f1eb4278a
Log actuators after applying rate limits in CarController ( #23230 )
...
* return actuators from carcontroller
* log it
* pass to latcontrol
* chrysler
* gm
* honda
* more brands
* rest of the brands
* gm cleanup
* hyundai cleanup
* update ref
* rename field
* fix subaru
* add types
* more subaru fixes #23240
* consistent whitespace
* bump cereal
3 years ago
2799ef5292
Remove minSpeedCan ( #22991 )
...
* Remove minCanSpeed
Remove minCanSpeed
* it actually only goes out to 2.5 seconds, this is okay to remove
* test to see if this preserves behavior
add minSpeedCan
* Revert "test to see if this preserves behavior"
This reverts commit 31b11f017f7e9da7654fc8064b5983d4a6cc22e5.
* preserve behavior (don't enter stopping as early)
* vEgoStopping needs to be less than or equal to vEgoStarting to avoid state oscillation
3 years ago
44adea73ce
fix max speed comments
3 years ago
e6180738fd
add CarParams.wheelSpeedFactor ( #23079 )
...
* add CarParams.wheelSpeedFactor
* Fudge speed for Lexus RX
* should have been the TSS2 model
* bump cereal
* refactor into function
* update refs
3 years ago
a0e5eccb70
Toyota: handle brake hold ( #22810 )
...
* disallow engagement if brake hold active
* we can check once
* move to common events
revert
* fix
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
b76ccaac37
better alerts for temporary EPS faults ( #22747 )
...
* better alerts for temporary EPS faults
* reorder
4 years ago
b49f518782
GM: EPS fault workaround ( #22404 )
...
* seems legit
* panda -> loopback
* fix comment
* add some "why" comments for the next guy
* re-test with stock 50Hz rate
* ugly test
* Update selfdrive/car/gm/carstate.py
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
* update refs
* Update selfdrive/car/gm/carstate.py
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
82ad6642e2
Quiet steer temp unavailable alert at standstill ( #22680 )
...
* only sound critical alert when not at standstill
* need to flip
* just change the one line
4 years ago
778374d3dd
[Lateral PID] Function for steer feedforward ( #22638 )
...
* store a function for steer feedforward
* use classmethod
Co-authored-by: Willem Melching <willem.melching@gmail.com>
4 years ago
3461e25944
Lateral PID: move steer feedforward to CarInterface ( #22411 )
...
* move steer feedforward to car interface, in car parameters
* LatControlPID.get_steer_feedforward()
4 years ago
417e229624
Add upper/lower bounds for longitudinal lag ( #22235 )
...
* Add upper/lower bounds for longitudinal lag
* add ref
* update ref
* bump cereal
* bump cereal
4 years ago
b7d1aac197
Parameterize longitudinal control using carParams ( #22200 )
...
* use CP.startAccel
* missing values
* order
* update ref
* cereal
4 years ago
1e62b09e5d
Use CP.vEgoStopping and clean up CP.startAccel ( #22199 )
...
* use CP.vEgoStopping and clean up
* update ref
4 years ago
74b6c87254
cleanup old nidec accel override logic ( #22181 )
...
* cleanup old nidec accel override logic
* add ref without deprecated fields
* no more override
4 years ago
b39f6efa3f
parameterize longitudinal actuator delay ( #22153 )
...
* paremetrize longitudinal actuator delay
* update ref
4 years ago
f941111dcd
Clean up PID controller ACCEL_MIN/ACCEL_MAX ( #22148 )
...
* use ISO 15622:2018 limits in PID controller
* allow more for nidec
* limit PID inputs
* CP is not needed
* add GM
* not used
* update ref
* fix honda bosch
4 years ago
ebf2a2279d
Prevent PID windup on Honda NIDEC ( #22112 )
...
* add higher set speed
* freeze when close to cruise
* dont bias this
* higher set speed
* start high
* 2mph might be needed
* better condition
* limit accel windup like this
* wrong name
4 years ago
1ac89f14aa
Change car controller interface from gas/brake to acceleration ( #21911 )
...
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
4 years ago
cb7e96f99d
rename enableCruise -> pcmCruise ( #21546 )
4 years ago
092c728e76
fix unnecessary harsh steering unavailable alerts ( #21541 )
4 years ago
6729e963c9
Honda: emulate convenience blinker from stalk ( #21387 )
...
* Honda: emulate convenience blinker from stalk
* comment
* light->lamp
* reset on rising edge
* update ref
4 years ago
a8fac002ae
Honda Bosch longitudinal prerequisites ( #21217 )
...
* untested changes
* set compute_gb
* community feature for good measure
* add code for rolling backwards
* init needs CarParams
* stay in elm mode until carParams is written
* fix tester present bus number
* fix can errors
* fix enableCruise flag
* print when radar disable is done
* move retry logic to controlsd
* move lookup table into carcontroller params
* cleanup brake error values
* make init return
* that should be 1
* floats
* back to no failure handling
* try simplify knockout
* bump panda
* Move flags to panda
* add warnings
* Revert "try simplify knockout"
This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.
* add note about LoC.long_control_state
* update ref
4 years ago
8071111f59
default carParams.stoppingControl to True ( #21248 )
...
* hyundai has full brake control
* set default stoppingControl to True
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
4 years ago
dc3d8f2ea2
add note about max speed
4 years ago
836668f105
less harsh steering unavailable alert when overriding ( #20718 )
...
* less harsh steering unavailable alert when overriding
* just steer
* 1s
* orange
* update refs
4 years ago
a0cdacbb2a
Do not allow engagement outside of training distribution ( #20112 )
...
* higher is out of the training distribution
* Update RELEASES.md
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
000bd226aa
Cereal cleanup ( #20003 )
...
* start cleanup
* fan speed
* cleanup dm
* fix cereal
* hwType -> pandaType
* update refs
* update refs
* bump cereal
* freeSpacePercent
* cereal master
4 years ago
717bc747c3
Parametrize startingBrakeRate ( #19511 )
...
* Parametrize startingBrakeRate
* new ref_commit
4 years ago
d3c2a0e6c1
Parametrize stoppingBrakeRate ( #2745 )
...
* Parametrize stoppingBrakeRate
* ref_commit updated
4 years ago
093456cc40
Parametrize MIN_CAN_SPEED in car interfaces ( #2684 )
...
* Parametrize MIN_CAN_SPEED in car interfaces
* fixed instance in planner.py
* fix typo
* var name change
* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files
* added default value to get_std_params, removed unneeded instances from car interface files
* Revert PEP8 autoformat corrections
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
40acdc4524
Typing experiments ( #1633 )
...
* add more types
* car
* no abc
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
47c21f10f5
grey panda is unsupported ( #2458 )
5 years ago
Shane Smiskol
HaraldSchafer
Adeeb Shihadeh
ClockeNessMnstr
Willem Melching
Jason Young
qadmus
Greg Hogan
Igor