* ban cereal and msgq
* common too
* do toyota/values.py
* do all fingerprints
* example without builder
* this still works, but no type checking anymore
* stash
* wtf, how does this work
* okay actually not bad
* safe
* epic!
* stash data_structures.py
* some clean up
* hell yeah
* clean up old file
* add to delete
* delete
This reverts commit 90239b7797.
* switch more CarParams stuff over
remove unused
* fix car tests by removing cereal! mypy forgets about dataclass if we wrap it :(
* fix this too
* fix this too
* remove more cereal and add some good hyundai tests
* bunch more typing
* override default with 20hz radar
* temp capnp converter helper
* more lateralTuning
* small union replicator is better than what i was trying, and fixes mypy dynamic typing issues
* can keep all this the same now!
* type ret: CarParams, add more missing structs, revert lateralTuning changes (smaller diff!)
* revert more
* get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :(
would have been `CarParams.NetworkLocation()`
* Revert "get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :("
This reverts commit bb28b228be.
* remove cereal from car_helpers (TODO: caching)
* remove a bunch of temp lines
* use dataclass_transform!
* remove some car.CarParams from the interfaces
* remove rest of car.CarParams from the interfaces
* same which() API
* sort
* from cereal/cache from fingerprinting!
* more typing
* dataclass to capnp helper for CarParams, cached it since it's kinda slow
* (partial) fix process replay fingerprintig for new API
* latcontrollers take capnp
* forgot this
* fix test_models
* fix unit tests
* not here
* VehicleModel and controller still takes capnp CP since they get it from Params()
* fix modeld test
* more fix
* need to namespace to structs, since CarState is both class and struct
* this was never in the base class?!
* clean that up again
* fix import error
fix import error
* cmts and more structs
* remove some more cereal from toyota + convert CarState to capnp
* bruh this was wrong
* replace more cereal
* EventName is one of the last things...
* replace a bunch more cereal.car
* missing imports
* more
* can fix this typing now
* proper toyota+others CS typing!
* mypy can detect return type of CS.update() now
* fix redeclaration of cruise_buttons type
* mypy is only complaining about events now
* temp fix
* add carControl struct
* replace CarControl
i hope there's no circular imports in hyundai's CC
* fine now
* lol this was wrong too
* fix crash
* include my failed attempts at recursively converting to dataclass (doesn't implicitly convert types/recursively :( )
but attrs does, maybe will switch in the future
* clean up
* try out attr.s for its converter (doesn't work recursively yet, but interesting!)
* Revert "try out attr.s for its converter (doesn't work recursively yet, but interesting!)"
This reverts commit ff2434f7bb.
* test processes doesn't fail anymore (on toyota)!
* fix honda crash
* stash
* Revert "stash"
This reverts commit c1762af4e7.
* remove a bunch more cereal!
* LET'S GOOO
* fix these tests
* and these
* and that
* stash, something is wrong with hyundai enable
* Revert "stash, something is wrong with hyundai enable"
This reverts commit 39cf327def.
* forgot these
* remove cereal from fw_versions
* Revert "remove cereal from fw_versions"
This reverts commit 232b37cd40.
* remove rest of the cereal exceptions!
* fix that
* add typing to radard since I didn't realize RI.update() switched from cereal to structs
* and here too!
* add TODO for slots
* needed CS to be capnp, fix comparisons, and type hint car_specific so it's easier to catch type issues (capnp isn't detected by mypy :( )
* remove the struct converter
* save ~4-5% CPU at 100hz, we don't modify after so no need to deepcopy
btw pickle.loads(pickle.dumps()) is faster by ~1% CPU
* deepcopy -> copy: we can technically make a reference, but copy is almost free and less error-prone
saves ~1% CPU
* add non-copying asdict function
* should save ~3% CPU (still 4% above baseline)
* fix that, no dict support
* ~27% decrease in time for 20k iterations on 3X (3.37857 -> 2.4821s)
* give a better name
* fix
* dont support none, capitalize
* sheesh, this called type() on every field
* remove CS.events, clean up
* bump card %
* this was a bug on master!
* add a which enum
* default to pid
* revert
* update refs
* not needed, but consistent
* just Ecu
* don't need to do this in this pr
* clean up
* no cast
* consistent typing
* rm
* fix
* can do this if we're desperate for the last few %
* Revert "can do this if we're desperate for the last few %"
This reverts commit 18e11ac788.
* type this
* don't need to convert carControl
* i guess don't support set either
* fix CP type hint
* simplify that
* ban all of common & copy numpy_fast
* add numpy_fast
* these are okay
* and ban controls
* better name
* Conversions
* do utils, kalman
* clean up
* sorting
* don't forget
* Reapply "selfdrive/car: ban imports from external modules" (#32993)
This reverts commit 35a4a773f1.
* controls will just use controls
* also these
* ignore
* format card
* standalone process
* no class member CS, there's no point
also can be confusing; what else could be using this?
* rename CoS
* Update selfdrive/controls/controlsd.py
* never works first time :D
* canRcvTimeout is bool
* hack
* add cpu
* see what testing closet comes up with
* first
* some clean up
* support passable CI, fix test models
* fix startup alert
* process replay changes
* test_fuzzy
* gate carOutput valid on carControl valid
* we should publish after we update carOutput
* controlsd was using actuatorsOutput from 2 frames ago for torque, not the most up to date
* check all checks for carControl in case controlsd dies
* log more timestamps
* more generic latency logger; needs some clean up
latency_logger.py was difficult to understand and modify
* card polls on can and carControl to get latest carControl possible
* temp try to send earlier
* add log
* remove latencylogger
* no mpld3!
* old loop
* detect first event
* normal send
* revert "card polls on can and carControl to get latest carControl possible"
how it was is best
* sheesh! update should be first
* first timestamp
* temp comment ( timestamp is slow :( )
* more final ordering, and make polling on/off test repeatable
* Received can
* new plot timestamps
* clean up
* no poll
* add controllers (draft)
* Revert "add controllers (draft)"
This reverts commit e2c3f01b2f.
* fix that
* conventions
* just use CS
* consider controlsd state machine in card: not fully done
* hmm it's just becoming controlsd
* rm debugging
* Revert "hmm it's just becoming controlsd"
This reverts commit 534a357ee9.
* Revert "just use CS"
This reverts commit 9fa7406f30.
* add vCruise
* migrate car state
* Revert "migrate car state"
This reverts commit 4ae86ca163.
* Revert "add vCruise"
This reverts commit af247a8da4.
* simple state machine in card (doesn't work as is)
* Revert "simple state machine in card (doesn't work as is)"
This reverts commit b4af8a9b0a.
* poll carState without conflate
* bump
* remove state transition
* fix
* update refs
* ignore cumLagMs and don't ignore valid
* fix controls mismatch; controlsd used to set alt exp
* controlsd_config_callback not needed for card
* revert ref temp
* update refs
* no poll
* not builder!
* test fix
* need to migrate initialized
* CC will be a reader
* more as_reader!
* fix None
* init after publish like before - no real difference
* controlsd clean up
* remove redundant check and check passive for init
* stash
* flip
* migrate missing carOutput for controlsd
* Update ref_commit
* bump cereal
* comment
* no class params
* no class
* Revert "no class"
This reverts commit 5499b83c2d.
* add todo
* regen and update refs
* fix
* update refs
* and fix that
* should be controlsstate
* remove controlsState migration
CoS.initialized isn't needed yet
* fix
* flip!
* bump
* fix that
* update refs
* fix
* if canValid goes false, controlsd would still send
* bump
* rm diff
* need to be very careful with initializing
* update refs
* draft
* bump opendbc
* still draft
* that's not right
* superset of the changes, 33hz
* cleanup
* this should work
* remove line
* pass it in again
* actually no need to check updated now
* now_nanos
* consistent name
* fix replay
* one line isn't that bad
switch
switch
* fix CarController tests
* Update ref_commit
* Reliable relay open
* Reliable relay close
* ign in a loop
* fixes
* we need this
* log
* comment to remind me tmrw
* ign fix
* this makes it 2x more reliable, but messyyy
* Revert "this makes it 2x more reliable, but messyyy"
This reverts commit 03401dc4a7.
* revert non-related stuff
* comments, spaces
* a stands for indefinite article
* not applicable for non-camera acc
* something...
* Revert "something..."
This reverts commit de8a158488.
* Update ref_commit
* stash
* more test
* less test
* clean test
* no angle
* add tolerance
* fix gm
fix gm
* test both
* lower some rates on hkg
* stash
* simpler
* bump panda
* Revert "bump panda"
This reverts commit f2137c2211.
* only torque
* make kona pass
* duplicate __init__
* move
* half clean up
* half clean up
* more clean up
* more clean up
* fix static analysis
* calculate over 0.5 seconds
* limit to max steer
* type annotation
* calc once
* put gm camera voacc behind disable radar toggle
* bump panda
* bump panda
* bump panda
* experimental long
* fixes
* car control notes and fixes for Bolt EUV
* might enable stop and go
* consistent name
* min enable speed seems to be around 5 kph
* camera acc can engage under 5 kph if stopped
* comment
* comment
* remove this for now
* only real brake
* comments
* update max brake
* bump
* clean up/fix
* same if
* simplify
* fix
* old comment
* no brake_pressed
* temporary fault fix
* tune longitudinal
* update docs
* bump panda
* GM camera ACC cars have no regen in ACC
* cleaner
* cleaner
* fix
* set max gas
* fixes
* fix LKAS unavailable warning from camera
* only camera
* bump panda
* bump panda
* bump panda
* bump panda
* clean up gmcan
* clean up CC
* flip
* rm
* rm comment
* clean up
* custom starting/stopping probably not needed
* Update selfdrive/car/gm/carcontroller.py
* fix crash
* long tuning
* we need long control state to resume
* CAMERA_ACC_CAR not needed
* no interp on accel
* tuning
* formatting
* formatting
* formatting
* formatting
* formatting
* no need to init ccp
* makes more sense now
* send at 10hz when inactive
* try to make it fine to switch rates
* fix rate
* todododo
* fine if we skip, we usually send too early
* clean up
* this may be required, 50Hz is not really needed to sync/initialize
* preserves previous behavior (not sure if this makes sense)
* Revert "preserves previous behavior (not sure if this makes sense)"
This reverts commit 3b297bca72.
* Revert "this may be required, 50Hz is not really needed to sync/initialize"
This reverts commit a6b4693814.
* rm com
* Update ref_commit
* gate behind GM Cam
* common logic
* bet
* update refs
* add delay to GM camera ACC cancel to avoid FCW and cruise fault
* we can revert brake pressed threshold now
* bump panda
* add proper threshold
* bump
* bujmp panda
* add all signals
* try to forward this PSCMStatus
* fixes
* see if this works
* modify checksum when bit flipped
* bump opendbc
* so i can test without restarting
* bump
* bump panda
* clean up
* comment
* also fix this
* bump
* bump
* every 5 seconds
* only send our values
* fix
* try sending everything again (+1 counter)
* revert
* revert, forward msg
* forward
* fix that
* bump panda
* bump panda
* fine to not copy
* after cancel, pass bus
* fix
* Revert "fine to not copy"
This reverts commit 654ac1a7da.
* GM camera ACC: no faults on start up 2.0
And by 2.0 I mean we don't need to wait for blocked msg support to be merged first to merge this without regressing accidental single blocked msg count handling.
* Send the camera counter + 1
* Keep updating the first counter until we get a message on the bus
* Only update right before sending so sent_lka_steering_cmd is updated first
* Update ref_commit
* Switch to ECMPRDNL2 for GM gear
* Removing manumatic gear #
* values.py almost complete
* Silverado and Bolt EUV val and CP
* GM controller updated
* Cam hrns supp done (in theory)
* cleanup for new cars
* Remove extra constant
* WS, etc cleanup
* removing the unused
* Fix kpBP typo
* Updated docs
* Skip's PIF tune
* Dropped LKA CAN error patch
* Add silverado sigmoid ff
* CAN Err & LKA latch patch
* Remove EPS fault fix (another PR)
* Remove Silverado (another PR)
* clean up some common params
* Remove Escalade FP
Remove Escalade FP
* comment
* Premier is just a trim
Premier is just a trim
Premier is just a trim
* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera
* clean up
clean up
* bump panda
* bump panda
* bump panda
* bump panda
* bump panda
* remove comments
* try spamming buttons on bus 2
* bump panda
* bumping opendbc w btn rc
* not needed for this port
This reverts commit 6af1f0ba79.
* add button safety
* Send next rc when spamming btns
* forward other signals in message
* missing DriveModeButton
* fill cruiseState.speed
* see if resume works without counter
* try the whole message
* send immediately and at 10Hz
* no resume, back to just button signal
* even holding random buttons it cancels
* Use torque controller with base tune
* stock long GM don't auto-resume yet
* Testing GM zero min steer speed
* Revert latcontrol
* revert opendbc
* latActive is basically lkas_enabled
* Update Bolt torque params
* comment
* clean up
* Add to releases
* Add test route
* Don't specify segment
* bump panda
* bump panda
* no harness for Bolt just yet
* Apply suggestions from code review
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* We support all and 2023
* move safetyParam up to first cam check
* Bump panda and update docs
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* GM: separate EV/ICE gas/brake lookup tables
* removed blank line
* V are the same
* comment
better ordering
comment
comment
* Add some delay for the laggy brakes
Add some delay for the laggy brakes
* move actuator to only acadia
* start braking at 0 m/s/s
* Revert "start braking at 0 m/s/s"
This reverts commit 55c1dee733.
* add delay for escalade
* revert EV changes
* Update selfdrive/car/gm/carcontroller.py
* comment
* only ACADIA
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Interface radarOffCan set, comments
* pass pcmCruise value to common events
* add transType and networkLoc to iface
* carstate use transtype to detect EV
* ctrl: limit sends by config
* Add clarifying comments for new vals
* clean up
* comment on new line
* these have the same frequency
* remove 25hz
* add to upper comment
* update refs
* update refs
* move into same block
move into same block
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* do tesla
* parentheses
* Do Chrysler
* Make sure Hyundai long never actuates when long inactive
.
* clean up Hyundai
* more clear
* formatting
* Stock sets these to zero
* fix params
* move jerk logic into CC
clean up
* proof of concept
* actuators packet describes which actuators are active
* bump cereal
* fixes
* not needed for this PR
* Do Toyota
* add back controlsState.active
* bump cereal
* rest of cars
* in actuators
* add active back
* which
* use controlsState.active for now
* will make an issue
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* move local lat_active checks into CC.latActive
* remove redundant checks
* move comment
move comment
* fix joystick mode
* get enabled from carcontrol
* do standstill check in controlsd
* make sure we consider the gas press case for GM
* use CC.actuators
* fix
* capitalization
* Bump cereal
Bump cereal
* make intermediate actuators
* similar convention to before
* clean that up
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* check in tuple instead of list
* Update selfdrive/car/toyota/carcontroller.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Update selfdrive/car/mazda/interface.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Shane Smiskol
Dean Lee
Jason Wen
Justin Newberry
Adeeb Shihadeh
Jason Shuler
Tim Wilson
Willem Melching
Jason Young
HaraldSchafer