3789587df1
add alert for CAN bus timeout ( #24162 )
...
* add alert for CAN bus timeout
* add alert
* set in interface
* cleanup
* cleanup
* add event
* fix mock
* bump
* bump opendbc
* update refs
* return reader
old-commit-hash: 49c2164814
3 years ago
60c3bb2da3
add mpld3 python pacakge ( #24138 )
...
* add mpld3 python pacakge
* move to dev
* fix for new pylint
old-commit-hash: 6013d733a3
3 years ago
474ba19c81
Add Disengage on Accelerator Toggle ( #23977 )
...
* Squashed commit of the following:
commit 953bcf0ecf8d03f0fec9ce0d5442cc660ae2347d
Merge: b4198608d efd04715e
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 1 19:58:06 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit b4198608dac9595bfeb9443f95cd6c5d385cd62d
Merge: 24f90b2c8 0e983562d
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 1 14:32:54 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 24f90b2c8d6ae509c0776b6e33b743467aa08dee
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 31 14:07:52 2022 -0700
revert changes and get ready for override
commit aa514df6b5e8431f0faa07f6b25eb5cb6c9f2749
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 20:52:24 2022 -0700
temporary
commit c874e10c2555968c683f629c4582ab22e51d431f
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 00:30:13 2022 -0700
move gasPressed to controlsd
commit fe670439dff5bc6dfc5963d79ca2febe0c5920c7
Merge: 49d3b6d11 c78701e47
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 30 00:15:48 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 49d3b6d1162893fa94b2294152f0718eeb4698ed
Merge: 475b27e74 3e819bc5a
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon Mar 28 13:06:08 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 475b27e74fd6479f1d148e9ded1eca6ee476865c
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 20:24:59 2022 -0700
update SAFETY.md
commit 0798eadb82749e12ecbaa86f4e57b21bd3dbc7e8
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 17:52:06 2022 -0700
⛽ ➡️ 🔋
bump
commit d2b64b89cf8d7265bc90848b4e3a2276c9a4cb78
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:19:34 2022 -0700
these changes will be in border PR
these changes will be border PR
commit bed31e63de2244c161729773978fef8a9246ddb5
Merge: 491417640 603e07793
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:17:31 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 49141764098e3a701ff123ead52de4656b31db4d
Merge: 9291e9f00 46ed8bb8e
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 23 19:00:26 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 9291e9f0045780669b2ffa7f08fb10373c03b070
Merge: 2aed64157 2c947f193
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 18 19:03:13 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit 2aed64157d6e9dc993d103a2c6abf7e643410562
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 18 19:03:03 2022 -0700
Revert "send pre-enable state when gas is pressed"
This reverts commit 8d82e697dc2efade307413e767d14b56b4d2d079.
commit a219defe5342efa731a957b2ff4fd86292c1f239
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 17 12:50:46 2022 -0700
bump cereal
commit 8d82e697dc2efade307413e767d14b56b4d2d079
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 16 22:40:13 2022 -0700
send pre-enable state when gas is pressed
formatting and it's out
forgot one
allow gas press
show toggle
revert changes
revert changes
commit 5eb4d1ab1b77ac65bdd901f692ebfb848d5187ca
Merge: bad1bdc74 d0ef25959
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 16 22:29:43 2022 -0700
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
commit bad1bdc7428c5d8a4a765b259da504f0ade84424
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 23:03:56 2022 -0700
clean up a bit
commit 7516ed9b786536a07f00a92b9c1742ca252a01d1
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:55:09 2022 -0700
these are null checks right now
commit 408f5f1d633521b29b08d966c9b387fa79dff0d6
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:51:14 2022 -0700
should work
commit be1978e29c03d8843cf073cc9ddf84020fd2b378
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:36:16 2022 -0700
stash
commit f0bd4c47e9d27061c6cd3b88765a7c10995f42db
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 15 22:26:24 2022 -0700
this was flipped
commit d5b6e30389a727e8559331acd706422e1b246f60
Merge: 820b19894820b19894991763f9ff91763f9ff4🔥
commit 1885c9e2ba1f591736a1f591736a2465811f0b465811f0b40344363a53700efcb3f700efcb3f4220ce272fed273bb78ac1a85afd60ce3be32afc2f27203af3a04c0ad1a5499cf13caeb2230254ca787475e02cbf1f40c117a
3 years ago
53fff66742
bump cereal
...
old-commit-hash: ca3171c0f9
3 years ago
d42962014c
CarParams: remove max steer ( #24044 )
...
* Remove max steer
* Update ref
old-commit-hash: adf34c3414
3 years ago
3327348aeb
don't read params in car interfaces ( #23978 )
...
old-commit-hash: bae78dd46b
3 years ago
ca394949cc
Move gas/brake pedal event logic to controlsd ( #23850 )
...
* move some state machine logic to controlsd
move some state machine logic to controlsd
* same order
same order
* move unsafeMode up
* disable at standstill
* save last CS
save last CS
* do we need to copy at all?
* don't copy
* rename
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Revert "Update selfdrive/controls/controlsd.py"
This reverts commit 10bb51a0f05fe00fb773
3 years ago
94e02bcb3f
add parkingBrake to carState ( #23968 )
...
* add parkingBrake to carState
* fix gm
old-commit-hash: ae19308e83
3 years ago
ec47e0fef0
break up selfdrive.config ( #23959 )
...
* break up selfdrive.config
* add to release files
* fix import order
old-commit-hash: 5c3f3e44bc
3 years ago
83e26d674f
LongControl: fix control state oscillation ( #23333 )
...
* check if plan is to accelerate or not
* remove comment
* needed to see it
needed to see it
* test logic with Toyota TSS2
* hackily log conditions
* Revert "hackily log conditions"
This reverts commit 7a6b5691e2b982c7a1e3911d980fb7530647affd.
Revert "test logic with Toyota TSS2"
This reverts commit e583d6e3caaa5f5b896165cd7949dfc1caabfd9a.
order
* revert
* fix
old-commit-hash: 7254db3906
3 years ago
63bbcd7279
better steer fault names ( #23890 )
...
* better steer fault names
* bump cereal
old-commit-hash: 87849f93b1
3 years ago
1f5570a96d
Longitudinal control: interpolate longitudinal plan ( #23787 )
...
* interpolate longitudinal actuator delay
rename
* formatting
* interpolate v_target most importantly!
* fix interpolation and rename
* nicer setup
* left in from testing
* update refs
old-commit-hash: 2c7845fce0
3 years ago
c12656f397
Longitudinal: add Kf to carParams ( #23752 )
...
* sane_kf
* long_kf + cereal
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9535dc606d
3 years ago
a2f9ac2b5e
unsafe mode: update safety declaration comment ( #23753 )
...
* update safety declaration comment
* whoops
old-commit-hash: 7410160d09
3 years ago
9f202e63f5
clip steer saturation counter to steerLimitTimer ( #23638 )
...
* clip steer saturation counter to steerLimitTimer
* update ref
old-commit-hash: ee71fd2fcc
3 years ago
183715ccea
controlsd: verify unsafe mode consistency ( #23563 )
...
* add unsafe mode check to controlsd
bump submodules
forgot to add to health_t struct
bump
ahh forgot to set it!
bump
bump
clean up
clean up
bump
* fix ordering
* move to end
* unsigned
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 31d147dca2
3 years ago
b32725c94f
Chrysler: remove standstill exception for gas disengage ( #23515 )
...
* Chrysler: remove standstill exception for gas disengage
* remove test exception
* bump panda
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 57156c4482
3 years ago
d05c173fe6
Longcontrol: remove starting state ( #23328 )
...
* remove starting state
* new ref
* ready for merge
* try this
* cereal now on master
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: cf9792dc53
3 years ago
4058a8f64f
Add comment about vEgoStarting to interfaces ( #23327 )
...
old-commit-hash: 0148b233cd
3 years ago
686a38aea4
Abstract classes inherit from ABC ( #23246 )
...
old-commit-hash: 14bf834fef
3 years ago
7b3e330def
Log actuators after applying rate limits in CarController ( #23230 )
...
* return actuators from carcontroller
* log it
* pass to latcontrol
* chrysler
* gm
* honda
* more brands
* rest of the brands
* gm cleanup
* hyundai cleanup
* update ref
* rename field
* fix subaru
* add types
* more subaru fixes #23240
* consistent whitespace
* bump cereal
old-commit-hash: 4f1eb4278a
3 years ago
91ff6918e5
Remove minSpeedCan ( #22991 )
...
* Remove minCanSpeed
Remove minCanSpeed
* it actually only goes out to 2.5 seconds, this is okay to remove
* test to see if this preserves behavior
add minSpeedCan
* Revert "test to see if this preserves behavior"
This reverts commit 31b11f017f7e9da7654fc8064b5983d4a6cc22e5.
* preserve behavior (don't enter stopping as early)
* vEgoStopping needs to be less than or equal to vEgoStarting to avoid state oscillation
old-commit-hash: 2799ef5292
3 years ago
cf3c8cd301
fix max speed comments
...
old-commit-hash: 44adea73ce
3 years ago
b8ab21bd64
add CarParams.wheelSpeedFactor ( #23079 )
...
* add CarParams.wheelSpeedFactor
* Fudge speed for Lexus RX
* should have been the TSS2 model
* bump cereal
* refactor into function
* update refs
old-commit-hash: e6180738fd
3 years ago
8472503305
Toyota: handle brake hold ( #22810 )
...
* disallow engagement if brake hold active
* we can check once
* move to common events
revert
* fix
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a0e5eccb70
4 years ago
f5a382ce03
better alerts for temporary EPS faults ( #22747 )
...
* better alerts for temporary EPS faults
* reorder
old-commit-hash: b76ccaac37
4 years ago
a399abf438
GM: EPS fault workaround ( #22404 )
...
* seems legit
* panda -> loopback
* fix comment
* add some "why" comments for the next guy
* re-test with stock 50Hz rate
* ugly test
* Update selfdrive/car/gm/carstate.py
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
* update refs
* Update selfdrive/car/gm/carstate.py
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b49f518782
4 years ago
263b37364c
Quiet steer temp unavailable alert at standstill ( #22680 )
...
* only sound critical alert when not at standstill
* need to flip
* just change the one line
old-commit-hash: 82ad6642e2
4 years ago
dcf3fc2089
[Lateral PID] Function for steer feedforward ( #22638 )
...
* store a function for steer feedforward
* use classmethod
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 778374d3dd
4 years ago
810e859169
Lateral PID: move steer feedforward to CarInterface ( #22411 )
...
* move steer feedforward to car interface, in car parameters
* LatControlPID.get_steer_feedforward()
old-commit-hash: 3461e25944
4 years ago
d688b62c62
Add upper/lower bounds for longitudinal lag ( #22235 )
...
* Add upper/lower bounds for longitudinal lag
* add ref
* update ref
* bump cereal
* bump cereal
old-commit-hash: 417e229624
4 years ago
523219c678
Parameterize longitudinal control using carParams ( #22200 )
...
* use CP.startAccel
* missing values
* order
* update ref
* cereal
old-commit-hash: b7d1aac197
4 years ago
b079219b93
Use CP.vEgoStopping and clean up CP.startAccel ( #22199 )
...
* use CP.vEgoStopping and clean up
* update ref
old-commit-hash: 1e62b09e5d
4 years ago
cb1cd01bdf
cleanup old nidec accel override logic ( #22181 )
...
* cleanup old nidec accel override logic
* add ref without deprecated fields
* no more override
old-commit-hash: 74b6c87254
4 years ago
977cf8ca02
parameterize longitudinal actuator delay ( #22153 )
...
* paremetrize longitudinal actuator delay
* update ref
old-commit-hash: b39f6efa3f
4 years ago
6f5c9d5ad1
Clean up PID controller ACCEL_MIN/ACCEL_MAX ( #22148 )
...
* use ISO 15622:2018 limits in PID controller
* allow more for nidec
* limit PID inputs
* CP is not needed
* add GM
* not used
* update ref
* fix honda bosch
old-commit-hash: f941111dcd
4 years ago
1b98341932
Prevent PID windup on Honda NIDEC ( #22112 )
...
* add higher set speed
* freeze when close to cruise
* dont bias this
* higher set speed
* start high
* 2mph might be needed
* better condition
* limit accel windup like this
* wrong name
old-commit-hash: ebf2a2279d
4 years ago
a73a820338
Change car controller interface from gas/brake to acceleration ( #21911 )
...
* retune civic
* seems smooth
* back to normal
* new ref
* fix conflict
* runs
* rm
* accel scale is 4
* toyota should be good
* more cleanup
* fixup
* better naming
* update ref
* deprecated
* sending brake when not enable causes a fault
* rm gas and brake
* unused
* update ref
* acura logic is no more
* wrong before
* revert tuning cleanup
* adress comments
* update ref
* already on master
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa
4 years ago
b7c1b9a6e8
rename enableCruise -> pcmCruise ( #21546 )
...
old-commit-hash: cb7e96f99d
4 years ago
4b79c86b5f
fix unnecessary harsh steering unavailable alerts ( #21541 )
...
old-commit-hash: 092c728e76
4 years ago
c3cc9e8eeb
Honda: emulate convenience blinker from stalk ( #21387 )
...
* Honda: emulate convenience blinker from stalk
* comment
* light->lamp
* reset on rising edge
* update ref
old-commit-hash: 6729e963c9
4 years ago
5bc0d28708
Honda Bosch longitudinal prerequisites ( #21217 )
...
* untested changes
* set compute_gb
* community feature for good measure
* add code for rolling backwards
* init needs CarParams
* stay in elm mode until carParams is written
* fix tester present bus number
* fix can errors
* fix enableCruise flag
* print when radar disable is done
* move retry logic to controlsd
* move lookup table into carcontroller params
* cleanup brake error values
* make init return
* that should be 1
* floats
* back to no failure handling
* try simplify knockout
* bump panda
* Move flags to panda
* add warnings
* Revert "try simplify knockout"
This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.
* add note about LoC.long_control_state
* update ref
old-commit-hash: a8fac002ae
4 years ago
d0e5f3fb92
default carParams.stoppingControl to True ( #21248 )
...
* hyundai has full brake control
* set default stoppingControl to True
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 8071111f59
4 years ago
646ed50060
add note about max speed
...
old-commit-hash: dc3d8f2ea2
4 years ago
cc29fdfed2
less harsh steering unavailable alert when overriding ( #20718 )
...
* less harsh steering unavailable alert when overriding
* just steer
* 1s
* orange
* update refs
old-commit-hash: 836668f105
4 years ago
df9381abd4
Do not allow engagement outside of training distribution ( #20112 )
...
* higher is out of the training distribution
* Update RELEASES.md
* Update RELEASES.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a0cdacbb2a
4 years ago
966945880b
Cereal cleanup ( #20003 )
...
* start cleanup
* fan speed
* cleanup dm
* fix cereal
* hwType -> pandaType
* update refs
* update refs
* bump cereal
* freeSpacePercent
* cereal master
old-commit-hash: 000bd226aa
4 years ago
8bc42f4aff
Parametrize startingBrakeRate ( #19511 )
...
* Parametrize startingBrakeRate
* new ref_commit
old-commit-hash: 717bc747c3
4 years ago
faa4c57ee1
Parametrize stoppingBrakeRate ( #2745 )
...
* Parametrize stoppingBrakeRate
* ref_commit updated
old-commit-hash: d3c2a0e6c1
4 years ago
95bb79c51c
Parametrize MIN_CAN_SPEED in car interfaces ( #2684 )
...
* Parametrize MIN_CAN_SPEED in car interfaces
* fixed instance in planner.py
* fix typo
* var name change
* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files
* added default value to get_std_params, removed unneeded instances from car interface files
* Revert PEP8 autoformat corrections
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 093456cc40
4 years ago
Adeeb Shihadeh
Shane Smiskol
HaraldSchafer
ClockeNessMnstr
Willem Melching
Jason Young
qadmus
Greg Hogan
Igor