* should be all that's required
* try using rx_addr (should be the same)
* log bus
* bump cereal
* remove debugging
* bump cereal to master
* rm line
* add printing to offline debug script
* Try to fingerprint on all possible combinations
* build_fw_dict creates set dict, tries each fw version for addr, subaddr
* clean up
* static analysis
* comment
* fix comment
* revert changes to test_fw_query_on_routes
* remove comment
* Chrylser FPv2
* Update fw_versions.py
* formatting and remove default
* fix rx offset
* move to end
* add fw versions
* this won't be fingerprinted on as it returns from Mazda
* only log FW versions
* add type annotation
* fix typing
* Skip if FW versions are for read/request-only
* Fix crash if no fw versions
Fix crash if no fw versions
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* only send valid/needed queries
* just do volkswagen
* clean up
* add parameter name
clean up
* add test for whitelist
* rename
* Update selfdrive/car/fw_versions.py
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
* fix test
* log response addresses
* bump cereal
* handle response pending with IsoTpParallelQuery
* remove response pending stuff
* temporarily disregard cache for easier testing
* revert this
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
* get_fw_versions returns all fw versions with request's brand
* keep track of everything received
* debug
* need to regen or write a hack in build_fw_dict
* to be safe, still replace old responses within same brands (hyundai responds to two queries, can fix later)
to be safe, still replace old responses within same brands (hyundai responds to two queries, can fix later)
* update test_fw_query_on_routes
* clean up
* better name
* slightly cleaner
* fix test_startup unit test
del
* fix imports
* fix test_fw_fingerprint
fix test_fw_fingerprint
fix
* fingerprint on all FW_VERSIONS, not just brands with requests
* support old routes in test_fw_query_on_routes
* regen and update refs
* similar function style to before
* better comment
* space
switch name
* try to exact match first
* useless else
* fix debug script
* simpler dictionary
* bump cereal to master
* eliminate brands based on ECUs that respond to tester present
* make it work
* Add type hint for can message
Use make_can_msg
* Only query for addresses in fingerprints, and account for different busses
* These need to be addresses, not response addresses
* We need to listen to response addresses, not query addresses
* add to files_common
* Unused Optional
Drain sock raw
* add logging
* only query essential ecus
comments
* simplify get_brand_candidates(), keep track of multiple request variants per make and request each subaddress
* fixes
make dat bytes
bus is src
Fix check
* (addr, subaddr, bus) can be common across brands, add a match to each brand
* fix length
* query subaddrs in sequence
* fix
* candidate if a platform is a subset of responding ecu addresses
comment
comment
* do logging for shadow mode
* log responses so we can calculate candidates offline
* get has_subaddress from response set
* one liner
* fix mypy
* set to default at top
* always log for now
* log to make sure it's taking exactly timeout time
* import time
* fix logging
* 0.1 timeout
* clean up
Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
* only send valid/needed queries
* just do volkswagen
* clean up
* add parameter name
clean up
* add test for whitelist
* rename
* Update selfdrive/car/fw_versions.py
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
* fix test
* log response addresses
* bump cereal
* handle response pending with IsoTpParallelQuery
* remove response pending stuff
* temporarily disregard cache for easier testing
* revert this
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
* log fw query response offset
* one line still
* log request bytes as well
* bump cereal
* prettier order
* bump cereal
* I wonder if the radar sends a response pending...
debug
dont cache
fix
debug
* Revert "I wonder if the radar sends a response pending..."
This reverts commit 12a9552c27.
* log addr too
* bump cereal
* non-essential ECU for logging
* bump cereal
* debug ECU
* match_fw_to_car_exact
* comment
* version instead of board date
* add old compatible value
* update_refs
* check in tuple instead of list
* Update selfdrive/car/toyota/carcontroller.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Update selfdrive/car/mazda/interface.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* Add Subaru FPv2 support
* Add Subaru Ascent and Impreza FPv2 values
* Remove 10 second delay, use UDS for Subaru FPv2
* before VW
* before hyundai
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default
Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
* Convert all text strings to f-strings
Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.
Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.
F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale
* revert pyextra changes
* revert ublox.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
* start to separate Avalon 2019+
* reverts #20824 (2020)...
and removes fw from a 2020 avalon
* revert 2020 fw from #20241
* revert 2021 fw from #19790
* bump opendbc, add smartDsu
* Add only removed fw from listed PRs above and from jryan's 2020
* bump opendbc to master
* comment out any non-original avalon fw
* new fw
* these 2016 (5 byte EPS_STATUS msg) Avalon fws are correct. comment out any 2019+ fw I haven't seen yet
* Add to release files
* these are good too
* nothing on 7e0 yet
* both have their engines on one address
* validated remaining fws! some from adeeb's, chris's, and kumar's PRs
* Add test route for Avalon 2019
* horrible
* Duplicate
* use nodsu dbc. Only difference is the addition of some signals that don't work, and max of BRAKE_PRESSURE is different
* Enablem 2019 Avalon test route
* Fuzzy match on 3+ ECUs
* reuse dict
* exclude some shared ecus to be sure
* show alert for fuzzy match
* use title case
* require community toggle
* refactor
* do both exact and fuzzy in test script
* update test script
* add fuzz test and lower matches to >= 2
* strip alert length
* sort mismatches
* add fw tests to test_startup
* bump cereal
* FPv2 support for MQB
* Comment touch-ups
* Trim extra newlines
* Add Atlas and Tiguan
* Update submodule ref
* Revert "Add Atlas and Tiguan"
This reverts commit a47bc1bca7.
* Curb my enthusiasm
* Drop ABS/ESP from UDS fingerprinting for now
* Use multi-query to grab SW build ID and parameterization
* Resolve merge oops
* Resolve merge conflicts
* Make Ecu.fwdCamera optional for VW
* Where'd that come from?
* Propitiate process replay checks until ready for model dump
* FW values for Audi A3 Prestige
* Revert "Make Ecu.fwdCamera optional for VW"
This reverts commit 56852b99
* Don't try to FP fwdCamera for VW
* Remove FW comments
* Simplify RX offset handling
* Corrected scoping for MQB trans detection
* Add default response_offset
* Remove explicit list of MQB vehicles for now
* Deal with pylint warning
* Clarify and simplify comments
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* hyundai fw query
* Change query
* this works
* That is not engine
* hyundai fw query
* Change query
* this works
* That is not engine
* Skip FW query in test_car_models
* Those routes don't fingerprint properly after speedup
* only send toyota queries to subaddresses
Co-authored-by: openpilot laptop <laptop@comma.ai>
Shane Smiskol
Cameron Clough
Greg Hogan
realfast
Adeeb Shihadeh
Igor Biletskyy
Dean Lee
martinl
Ewout ter Hoeven
Willem Melching
robin-reckmann
arfy slowy
Jafar Al-Gharaibeh
Erich Moraga
Gabor
Jason Young
openpilot laptop
jpancotti