e3d3fd0230
Common button enable/cancel event creation ( #25445 )
...
* handle button presses in create_common_events
* remove from imports
* Handle
* Fix Honda (it hardcodes pcmCruise)
* Update selfdrive/car/volkswagen/interface.py
* Update selfdrive/car/volkswagen/interface.py
3 years ago
b6910923d1
vEgoCluster: fix starting from stop ( #25350 )
...
* we can't switch back and forth
* update translations
3 years ago
2351ae48b9
Ford: fix gear parsing ( #25267 )
...
* Ford: fix gear shifter state
* Ford: manumatic is drive
* add full gear names to CarStateBase
* fix for unrecognised gears
* Update interfaces.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
c3e95d5e19
prereq for matching speeds shown on cars dash ( #25222 )
...
* prereq for matching speeds shown on cars dash
* also handle fallback in the ui for replay
* update translations
* update ref
3 years ago
bdfaa1d1ee
Ram 1500 torque tune ( #25117 )
...
* torque control again
* 3mss per s
* no bad sensors
* tweaks
* Need more checks before we can do this
* update refs
* only ram for now
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
10fb2b9456
Speed up YAML parsing with CSafeLoader ( #24958 )
...
Use CSafeLoader
3 years ago
062a8bcdbd
cleanup torque tuning config ( #24951 )
3 years ago
d8bfe2f005
Cleanup car interfaces ( #24948 )
...
* remove interface overrides
* Fix test
* set torque tune for ev6
3 years ago
2deaf69789
Refactor torque stuff ( #24921 )
...
* Refactor torque stuff
* Add to release
* Add substitute and override
* Maxlataccel is required
* Add to asserts
* add ideal car
* Need china too
* yamls already linted
* Fixed some bugs
* Fixup
* Unreliable data
* Add cehck
* Better comment
* ref commit update
3 years ago
3066ad81a8
Car interface: set max lateral torque from table ( #24789 )
...
* json
* better naem
* Read from table
* formatting and default to nan
* Generate docs
* Read from table
* this should be the same
* Prius v is full
* test we always set the tunes correctly
add to release files
* Set for all cars
Set for all cars
* Revert tuning changes
Revert tuning changes
* remove that
* fixes
* update ref commit for new maxLateralAccels
Co-authored-by: Shane Smiskol <shane@smiskol.com>
3 years ago
c6bc03311c
Car documentation: set steering torque star using car interface ( #24709 )
...
* Set good torque using torque controller tuning
* should be equal to
* save lateral accel to car params
* use maxLateralAccel
* always
* same convention
* nan will always evaluate to false
* The great good torque purge
* adjust default friction
* Add data for more cars
* adjust name
* Welcome back, guys. Only adjust good torque if maxLatAccel is set
* Update refs (1.7 is 1.7000001...)
3 years ago
3fbbb7f4b0
Common interface attribute function ( #24731 )
...
* replace get_attr_from_cars with get_interface_attr
* and not combining the brands
* explicit check
* minimize diff
* values
3 years ago
5b105facae
Add ACC faulted status to carState ( #24399 )
...
* add accFaulted bool to carState
* same for VW
* remove import
* bump
* move to common
* bump cereal to master
3 years ago
c1caca104f
Support RAV4 Hybrid 2022 with stock longitudinal ( #23969 )
...
* add panda flag for toyota stock long with camera
* clean up
* Add 2022 RAV4 Hybrid from Philly
* fix wrong fw in interface, did this ever work?
* Must be a hybrid
* no radar parsing
* fix can error
* move to own platform
* generate docs
* fix
* Add 2022 Rav4 XSE Australia fingerprint parameters (#24303 )
* Update values.py
Add 2022 Rav4 XSE Australia
* add commas
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* bump panda
* wait, the camera doesn't even send 0x343, right?
* use a set instead, more obvious
* don't test without a parser
* bump panda
* flip panda flag
* bump panda
* add commas
* regen and update refs
* set to none by default
* revert parenthesis
* update comment
* bump panda
* regen and update refs
* add test models and update readme
* bump to master
Co-authored-by: BrettLynch123 <34538435+BrettLynch123@users.noreply.github.com>
3 years ago
efa98d2a06
HKG: only allow engagement on user button press ( #24140 )
...
* use deque for prev_cruise_buttons
* stash
* disallow engagement if resume or decel isn't pressed
* fix buttons
* reduce chances of causing 30-frame fault
Fix clu11
drive down cancel times
* Revert "reduce chances of causing 30-frame fault"
This reverts commit 0f54c051bf5a22b1f584718ec46e78bc3a82a0dd.
* consider pause/resume button
* stash
* Revert "stash"
This reverts commit 551ca7be6c45729f0747abc81cd81894cd621c32.
* sadly some cars need 8 op frames (identical to 4 updates from CLU11)
* add main button
* 6 should be safe
* use max
* clean up
* change to 4 samples and process all messages received, like panda
* bump panda
* test: replay segments with known re-engagements on-device
* Revert "test: replay segments with known re-engagements on-device"
This reverts commit 9730c3c14f942b82b6ed5ef2e81b8ae0126f3006.
* need prev_cruise_buttons as we don't run every CAN message through carstate
* more generic
* extend
* Update selfdrive/car/interfaces.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* 3% faster at 1000000 loops
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
49c2164814
add alert for CAN bus timeout ( #24162 )
...
* add alert for CAN bus timeout
* add alert
* set in interface
* cleanup
* cleanup
* add event
* fix mock
* bump
* bump opendbc
* update refs
* return reader
3 years ago
6013d733a3
add mpld3 python pacakge ( #24138 )
...
* add mpld3 python pacakge
* move to dev
* fix for new pylint
3 years ago
f1f40c117a
Add Disengage on Accelerator Toggle ( #23977 )
...
* Squashed commit of the following:
commit 953bcf0ecf8d03f0fec9ce0d5442cc660ae2347d
Merge: b4198608d 333257bad0b9790dd281862fce7d60c44e03⛽ ➡️ 🔋
bump
commit d2b64b89cf8d7265bc90848b4e3a2276c9a4cb78
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:19:34 2022 -0700
these changes will be in border PR
these changes will be border PR
commit bed31e63de2244c161729773978fef8a9246ddb5
Merge: 491417640 e91613bc6c88ced1f199c02bdd2db7b49c71820b198945fe00fb77820b19894991763f9ffd7c758d4b91763f9ff4🔥
commit 1885c9e2ba1f591736a9c70e8bca1f591736a2465811f0b7410160d0465811f0b40344363a53700efcb3f3e915cf62700efcb3f4220ce272fed273bb78ac1a85afd60ce3be32afc2f27203af3a04c0ad1a5499cf13caeb2230254ca787475e02cb
3 years ago
ca3171c0f9
bump cereal
3 years ago
adf34c3414
CarParams: remove max steer ( #24044 )
...
* Remove max steer
* Update ref
3 years ago
bae78dd46b
don't read params in car interfaces ( #23978 )
3 years ago
5fe00fb773
Move gas/brake pedal event logic to controlsd ( #23850 )
...
* move some state machine logic to controlsd
move some state machine logic to controlsd
* same order
same order
* move unsafeMode up
* disable at standstill
* save last CS
save last CS
* do we need to copy at all?
* don't copy
* rename
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Revert "Update selfdrive/controls/controlsd.py"
This reverts commit 10bb51a0f0
3 years ago
ae19308e83
add parkingBrake to carState ( #23968 )
...
* add parkingBrake to carState
* fix gm
3 years ago
5c3f3e44bc
break up selfdrive.config ( #23959 )
...
* break up selfdrive.config
* add to release files
* fix import order
3 years ago
7254db3906
LongControl: fix control state oscillation ( #23333 )
...
* check if plan is to accelerate or not
* remove comment
* needed to see it
needed to see it
* test logic with Toyota TSS2
* hackily log conditions
* Revert "hackily log conditions"
This reverts commit 7a6b5691e2b982c7a1e3911d980fb7530647affd.
Revert "test logic with Toyota TSS2"
This reverts commit e583d6e3caaa5f5b896165cd7949dfc1caabfd9a.
order
* revert
* fix
3 years ago
87849f93b1
better steer fault names ( #23890 )
...
* better steer fault names
* bump cereal
3 years ago
2c7845fce0
Longitudinal control: interpolate longitudinal plan ( #23787 )
...
* interpolate longitudinal actuator delay
rename
* formatting
* interpolate v_target most importantly!
* fix interpolation and rename
* nicer setup
* left in from testing
* update refs
3 years ago
9535dc606d
Longitudinal: add Kf to carParams ( #23752 )
...
* sane_kf
* long_kf + cereal
* update ref
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
7410160d09
unsafe mode: update safety declaration comment ( #23753 )
...
* update safety declaration comment
* whoops
3 years ago
ee71fd2fcc
clip steer saturation counter to steerLimitTimer ( #23638 )
...
* clip steer saturation counter to steerLimitTimer
* update ref
3 years ago
31d147dca2
controlsd: verify unsafe mode consistency ( #23563 )
...
* add unsafe mode check to controlsd
bump submodules
forgot to add to health_t struct
bump
ahh forgot to set it!
bump
bump
clean up
clean up
bump
* fix ordering
* move to end
* unsigned
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
57156c4482
Chrysler: remove standstill exception for gas disengage ( #23515 )
...
* Chrysler: remove standstill exception for gas disengage
* remove test exception
* bump panda
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
cf9792dc53
Longcontrol: remove starting state ( #23328 )
...
* remove starting state
* new ref
* ready for merge
* try this
* cereal now on master
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
3 years ago
0148b233cd
Add comment about vEgoStarting to interfaces ( #23327 )
3 years ago
14bf834fef
Abstract classes inherit from ABC ( #23246 )
3 years ago
4f1eb4278a
Log actuators after applying rate limits in CarController ( #23230 )
...
* return actuators from carcontroller
* log it
* pass to latcontrol
* chrysler
* gm
* honda
* more brands
* rest of the brands
* gm cleanup
* hyundai cleanup
* update ref
* rename field
* fix subaru
* add types
* more subaru fixes #23240
* consistent whitespace
* bump cereal
3 years ago
2799ef5292
Remove minSpeedCan ( #22991 )
...
* Remove minCanSpeed
Remove minCanSpeed
* it actually only goes out to 2.5 seconds, this is okay to remove
* test to see if this preserves behavior
add minSpeedCan
* Revert "test to see if this preserves behavior"
This reverts commit 31b11f017f7e9da7654fc8064b5983d4a6cc22e5.
* preserve behavior (don't enter stopping as early)
* vEgoStopping needs to be less than or equal to vEgoStarting to avoid state oscillation
3 years ago
44adea73ce
fix max speed comments
3 years ago
e6180738fd
add CarParams.wheelSpeedFactor ( #23079 )
...
* add CarParams.wheelSpeedFactor
* Fudge speed for Lexus RX
* should have been the TSS2 model
* bump cereal
* refactor into function
* update refs
3 years ago
a0e5eccb70
Toyota: handle brake hold ( #22810 )
...
* disallow engagement if brake hold active
* we can check once
* move to common events
revert
* fix
* update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
b76ccaac37
better alerts for temporary EPS faults ( #22747 )
...
* better alerts for temporary EPS faults
* reorder
4 years ago
b49f518782
GM: EPS fault workaround ( #22404 )
...
* seems legit
* panda -> loopback
* fix comment
* add some "why" comments for the next guy
* re-test with stock 50Hz rate
* ugly test
* Update selfdrive/car/gm/carstate.py
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
* update refs
* Update selfdrive/car/gm/carstate.py
Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
82ad6642e2
Quiet steer temp unavailable alert at standstill ( #22680 )
...
* only sound critical alert when not at standstill
* need to flip
* just change the one line
4 years ago
778374d3dd
[Lateral PID] Function for steer feedforward ( #22638 )
...
* store a function for steer feedforward
* use classmethod
Co-authored-by: Willem Melching <willem.melching@gmail.com>
4 years ago
3461e25944
Lateral PID: move steer feedforward to CarInterface ( #22411 )
...
* move steer feedforward to car interface, in car parameters
* LatControlPID.get_steer_feedforward()
4 years ago
417e229624
Add upper/lower bounds for longitudinal lag ( #22235 )
...
* Add upper/lower bounds for longitudinal lag
* add ref
* update ref
* bump cereal
* bump cereal
4 years ago
b7d1aac197
Parameterize longitudinal control using carParams ( #22200 )
...
* use CP.startAccel
* missing values
* order
* update ref
* cereal
4 years ago
1e62b09e5d
Use CP.vEgoStopping and clean up CP.startAccel ( #22199 )
...
* use CP.vEgoStopping and clean up
* update ref
4 years ago
74b6c87254
cleanup old nidec accel override logic ( #22181 )
...
* cleanup old nidec accel override logic
* add ref without deprecated fields
* no more override
4 years ago
b39f6efa3f
parameterize longitudinal actuator delay ( #22153 )
...
* paremetrize longitudinal actuator delay
* update ref
4 years ago
Shane Smiskol
Cameron Clough
Willem Melching
HaraldSchafer
Adeeb Shihadeh
ClockeNessMnstr
Jason Young
qadmus