from typing import Any, cast import ctypes, re from tinygrad.dtype import dtypes from tinygrad.helpers import dedup, getenv, merge_dicts from tinygrad.device import Buffer from tinygrad.engine.realize import ExecItem, CompiledRunner from tinygrad.engine.jit import GraphRunner, GraphException from tinygrad.uop.ops import Variable from tinygrad.runtime.ops_metal import wait_check, msg, libobjc, to_struct, objc_instance,\ MTLResourceOptions, cmdbuf_st_time, cmdbuf_en_time, objc_id, to_ns_str class MTLIndirectCommandType: MTLIndirectCommandTypeConcurrentDispatch = (1 << 5) class MTLResourceUsage: MTLResourceUsageRead = 0b01 MTLResourceUsageWrite = 0b10 class MetalGraph(GraphRunner): def __init__(self, jit_cache: list[ExecItem], input_rawbuffers: list[Buffer], var_vals: dict[Variable, int]): super().__init__(jit_cache, input_rawbuffers, var_vals) if not all(isinstance(ji.prg, CompiledRunner) for ji in jit_cache): raise GraphException # create metal batch exec icb_descriptor = msg("new", objc_instance)(libobjc.objc_getClass(b"MTLIndirectCommandBufferDescriptor")) msg("setCommandTypes:")(icb_descriptor, MTLIndirectCommandType.MTLIndirectCommandTypeConcurrentDispatch) msg("setInheritBuffers:")(icb_descriptor, False) msg("setInheritPipelineState:")(icb_descriptor, False) msg("setMaxKernelBufferBindCount:")(icb_descriptor, 31) self.icb = msg("newIndirectCommandBufferWithDescriptor:maxCommandCount:options:", objc_instance)(self.dev.sysdevice, icb_descriptor, len(jit_cache), MTLResourceOptions.MTLResourceCPUCacheModeDefaultCache) if self.icb.value is None: raise GraphException("create indirect command buffer failed, does your system support this?") icb_label = bytes(msg("UTF8String", ctypes.c_char_p)(msg("description", objc_instance)(self.icb))).decode() self.needs_icb_fix = int((m := re.search(r'AGXG(\d+)XFamily', icb_label)) is None or int(m.group(1)) < 15) # not required on M3+ self.fixedvars = merge_dicts([ji.fixedvars for ji in jit_cache]) self.varlist = self.vars + list(self.fixedvars.keys()) if len(self.varlist): self.int_buf = self.dev.allocator.alloc(len(self.varlist)*dtypes.int32.itemsize) all_pipelines, all_resources = [], [self.int_buf.buf] if len(self.varlist) else [] for j,ji in enumerate(jit_cache): prg: CompiledRunner = cast(CompiledRunner, ji.prg) icb_command = msg("indirectComputeCommandAtIndex:", objc_instance)(self.icb, j) all_pipelines.append(prg._prg.pipeline_state) msg("setComputePipelineState:")(icb_command, prg._prg.pipeline_state) for i,b in enumerate(ji.bufs): if b is not None and b not in input_rawbuffers: msg("setKernelBuffer:offset:atIndex:")(icb_command, b._buf.buf, b._buf.offset, i) all_resources.append(b._buf.buf) for i,v in enumerate(prg.p.vars): msg("setKernelBuffer:offset:atIndex:")(icb_command, self.int_buf.buf, self.varlist.index(v)*4, len(ji.bufs)+i) global_size, local_size = prg.p.launch_dims(var_vals) msg("concurrentDispatchThreadgroups:threadsPerThreadgroup:")(icb_command, to_struct(*global_size), to_struct(*local_size)) msg("setBarrier")(icb_command) self.all_resources = dedup(all_resources) self.all_pipelines = dedup(all_pipelines) self.command_buffer: Any = None if len(self.varlist): self.int_buf_view = self.dev.allocator._as_buffer(self.int_buf).cast('i') for var in self.fixedvars: self.int_buf_view[self.varlist.index(var)] = self.fixedvars[var] self.range = to_struct(0, len(jit_cache)) def __call__(self, input_rawbuffers: list[Buffer], var_vals: dict[Variable, int], wait=False) -> float|None: if self.command_buffer is not None and self.command_buffer in self.dev.mtl_buffers_in_flight: wait_check(self.command_buffer) all_resources = dedup(self.all_resources + [input_rawbuffers[input_idx]._buf.buf for input_idx in self.input_replace.values()]) for (j,i),input_idx in self.input_replace.items(): computeCommand = msg("indirectComputeCommandAtIndex:", objc_id)(self.icb, j) msg("setKernelBuffer:offset:atIndex:")(computeCommand, input_rawbuffers[input_idx]._buf.buf, input_rawbuffers[input_idx]._buf.offset, i) for j, global_dims, local_dims in self.updated_launch_dims(var_vals): computeCommand = msg("indirectComputeCommandAtIndex:", objc_id)(self.icb, j) msg("concurrentDispatchThreadgroups:threadsPerThreadgroup:")(computeCommand, to_struct(*global_dims), to_struct(*local_dims)) for var in self.vars: self.int_buf_view[self.varlist.index(var)] = var_vals[var] command_buffer = msg("commandBuffer", objc_instance)(self.dev.mtl_queue) encoder = msg("computeCommandEncoder", objc_instance)(command_buffer) msg("useResources:count:usage:")(encoder, (objc_id * len(all_resources))(*all_resources), len(all_resources), MTLResourceUsage.MTLResourceUsageRead | MTLResourceUsage.MTLResourceUsageWrite) # NOTE: the pipelines likely need to be added to the used resources to fix the crash on M1/M2, but I haven't figured out how # this is a O(n) hack to get them used. what should work is: #encoder.useResources_count_usage_(self.all_pipelines, len(self.all_pipelines), Metal.MTLResourceUsageRead) # but it fails with "Invalid Resource (00000009:kIOGPUCommandBufferCallbackErrorInvalidResource)" # to repro the crash (which can also crash other running GPU apps), run with FIX_METAL_ICB=0 if getenv("FIX_METAL_ICB", self.needs_icb_fix): for ps in self.all_pipelines: msg("setComputePipelineState:")(encoder, ps) msg("dispatchThreadgroups:threadsPerThreadgroup:")(encoder, to_struct(0,0,0), to_struct(0,0,0)) msg("executeCommandsInBuffer:withRange:")(encoder, self.icb, self.range) msg("endEncoding")(encoder) msg("setLabel:")(command_buffer, to_ns_str(f"batched {len(self.jit_cache)}")) msg("commit")(command_buffer) self.command_buffer = command_buffer self.dev.mtl_buffers_in_flight.append(command_buffer) if wait: wait_check(command_buffer) return cmdbuf_en_time(command_buffer) - cmdbuf_st_time(command_buffer) return None